Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
User-Agent: Microsoft-MacOutlook/16.62.22061100
Date:   Thu, 30 Jun 2022 10:28:55 +0800
Subject: Re: [PATCH] io_uring: fix a typo in comment
From:   Xinghui Li <korantwork@gmail.com>
To:     Jens Axboe <axboe@kernel.dk>, <asml.silence@gmail.com>
CC:     <io-uring@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Xinghui Li <korantli@tencent.com>
Message-ID: <FA9C6A6C-C02F-4CEE-A423-E4A7BBA61C23@gmail.com>
Thread-Topic: [PATCH] io_uring: fix a typo in comment
References: <20220629144301.9308-1-korantwork@gmail.com>
 <4768f72e-6c23-b2ac-d446-b69ded9c19a1@kernel.dk>
In-Reply-To: <4768f72e-6c23-b2ac-d446-b69ded9c19a1@kernel.dk>
Mime-version: 1.0
Content-type: text/plain;
        charset="UTF-8"
Content-transfer-encoding: quoted-printable
Precedence: bulk

On 2022/6/29 22:46=EF=BC=8C=E2=80=9CJens Axboe=E2=80=9D<axboe@kernel.dk> wrote:
>
>    On 6/29/22 8:43 AM, korantwork@gmail.com wrote:
>    > From: Xinghui Li <korantli@tencent.com>
>    >=20
>    > fix a typo in comment in io_allocate_scq_urings.
>    > sane -> same.
>    >=20
>    > Signed-off-by: Xinghui Li <korantli@tencent.com>
>    > ---
>    >  fs/io_uring.c | 2 +-
>    >  1 file changed, 1 insertion(+), 1 deletion(-)
>    >=20
>    > diff --git a/fs/io_uring.c b/fs/io_uring.c
>    > index d3ee4fc532fa..af17adf3fa79 100644
>    > --- a/fs/io_uring.c
>    > +++ b/fs/io_uring.c
>    > @@ -12284,7 +12284,7 @@ static __cold int io_allocate_scq_urings(str=
uct io_ring_ctx *ctx,
>    >  	struct io_rings *rings;
>    >  	size_t size, sq_array_offset;
>    > =20
>    > -	/* make sure these are sane, as we already accounted them */
>    > +	/* make sure these are same, as we already accounted them */
>    >  	ctx->sq_entries =3D p->sq_entries;
>    >  	ctx->cq_entries =3D p->cq_entries;

>    That's not really a typo, though I can see why you'd think so. It's
>    trying to say that we need to ensure that the ctx entries are sane,
>    as they have already been accounted. This means that if we teardown
>    past this point, they need to be assigned (eg sane) so that we undo
>    that accounting appropriately.

Thanks a lot for your reply and I am sorry about wasting your effort. I wil=
l try to submit some valuable patches. : - )

--=20
Xinghui Li