Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH V13 09/13] irqchip/loongson-liointc: Add ACPI init support
To:     Marc Zyngier <maz@kernel.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        Hanjun Guo <guohanjun@huawei.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Huacai Chen <chenhuacai@loongson.cn>
References: <1656329997-20524-1-git-send-email-lvjianmin@loongson.cn>
 <1656329997-20524-10-git-send-email-lvjianmin@loongson.cn>
 <87tu831ujy.wl-maz@kernel.org>
From:   Jianmin Lv <lvjianmin@loongson.cn>
Message-ID: <cf275b58-69fc-3e05-8f67-3bc40a8170f3@loongson.cn>
Date:   Thu, 30 Jun 2022 10:52:46 +0800
User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <87tu831ujy.wl-maz@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/6/29 下午9:13, Marc Zyngier wrote:
> On Mon, 27 Jun 2022 12:39:53 +0100,
> Jianmin Lv <lvjianmin@loongson.cn> wrote:
>>
>> From: Huacai Chen <chenhuacai@loongson.cn>
>>
>> We are preparing to add new Loongson (based on LoongArch, not compatible
>> with old MIPS-based Loongson) support. LoongArch use ACPI other than DT
>> as its boot protocol, so add ACPI init support.
>>
>> LIOINTC stands for "Legacy I/O Interrupts" that described in Section
>> 11.1 of "Loongson 3A5000 Processor Reference Manual". For more
>> information please refer Documentation/loongarch/irq-chip-model.rst.
> 
> This is what happens with this series while compiling for MIPS:
> 
> drivers/irqchip/irq-loongson-liointc.c: In function ‘liointc_domain_xlate’:
> drivers/irqchip/irq-loongson-liointc.c:170:28: error: ‘GSI_MIN_CPU_IRQ’ undeclared (first use in this function)
>    170 |  *out_hwirq = intspec[0] - GSI_MIN_CPU_IRQ;
>        |                            ^~~~~~~~~~~~~~~
> 
> I haven't bothered reviewing more patches, as this is a waste of my
> time.
> 

Sorry for wasting your time, Marc, I just test on my LoongArch machine, 
I'll fix them and test on both of LoongArch and MIPS machine in future.


> 	M.
>