Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp271304iog; Thu, 30 Jun 2022 00:00:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uOJZvUSwFBRiVBMOo3u2D01rR9UZCZ8b+BrbZBVK0X17cHQMx0KEtwnvRmEL+uQkqXrsdY X-Received: by 2002:a17:906:6483:b0:712:1bfe:eda2 with SMTP id e3-20020a170906648300b007121bfeeda2mr7382885ejm.306.1656572443929; Thu, 30 Jun 2022 00:00:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656572443; cv=none; d=google.com; s=arc-20160816; b=qUpQNM6OSfWoz+e5n59yRSU5vzk0xMND3bzJkEYcK3aiYDgCvZ3fcB/5aG1WL4e/U9 S3TVYKOS0HQK4XiO809jZdQA+A8pPJPcmT3LaPCac2DxAFKvYyzvFnM0sGyvwg7Wq0/V sUDvTEgeCCbtGAqHsqakPyURVqDW5uOMfEynCTSFfGxB8s3dL0TrId9iF6+RpgVGIsS5 dKm3xaCnUQgyBgcTMT14+nXw5KUPeCryxpd6xtwtEMhqrzHgOB9Nti0rF6e9VKaeXMyW NmeE60O5RL+jsl+2jtKSMaQ5twt3EUt2pGFm12KVOsbiekb8BpszFr2b9Chr9j/dPAW9 tuYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MU9cBrlrPieHlGMmordYtwucpbXaX0B9vrHRYTy9W5Q=; b=mnVdylpCJDMkQXZ7kmiSgrsFYlJeUdaSugfirEff0eB0ElZAZBXC9tRSML55kesztf YIC1+0WUQBtoIRxaOxr14VhnPGFc6+xR/zzz/qjzeVNVJpkMikXnP9QtudXZOAgezgB3 c1OVj/Y0GPwZbpNEzi0BZOjZciiVI+Jp7+7TNGzlR86Si5qGOzvlwnHVezNp0JyE2yDq yuL9mHqrNWb9wXnOTtQAZDbVL8Yt0TT8Y18ND9E25EsyVbMaYkLKMqRxBqtMwIadl/hA qf6TijgagLxktVO2y0T92KBwlwMKubv/FVfKfD3uRGeGTgcbqGEcB9u9F8fvaxVvEML+ Kcng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1OvESiIr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js21-20020a17090797d500b0072636d040c2si23355587ejc.104.2022.06.30.00.00.11; Thu, 30 Jun 2022 00:00:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1OvESiIr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232861AbiF3Gyh (ORCPT + 99 others); Thu, 30 Jun 2022 02:54:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbiF3Gyg (ORCPT ); Thu, 30 Jun 2022 02:54:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A50E21822; Wed, 29 Jun 2022 23:54:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9EE3EB82604; Thu, 30 Jun 2022 06:54:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CD44C34115; Thu, 30 Jun 2022 06:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656572073; bh=Oc83V9rZVapugamHQO61OIkhuj92VI3JWG+xP2f66GM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1OvESiIreK8McHhAazCMjlaRve/btiMWa1cCLYV3LBwK4wT2EA1thwJ+YPOX7HAws J5Px8R/MROEDDFlp0zwUdczannrmtN41HFzoKB9SnPjddey/1DImW046/EOq6dxUpm cOUq+lScrvqeQV+oYn4E3CI7t0cPlzTm0F4Vgwrw= Date: Thu, 30 Jun 2022 08:54:30 +0200 From: Greg KH To: Jianglei Nie Cc: pawell@cadence.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: cdnsp: Fix potential memory leak in cdnsp_alloc_stream_info() Message-ID: References: <20220630005148.2166473-1-niejianglei2021@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630005148.2166473-1-niejianglei2021@163.com> X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2022 at 08:51:48AM +0800, Jianglei Nie wrote: > cdnsp_alloc_stream_info() allocates stream context array for stream_info > ->stream_ctx_array with cdnsp_alloc_stream_ctx(). When some error occurs, > stream_info->stream_ctx_array is not released, which will lead to a > memory leak. > > We can fix it by releasing the stream_info->stream_ctx_array with > cdnsp_free_stream_ctx() on the error path to avoid the potential memory > leak. > > Signed-off-by: Jianglei Nie > --- > drivers/usb/cdns3/cdnsp-mem.c | 1 + > 1 file changed, 1 insertion(+) What commit id does this fix? thanks, greg k-h