Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9eeb98b1-b53b-f90a-7610-5d40509d8204@gmx.de>
Date:   Thu, 30 Jun 2022 08:51:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] fbdev: fbmem: Fix logo center image dx issue
Content-Language: en-US
To:     Guiling Deng <greens9@163.com>, daniel@ffwll.ch
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220628163641.4167-1-greens9@163.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220628163641.4167-1-greens9@163.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 6/28/22 18:36, Guiling Deng wrote:
> Image.dx gets wrong value because of missing '()'.
>
> If xres =3D=3D logo->width and n =3D=3D 1, image.dx =3D -16.
>
> Signed-off-by: Guiling Deng <greens9@163.com>

Nice catch!

applied to the fbdev tree.

Thanks,
Helge

> ---
>  drivers/video/fbdev/core/fbmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core=
/fbmem.c
> index c4a18322dee9..1fd2bdb11266 100644
> --- a/drivers/video/fbdev/core/fbmem.c
> +++ b/drivers/video/fbdev/core/fbmem.c
> @@ -511,7 +511,7 @@ static int fb_show_logo_line(struct fb_info *info, i=
nt rotate,
>
>  		while (n && (n * (logo->width + 8) - 8 > xres))
>  			--n;
> -		image.dx =3D (xres - n * (logo->width + 8) - 8) / 2;
> +		image.dx =3D (xres - (n * (logo->width + 8) - 8)) / 2;
>  		image.dy =3D y ?: (yres - logo->height) / 2;
>  	} else {
>  		image.dx =3D 0;