Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760850AbXE1Pzd (ORCPT ); Mon, 28 May 2007 11:55:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751341AbXE1PzZ (ORCPT ); Mon, 28 May 2007 11:55:25 -0400 Received: from netrider.rowland.org ([192.131.102.5]:4521 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751211AbXE1PzY (ORCPT ); Mon, 28 May 2007 11:55:24 -0400 Date: Mon, 28 May 2007 11:55:22 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: "Rafael J. Wysocki" cc: pm list , LKML , Matthew Garrett , Nigel Cunningham , Pavel Machek , Oliver Neukum Subject: Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend In-Reply-To: <200705272231.54535.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 26 On Sun, 27 May 2007, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Use a hibernation and suspend notifier to disable the firmware requesting > mechanism before a hibernation/suspend and enable it after the operation. You're using the PM_PRE_FREEZE and PM_POST_THAW notifiers for both this and the userspace helper change. Is it your intention that drivers should continue to request these services but encounter an error if the request occurs at the wrong time? Or do you expect drivers to use the notifier chains to know when they shouldn't make any requests? In the second case you may have a problem, because there's no specification about the order in which the notifiers are sent. The service may get disabled before the driver learns it isn't available, or the driver may think the service is once again available before it gets enabled. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/