Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Jun 2022 09:28:06 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     zys.zljxml@gmail.com
Cc:     tj@kernel.org, viro@zeniv.linux.org.uk,
        linux-kernel@vger.kernel.org, katrinzhou <katrinzhou@tencent.com>
Subject: Re: [PATCH] kernfs: fix potential NULL dereference in __kernfs_remove
Message-ID: <Yr1QhjNGVJ7oPpRX@kroah.com>
References: <20220630040047.3241781-1-zys.zljxml@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220630040047.3241781-1-zys.zljxml@gmail.com>
Precedence: bulk

On Thu, Jun 30, 2022 at 12:00:47PM +0800, zys.zljxml@gmail.com wrote:
> From: katrinzhou <katrinzhou@tencent.com>
> 
> When lockdep is enabled, lockdep_assert_held_write would
> cause potential NULL pointer dereference.
> 
> Fix the folloeing smatch warnings:
> 
> fs/kernfs/dir.c:1353 __kernfs_remove() warn: variable dereferenced before check 'kn' (see line 1346)
> 
> Signed-off-by: katrinzhou <katrinzhou@tencent.com>

Can you please submit this with your legal name that you use to sign
documents?

Also, what commit id does this fix?  Did you actually hit this with a
real workload?  How can this be reproduced and tested?

thanks,

greg k-h