Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3fe54848-f9ab-9cda-6da2-6f37d8cf337f@suse.com>
Date:   Thu, 30 Jun 2022 10:27:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH RESEND v2 1/2] net: usb: cdc_ether: Add Fibocom L610 modem
Content-Language: en-US
To:     Sven Schwermer <sven@svenschwermer.de>, linux-usb@vger.kernel.org,
        oliver@neukum.org
Cc:     Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
        linux-kernel@vger.kernel.org
References: <20220627133620.272716-1-sven@svenschwermer.de>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220627133620.272716-1-sven@svenschwermer.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW9uT3pmWlhkRnVlbTA5ajhpSHVWZTZvemticjBJbDdnWm1mdGdtaXFMekh6?=
 =?utf-8?B?NFFXTXNmRlAwTktLejdhS1hIU01DbC94L3dSWDNYcnJpb0IwUmViVFo4eTJZ?=
 =?utf-8?B?TmVYSmg2RVFNV3M2QzYzNW1YOGFWYlp0Tkc1d3EzWTFsZE5jSGFYVGk2L0Vr?=
 =?utf-8?B?bGJWY096QWlPS3V3RHNmQWR0OWU5QXVJYmVTc0Roa0VQYlB1ZVF4akpkL3Az?=
 =?utf-8?B?Vzl4KzZhaURSbllOUHFxbkh0TkhDZE41YkxLTU1IOVB3cHp5TkN0T0lscE9E?=
 =?utf-8?B?RDhyZG1iTHR2TVJIaDVtQnI4R1hVSEhDeG1vc3J6dytjOFJGV2xiZTRVeVQ0?=
 =?utf-8?B?SXR5eDBlS1JPSXZGM09yb3BtaW1GTjB3V1ZDS090Y09ab0xBQkRaT0xkZXFS?=
 =?utf-8?B?MGd2eitOUURIdUJMeFFGaEtjUERRU1FsU0w1K2JndzJmTlpnRGp6eUh5Uzl6?=
 =?utf-8?B?OUR6b3BXMmlVZ2lLRlFBcXRFN1NRbUhFVmVBd2NIdDFSL0tZRzZtcjhxeXE5?=
 =?utf-8?B?Q1M5T0lsVEFvTHI2cTJUTCtDMjlybkdFYjJhSXBhaFdwWGsyU1J6Y1RxLzdm?=
 =?utf-8?B?MFV0LzdMbjlxeGxicVdKN29SMHlvenF2d1hQK0pUcVJFdEhFaldsOFpUL1lG?=
 =?utf-8?B?NDVCdWJjci9Md242c3V1Z2ZsTk1rZFhPdlQ4QUY4N2Q3dTIxTk1vaThCUjN3?=
 =?utf-8?B?WHpMUTRrd3p0VllQekZzZTlQbndQU1VVSzNLT1Rrc3NYMElHb0o5VXVBNXoz?=
 =?utf-8?B?ZlF3ZFZhUXdCaG9CWWx4Vmw3Smp4R3A0TlMwRTFNdUEyOXZmU0hNUE1ycDlI?=
 =?utf-8?B?Qi9ncVZKN1QySkhIdmlDalMwTWJGT0U1MnJOeWRTcVVPYnBMQlZMeE1hNWYx?=
 =?utf-8?B?S1RpdE8reFo1N1p1Q3M3VTlDYldSNUFIeUdQdnRmTlBwVzQ3MlFZWEpvb3FM?=
 =?utf-8?B?U21UYTZFdEd2L2xxUEt1SDhJemtoTlBSQVdKSzM1TXRtb2FvUHlDQTFyR1VD?=
 =?utf-8?B?dXVvY2E5ckxUSHdKejUvbTJFYUhzbmNjMzE2OTRQVStyYVdzRDJGYUF5Uzdm?=
 =?utf-8?B?QUdtWWY4TytnazBrMnRJRS9YMGJFR1NJMmQ4OTBMS2w0T3A5L0ZMSFcxUllT?=
 =?utf-8?B?OXBDZTN1M0ZQdmZPQ0hRckZiUnEvbkF6eFA1VkgrSHprcmpiajd0ajludzBr?=
 =?utf-8?B?b05BNU1saEs5Y0cvKzEwSGR2ZjQ1V2VhWUVhbUpFdUVVbU9XeG4wWm9sSVQy?=
 =?utf-8?B?MEVNTzFoQnl6WVNOaTBBK2lnNnYydVBtY2Q0d0tjbmFRT1JhUVZ5QVZLMXdh?=
 =?utf-8?B?cVcwZjV3N1NDdFN5dkdyTllCKzJIWnl2VHhoUXRWcFNNMS90S1dEcmJJMjJx?=
 =?utf-8?B?djJRNWV0Z2h3a3E5dTZyQkRkVlllN2RyYnVlTldLQ0Y0NmJIWk5IdE16bGtl?=
 =?utf-8?B?bGQ5elF1MkZTRHMzOWF6TVNOSmdGTlRSOEt4alVETGlVaUJQK2N1bk85Rlpx?=
 =?utf-8?B?Skk3RWlJSDRRUWFyZnNORjFDdDJuUXhzalBYWW5qejVrbDZKU2dZSlNSSkRj?=
 =?utf-8?B?TzYxR2FQZGFvdlZzL21GK1RoNnVadUFsQmZFREhhamN0VVE3U2V3L3BQNXdF?=
 =?utf-8?B?Wm44Q0hWQ2RaWW1reVB2TEw5QjBmZDNuTWxTY3Nodng5SmNBcnpPYTl1Q1ht?=
 =?utf-8?B?cjNKTkZzak5OK04rcjBxYWg4djNNbFZ0RnNaVkVIZVoxOXZpZ09heStlV1ly?=
 =?utf-8?B?RHB2dlFZRVlqaUtBbncyaXFBd3NHY2ZoaDFHenNaNW1NcGoxandUaDd0WHdF?=
 =?utf-8?B?dmkrbzYzdzFHVXN5TlFKSnpIdFJIdzRXb1pBckJLQzRCV3ZSaUhsK3B4bFRB?=
 =?utf-8?B?Q00yWXIySTBlYzZGUTlrT2Z2VjFiUDhBU3BMcGZjYk9STWRUMXhTZWdiOHQr?=
 =?utf-8?B?cUFvTEthb3VqM092MDFnZTBSdmJmNlBaajRxUkFpeDhlaWRjQ0F2cFk3WVFx?=
 =?utf-8?B?OGtEMnJGQTRtM1JHd0NRWi9Ra2g3d3V3WkxrZG9raGc1ckJBMnhhclpyN1h1?=
 =?utf-8?B?Q0RpS041cUc3d2QwRzduYVBUalM2Z1M5OTN4bmxJRzh3VENVTTNMMVhHbGo4?=
 =?utf-8?B?ZzFHZEsxcDM5eGtDR3hYVXh6eU5HdlJ0TjJtVVl4bklGMXU3V2Q0SXU3b2tF?=
 =?utf-8?Q?JvvoOv1sTEGSZLhdTnHEcMXR+sgcFWIRsfFvUlHcpp54?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9cbe7ec-6b29-4ef5-7ca9-08da5a725824
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 08:27:17.9935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gdhBBxRZumIUXGV26VN/G+EgitqDsiDZbOujTLhi7Yv00xpo0n8yfWiO+6XhJ96PsVkvU6Dq2M1Sk+3IWlbyYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3651
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 27.06.22 15:36, Sven Schwermer wrote:
> From: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
> 
> Since this is a modem device enumerating as an Ethernet adapter, we need
> to whitelist it as a WWAN device which tells userspace that this device
> requires setup (via AT commands) before it can be used.
> 
> The L610 modem has 3 USB configurations that are configurable via the AT
> command AT+GTUSBMODE={31,32,33} which make the modem enumerate with the
> following interfaces, respectively:
> 
> 31: Modem + NV + MOS + Diag + LOG + AT + AT
> 32: ECM + Modem + NV + MOS + Diag + LOG + AT + AT
> 33: RNDIS + Modem + NV + MOS + Diag + LOG + AT + AT
> 
> A detailed description of the USB configuration for the ECM mode
> (+GTUSBMODE=32) follows:
> 
> T:  Bus=03 Lev=01 Prnt=01 Port=06 Cnt=04 Dev#=122 Spd=480  MxCh= 0
> D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=1782 ProdID=4d11 Rev= 0.00
> S:  Manufacturer=FIBOCOM
> S:  Product=L610
> C:* #Ifs= 9 Cfg#= 1 Atr=e0 MxPwr=400mA
> A:  FirstIf#= 0 IfCount= 2 Cls=02(comm.) Sub=06 Prot=00
> I:* If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=06 Prot=00 Driver=cdc_ether
> E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=32ms
> I:  If#= 1 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether
> I:* If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether
> E:  Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 7 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=88(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 8 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> 
> Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
Acked-by: Oliver Neukum <oneukum@suse.com>