Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b3a1614-698a-6d21-118e-943f6dc992c4@nvidia.com>
Date:   Thu, 30 Jun 2022 10:38:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2 3/6] clocksource/drivers/timer-tegra186: Add support
 for Tegra234 SoC
Content-Language: en-US
To:     Kartik <kkartik@nvidia.com>, daniel.lezcano@linaro.org,
        tglx@linutronix.de, robh+dt@kernel.org, krzk+dt@kernel.org,
        thierry.reding@gmail.com, spujar@nvidia.com,
        akhilrajeev@nvidia.com, rgumasta@nvidia.com, pshete@nvidia.com,
        vidyas@nvidia.com, mperttunen@nvidia.com, mkumard@nvidia.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org
References: <1656527344-28861-1-git-send-email-kkartik@nvidia.com>
 <1656527344-28861-4-git-send-email-kkartik@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <1656527344-28861-4-git-send-email-kkartik@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEs2ZHpFZU9xcmJNTndLSmNuZjVkaG80ek1uQjRTeHRFVld3SFBlZi9KUlA0?=
 =?utf-8?B?T0l6NWtOaFNXd25zVVNVaXNJcnpzR1ZQVzdKRnZmdis1b1IxT3QxMU5tNXBL?=
 =?utf-8?B?bDhWRkt4VmFRbmJGZEJlR0R4eFpxaDdHL2pXUEVXa2gzSWQ3VGU5UWQxbXRZ?=
 =?utf-8?B?aG1GUXdDd3VYaUcyS0thdTNnTkY0dGVrN0JSamwwVWkyb0kzUmxVQVRuS0hP?=
 =?utf-8?B?d3BzOXR0TWNjelEzVzFOUEZ1OFZPZ2N2RnJnMUpiRFdlT0h6VndxY0pUVHpi?=
 =?utf-8?B?MDBaMm1tTEJrSzNUZXkyaGhHbDZFcGE1eUtzS00wcnE4VExnK0sxVVJtcVJY?=
 =?utf-8?B?c1JPL25TMjFQdTdjdGVlYjBnM0lCci84ak9YbDlnNmMzLzFZUHcrMFovcWwy?=
 =?utf-8?B?T043aEwyb1lFQi9LZE5Pdy92cmlrZ2o1UDh0ZkZDSlVWT0ZBNHBSblpRbFlx?=
 =?utf-8?B?ZGV6TkVSZFBVL2h5TjZzME5Td0dqQ2oxdDM0aERyWExLZXVDajNBM29DN1No?=
 =?utf-8?B?OUJSQnhHUjU1RE4ySTdtQlg1RHo5S3pOenV4NCtMa3J6anVLOWJkcGZBNXUv?=
 =?utf-8?B?T1YyaHJheXZRaElDc0ptdkU0VzIxRFpsRjJ1ZVlkNWd1WGpyeFVpWENYeTVX?=
 =?utf-8?B?V2E3TzZpdytNQkxFekZIL2c2eGFRdEo5YXdtVkx1MVhHTFBPNUJVVzQ5VDFu?=
 =?utf-8?B?NHQveG1vY01SZm5HVHpTcnNTR2VCVm0yTXdOc1VaUnBaVDduekZvN0dVQmhB?=
 =?utf-8?B?RkpvcWpoVE5EZlc1Sk5QWVluajBlbDR3Zlg1S1JvMHcvbGsyNVhCeDdySG9O?=
 =?utf-8?B?OGVucFZZOXh2bE9lTmJzZE1XcjFJL2I2Ui9IdytiS2xnSzI4OTk1bWpDQWgw?=
 =?utf-8?B?MUlwS0Nqa2dtWU10Rm16c2FLbnZMWWx2NVpON21Xc1dHY2lQVW04RGtUalht?=
 =?utf-8?B?WTRUV0srUitUOXN3YkNqYVowM3ROUVZvY25ORkNDemw3VmdYVDA1dVBhUmNh?=
 =?utf-8?B?eTNoRWNDMzBOWVFja0t1eDdnWk5iVmQvZElnU3ZUTzF0MXovbThTNXB6elFP?=
 =?utf-8?B?UEl6b0dMSHVlRkxiZzFhWU1PNjF2Ly9MVXpkNGJOaGQydk5MQmVPZ014VmdP?=
 =?utf-8?B?c1RjQ1UxaldYODRBRjhHUGhxa0l1MDdGZXcrWklsT2h0dFllRVFUeFVxZWc1?=
 =?utf-8?B?eVFUNlpUL2dVZVZmKy9zc1hINkZ4NGRKbi9hM3h0UnE5NlVoRHJrQkVtLzgv?=
 =?utf-8?B?UTdpUGNNSkFicHhVZ0lySDI0cHBBMnFLSXlVN3VTUkdybStaUEkyOFZwdjlS?=
 =?utf-8?B?ZjFyS3RqKzIvSGxVaWRXY0JNcmNtTWRaZ25sZWFXMDJIb0xWVDZaMERSSXR6?=
 =?utf-8?B?N21TUmFOMU1idTVsSDZZU0VMUG1jZWpZQUVsSlZ2eFVXNEYwV0RaNGw0T0g1?=
 =?utf-8?B?c3dqY3JDSkZYRTcvMVkvWFhLWEo3WDJaeCtHTlgrY2oycXhjZHZnc0RsdkV1?=
 =?utf-8?B?MUpFR2ozZHg4NkVyOWVxTFJTS2tYVWliMXk1MjZ2UW00Y1dCcGlDc1hmM2My?=
 =?utf-8?B?TXpyWENLS3g3REtKMVNKSmpQdzB2bmk0RmU3YjBEMmJpV2VMYVpmRDhqbWpH?=
 =?utf-8?B?YTR0R3RtY0NOd1FKN0JFU0xhV2piM2NZM2FRbGJEZFVZd1o5eHl2VDYzSC9o?=
 =?utf-8?B?Q0FUSjRVeWZZUDNhcC9RYUFlQ1pMT3JWS1FHMm8wTVFPaEpQREhvNiszdVpm?=
 =?utf-8?B?UXRyR25WNFF5YmFBY2V5WE1mMDFGRkNuQnNzL3RocENidERGclpPQkRPWUYr?=
 =?utf-8?B?NDY3N2c4UUx0aklLZnoreTFkV2ZoRGQ2aWFJam1xUFhjZE40T0hDNk9xaWZS?=
 =?utf-8?B?Uyt0NjdhSWh6MVBvdHZOS0xIcmxLKytlZUgvMHdBTkZmdXFqUDdDTEZ3YVV4?=
 =?utf-8?B?NGFuQUFyZFdtb2RWV2tJWWZXKzloeU1ZS2ZOSmNpbFNBUjBER1pJNkliNVlO?=
 =?utf-8?B?TW9jeDhDK1R2S2lHSm8xcFcyZUNwTGdWNmJ5RjBOMUxwa3BZcUlRbTVCSkdP?=
 =?utf-8?B?aWhxOWFaNnZORjluQlBnRDFvd1FVMGY4UEdjKzJlc0pDeU9FMzFNbnFGc1pw?=
 =?utf-8?B?UGExTTl1L2Y4YjJtZDZEN0Y3VmJQbnQrU1VkbERIa1ZuSm0remI5OGxpUUMw?=
 =?utf-8?B?U0E9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 742a06ab-6450-42a6-2f07-08da5a7c4412
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 09:38:19.3176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z5QpwalLuRebbDwTqV86wOANZveKpEXPmEwsxX+m5XjqUbGTgX3vzR9j63ZfcQehzmle9AijDxUqs/P0h4VJRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5690
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29/06/2022 19:29, Kartik wrote:
> The timer IP block present on Tegra234 SoC supports watchdog timer
> functionality that can be used to recover from system hangs. The
> watchdog timer uses a timer in the background for countdown.
> 
> Signed-off-by: Kartik <kkartik@nvidia.com>
> ---
>   drivers/clocksource/timer-tegra186.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/timer-tegra186.c
> index 4515517c87a5..ea742889ee06 100644
> --- a/drivers/clocksource/timer-tegra186.c
> +++ b/drivers/clocksource/timer-tegra186.c
> @@ -486,8 +486,14 @@ static const struct tegra186_timer_soc tegra186_timer = {
>   	.num_wdts = 3,
>   };
>   
> +static const struct tegra186_timer_soc tegra234_timer = {
> +	.num_timers = 16,
> +	.num_wdts = 3,
> +};
> +
>   static const struct of_device_id tegra186_timer_of_match[] = {
>   	{ .compatible = "nvidia,tegra186-timer", .data = &tegra186_timer },
> +	{ .compatible = "nvidia,tegra234-timer", .data = &tegra234_timer },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(of, tegra186_timer_of_match);


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon
-- 
nvpublic