Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp428302iog; Thu, 30 Jun 2022 03:37:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uCxv6s1Nou+5Y7tDRr8MKOwaNG70oKlnvzO25mnkdHVqPCqY3IOxFXu9WPv/wzg7bhs4Ki X-Received: by 2002:a17:90a:af98:b0:1ef:1d10:c052 with SMTP id w24-20020a17090aaf9800b001ef1d10c052mr9263415pjq.111.1656585450160; Thu, 30 Jun 2022 03:37:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656585450; cv=none; d=google.com; s=arc-20160816; b=kb+KXUV0H4yAK53LUsiWCf7cljOUaygxgIpt5UQMn7ux7Qt3stpBsKRxA1/TakMMA2 ithjBmiZmJIShmPnbod/QxmGDxBa700Oi5yw+DVcCRSBTPXKvGTB/rhqclf+HgHLXUxH /nmpDhDPHElYK7ddgI5U7GtofMZwsrc8lJe3bgPGJKEBQJ9+6ZmdnntQaKBTvWNJlqd7 XU43HtOUgh9/D36kd5a3crzFVFHuKQLwfa3bfzD+2MpS3Eyab4KT6s1BXaoZkFzfZNx6 kgZTe+aHYTEzpogMg4UJl/kpETijS8SLOZG4isCZ2SVyK5uZTREsVc76/H90jH8zZp23 MioA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=Y+cwKL/yroVNOEz9iqJ+pwZUQRxs0te/R7hWk4B1qfY=; b=KT9K+BXQHrAtpdVuOBTOEX7YfUIL58uXmO/9BsMS4+DSR7MnZm+jS7LafuyJoqrm4T b7ZuSkq35F8PlZ6Lz/FZtWwBKP5PFjBNE8Gcv8L/UkE7rX47JpxKGRev15q05yqeIyom 0UTsdYeFQHHFwpznQq5p1BJ5taEWS5/i4CbhaFaX2Ktmrrti+X0LhzLCdsxP5qoK8FVD KWMq7rcqYw8rggxGvdbRRJXH3FYJs66RosrAZrOdsexku4KFugl8T8r3I3AEdGg0XJVl XQRjL5cM7EhMVnlPTMD0/z7FWOY33CClwYQoyUf5tzNXBQTFc0REbV1MrpS8fB4r1MUD rsbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f6DaFtzD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020a630d01000000b0040c9f5a0e43si26054031pgl.338.2022.06.30.03.37.18; Thu, 30 Jun 2022 03:37:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f6DaFtzD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234646AbiF3KAR (ORCPT + 99 others); Thu, 30 Jun 2022 06:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233748AbiF3KAQ (ORCPT ); Thu, 30 Jun 2022 06:00:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CA7D43EDC; Thu, 30 Jun 2022 03:00:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D5CE62195; Thu, 30 Jun 2022 10:00:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 72E02C385A5; Thu, 30 Jun 2022 10:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656583214; bh=BWLfKsPSN4yajyxIhFyOTTZXdy8Ooyjrk8lujMp6r2c=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=f6DaFtzD5/f1u+5kOT5ozyzBVPm9bJRcngnEXaYSPfZfqSF2KpUI8y8MC9wppKFdy CLynIjl+WvcRfTy1QGWGU5KJoo8gmgCbaUZ5VIAkNv0DbaFHpjFX+pNPAzxjdegKK5 4toWaQ9DmoQqycHfQz+Cfa81Eqw5zqih6sxMYfmtBTm/cAsfUT/HdfCxpl+VbMGJHn hPAWa5aA2mzhlbtE9fAOTRtwcnjXobdENzG8Gd+3lLA/3jA1Uwt8Ul6Wxr1HT70YBy Jda3W+FFvz7raA4JogWkAZCMXY1HlaaFSa2HtjvVKY4tHVzs5HP9q87hhjmrKJtatY PN1pk2nSZCdPA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 5252EE49FA0; Thu, 30 Jun 2022 10:00:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v3] net: sfp: fix memory leak in sfp_probe() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165658321433.30282.12130648369067340647.git-patchwork-notify@kernel.org> Date: Thu, 30 Jun 2022 10:00:14 +0000 References: <20220629075550.2152003-1-niejianglei2021@163.com> In-Reply-To: <20220629075550.2152003-1-niejianglei2021@163.com> To: Jianglei Nie Cc: linux@armlinux.org.uk, andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni : On Wed, 29 Jun 2022 15:55:50 +0800 you wrote: > sfp_probe() allocates a memory chunk from sfp with sfp_alloc(). When > devm_add_action() fails, sfp is not freed, which leads to a memory leak. > > We should use devm_add_action_or_reset() instead of devm_add_action(). > > Signed-off-by: Jianglei Nie > > [...] Here is the summary with links: - [net,v3] net: sfp: fix memory leak in sfp_probe() https://git.kernel.org/netdev/net/c/0a18d802d65c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html