Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp480194iog; Thu, 30 Jun 2022 04:43:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vX2HWvaawrcxFlm894H8gAaTUrVYCAHTdVMXPcIS9l4bbFMYiuCN9097/72SX5DSZm1LgB X-Received: by 2002:a05:6402:35c5:b0:437:140d:5cb3 with SMTP id z5-20020a05640235c500b00437140d5cb3mr10881843edc.72.1656589389053; Thu, 30 Jun 2022 04:43:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656589389; cv=none; d=google.com; s=arc-20160816; b=C1MsqfilS0dFcYnekUtEsLLWXyiAI0Kj6xRTETTRkB4WSKB+qgOTde86tpmJvSctX0 /7CRZceuTmOy/jJv5jjBybgumD3dOaQPl9jE25zVSt7pV5emtxIoRXTTOxDXKeM1ahKM YIJhayYt7rHqKrFvB96vcncRq3gKlAjovi511W2xcifWGfjLFZEubB/VfHZ1ZV3cJC85 THAp6KblZDrdVQOzWyNrFirSDQsUXM3ZUrhfePgfDUbCzafrs6yoU/IhLFm/5xhnr+4Q gJXcA8JVcN+Jn8GNNmXzUDAbAgq7e7+js/nv6uD/PtB8E4/XWMek1VSj1Ef7RH80icDc EjeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=xOuD0VayMLaVqMSm3qQEckL7M1TiFwHS72WWPKTLO58=; b=E3VOLyeMK+NeT8z4mBkVzF3T4CzqCnCZ/lnE67FacXavDB0sfu28GZMPJSxd2TFPSs qpNNZK4Pozp4hljElFSjJxdah6Q5U+hsyKvSLrh/NEBg56SO2kxZHUq7WPExaTsEUAJO kUgFR46lPWT6UeCGdj60GBlnq6VBaBgjse4OvVlLV6fMQh2OD69xYnVcpfZjhA7b81Zi m5g0OTviGS9LQ7mWimEfMwpM+c8UuY2vNyNgXMNXsEgVd3yXuSqjdkphxegzB/h8fZ/E qARM+FcyFbpJ0e/JcHxjJ2FhUCmshhMc4tSKClswpf8L8LG1xlmQNouzuirpQzfNWvYc rFbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@blackwall-org.20210112.gappssmtp.com header.s=20210112 header.b=f2mg5NQc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c13-20020a170906528d00b007262b342ff2si20472381ejm.53.2022.06.30.04.42.44; Thu, 30 Jun 2022 04:43:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@blackwall-org.20210112.gappssmtp.com header.s=20210112 header.b=f2mg5NQc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234529AbiF3LRu (ORCPT + 99 others); Thu, 30 Jun 2022 07:17:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232504AbiF3LRt (ORCPT ); Thu, 30 Jun 2022 07:17:49 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C1954D4CD for ; Thu, 30 Jun 2022 04:17:47 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id pk21so38393641ejb.2 for ; Thu, 30 Jun 2022 04:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=xOuD0VayMLaVqMSm3qQEckL7M1TiFwHS72WWPKTLO58=; b=f2mg5NQcZInRzApmj3Hn1BwfNl1pudDvuPud+y6bW5QTphTs0bXap0Uu2pOmCLjt67 13Xcr7cbtXO40QwP5BGR3/Lv14ByQi77QfcKQJTj7qwsgFHLYMfioS2b8xPcxClm0exN 02p3T+AEeSkzysS7nxVSBskiMedr+oMz8YB+IB49n+wlv6Xw5o6bFyjETvnBcjFtmfNy WBv6ktj6+xlzz9y7+owgEUGG2ApUAOwv60wCPv8UVM8+o1cA2RPMvOR2txdT2PzZAaWo ijfpniC2e0HaioZ1VUHPbiJEFo37djO+X7EQpbklN41PWDjuWEwEMCoqLhxfyPvQhrkc 8SRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=xOuD0VayMLaVqMSm3qQEckL7M1TiFwHS72WWPKTLO58=; b=v4zkia6owzcZcGdiyRK4tutOo2yT6/3Cw5H/PRvosBpFHExoIB5sZ8dwBhm9W4MXe3 o7W/cfIDCQP9K4FKeq0rC0GshO/DPZh6M1IhbI/Vy8qxq6JTg8EWa1vKx/4vZMVsckSr Yy2O3g80vTMy2jkn2hensN339o2IyqpA58kMVRbPNCMBlSlX1hOPzGYyE3Tc5oJveQIv Je49Cagb7OzFZhbnjbqm7gcJiaiFXHWWHpuSzz4s2n+C+jZRCr9OACyYblwfqhWGTU/1 OqvzxNW/+dtyVovsdPAGBX6jwwDjunR3YyZITsCiu4FDrrJMjckhDN+lz0Y5ravMg/27 sA6Q== X-Gm-Message-State: AJIora+loSvGVT7v2O1G2xzmanYHldOqUTfNedBKBhMylsgdTdU58sDe S6a18TdLBDsaAq4PnYr3YTA0zA== X-Received: by 2002:a17:906:149b:b0:726:2968:e32a with SMTP id x27-20020a170906149b00b007262968e32amr8420709ejc.71.1656587866001; Thu, 30 Jun 2022 04:17:46 -0700 (PDT) Received: from [192.168.0.111] (87-243-81-1.ip.btc-net.bg. [87.243.81.1]) by smtp.gmail.com with ESMTPSA id pv1-20020a170907208100b00726abf9cd8esm4697467ejb.125.2022.06.30.04.17.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jun 2022 04:17:45 -0700 (PDT) Message-ID: <80d971ea-88b9-0d21-b6f4-93124ba6a678@blackwall.org> Date: Thu, 30 Jun 2022 14:17:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH net-next v1 1/1] net: bridge: ensure that link-local traffic cannot unlock a locked port Content-Language: en-US To: Hans Schultz , davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Shuah Khan , Daniel Borkmann , Hans Schultz , Ido Schimmel , linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org References: <20220630111634.610320-1-hans@kapio-technology.com> From: Nikolay Aleksandrov In-Reply-To: <20220630111634.610320-1-hans@kapio-technology.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/06/2022 14:16, Hans Schultz wrote: > This patch is related to the patch set > "Add support for locked bridge ports (for 802.1X)" > Link: https://lore.kernel.org/netdev/20220223101650.1212814-1-schultz.hans+netdev@gmail.com/ > > This patch makes the locked port feature work with learning turned on, > which is enabled with the command: > > bridge link set dev DEV learning on > > Without this patch, link local traffic (01:80:c2) like EAPOL packets will > create a fdb entry when ingressing on a locked port with learning turned > on, thus unintentionally opening up the port for traffic for the said MAC. > > Some switchcore features like Mac-Auth and refreshing of FDB entries, > require learning enables on some switchcores, f.ex. the mv88e6xxx family. > Other features may apply too. > > Since many switchcores trap or mirror various multicast packets to the > CPU, link local traffic will unintentionally unlock the port for the > SA mac in question unless prevented by this patch. > > Signed-off-by: Hans Schultz > --- > net/bridge/br_input.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > index 68b3e850bcb9..a3ce0a151817 100644 > --- a/net/bridge/br_input.c > +++ b/net/bridge/br_input.c > @@ -215,6 +215,7 @@ static void __br_handle_local_finish(struct sk_buff *skb) > if ((p->flags & BR_LEARNING) && > nbp_state_should_learn(p) && > !br_opt_get(p->br, BROPT_NO_LL_LEARN) && > + !(p->flags & BR_PORT_LOCKED) && > br_should_learn(p, skb, &vid)) > br_fdb_update(p->br, p, eth_hdr(skb)->h_source, vid, 0); > } LGTM, thanks! Acked-by: Nikolay Aleksandrov