Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp656138iog; Thu, 30 Jun 2022 07:48:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sd6FoEuHUE0JZlLN5Fiv8TKqotKdSCdEHdT87HXykg9+vQjvKlET/y5m/9fO6SMkEl5SLs X-Received: by 2002:a63:33ce:0:b0:40c:5487:6e6d with SMTP id z197-20020a6333ce000000b0040c54876e6dmr8144819pgz.135.1656600503545; Thu, 30 Jun 2022 07:48:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656600503; cv=none; d=google.com; s=arc-20160816; b=fENHElM2/s0jVW+2euayVcUqo4Kqj1KUTY8AI57BItE2KYIUOJ1SKBgEhkSKokycIo h7YRzZ2YuFvtgq01cWpWqKqSLO/DiTAWLkvRott9xweX8oBNHTK0IF4omjAP3qug+7k/ AZlo8PuZBk/qhvq9gd/vzE9oyp9h/iFBn50iITMovXDobus1LPIwez5rCQZ9Tl+YKLrh 9iiqo2YSdS0Y9b2mbvrrrjv1FSpQNQyQ8o4W+FJHWFQAl7S45ibxqtZQSKWzYUkYzg7M nH26L1ueQ1lFP/ocZ0vX4NNhoFVxWgbzbTujrUAu/XSSuAiykrOaZf2GOmqeDfb/0geC tREw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=L3lNWq/xjy7J/3yRgbOPUNUsJU1wlGABcF0OwJEENMw=; b=jN7oM/aQKqRAeDwAEeSGfHVe8cB9xiBe1tHKtgp+Vy2NJAcyDuyM6DbdlhCMKHj/yf 18kYyEhvksxJGuNg5LgrcmYn7DuILbMypPFMTbTTdI/ph4Mys0bf9lxkc3n4WWkv1AW6 ziJL+Zb3fyXQRPuxpmdr/lfH3h4CY7VFo2k5spG8q7eaLAqfZ/GPL5jkAbYgp+ku6R3a wXvpibqRt06jATYHxIjvqvfO3y6303OtQ9FJ5idXsK+/pTT0fHIIlwhwOMl8Z9hF3TgH dBRitY887Tjavq4t1AbXiYuzlQbCa8NiI6AfLgohe2FWAWxR9tO/DsCnKGIdLp0JZcGW vezQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g33-20020a635221000000b003fd74779846si28511099pgb.826.2022.06.30.07.48.11; Thu, 30 Jun 2022 07:48:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237235AbiF3Og7 (ORCPT + 99 others); Thu, 30 Jun 2022 10:36:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236180AbiF3Ogm (ORCPT ); Thu, 30 Jun 2022 10:36:42 -0400 Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21EC758FCB; Thu, 30 Jun 2022 07:29:58 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=guangguan.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0VHtSBLe_1656599393; Received: from 30.43.105.96(mailfrom:guangguan.wang@linux.alibaba.com fp:SMTPD_---0VHtSBLe_1656599393) by smtp.aliyun-inc.com; Thu, 30 Jun 2022 22:29:54 +0800 Message-ID: Date: Thu, 30 Jun 2022 22:29:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH net-next v2] net/smc: align the connect behaviour with TCP Content-Language: en-US To: Wenjia Zhang Cc: davem@davemloft.net, Karsten Graul , liuyacan@corp.netease.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com References: <26d43c65-1f23-5b83-6377-3327854387c4@linux.ibm.com> <20220524125725.951315-1-liuyacan@corp.netease.com> <3bb9366d-f271-a603-a280-b70ae2d59c00@linux.ibm.com> <8a15e288-4534-501c-8b3d-c235ae93238f@linux.ibm.com> From: Guangguan Wang In-Reply-To: <8a15e288-4534-501c-8b3d-c235ae93238f@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/6/30 04:09, Wenjia Zhang wrote: > > Since Karsten's suggestion, we didn't hear from you any more. We just want to know: > > - What do you think about the commit (86434744)? Could it be the trigger of the problem you met? > > - Have you ever tried to just remove the following lines from smc_connection(), and check if your scenario could run correctly? > > if (smc->use_fallback) >               goto out; > > In our opinion, we don't see the necessity of the patch, if partly reverting the commit (86434744) could solve the problem. I'm so sorry I missed the last emails for this discussion. Yes, commit (86434744) is the trigger of the problem described in https://lore.kernel.org/linux-s390/45a19f8b-1b64-3459-c28c-aebab4fd8f1e@linux.alibaba.com/#t . And I have tested just remove the following lines from smc_connection() can solve the above problem. if (smc->use_fallback) goto out; I aggree that partly reverting the commit (86434744) is a better solution. Thanks, Guangguan Wang