Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp656762iog; Thu, 30 Jun 2022 07:49:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vxngRVKS9fDzCo0V/pUjwroFGVnkETXAAqNPq9Xl3yC8dqS6LHgfswZnBxN/0Kkb6rXznM X-Received: by 2002:a17:906:ce:b0:715:705e:52fb with SMTP id 14-20020a17090600ce00b00715705e52fbmr9149234eji.303.1656600556641; Thu, 30 Jun 2022 07:49:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656600556; cv=none; d=google.com; s=arc-20160816; b=NaUEurNilUCyydCqiHOCKN0z+U1Y1iDanGaEz8I6BGT9Swk4PCTg48m80zvukPuY+h T+IsEP8RhDihBSa7WTz/belXG2aNHiDvToQ+MdovuLcWb4BLFn2RHqH11OIX6JSNLApb p4JgNWo5hqg67tkVOX2n9YpdiTpuTIv7mUY1o5fBrYd0z9o6zg31YNlpA239PAe2azNe i3zXxIGAo+S86kvfFBeolPGlZOPvNxt0jCe1UpZ8Eg9BpdhHQeHujw7PqK/rhVEKU2IW +V0+jyjv3X5OMUl8KJW7sZhNA875N0ipnY+C1LnXNDzlpLnbOr0hxk3xEGpldZwMm3ME lCQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=cYHqzAADhO7uNxWaYZHPHdZJZd45v030Ux4sLwMzq+8=; b=UL6okJVppYy570aygJPaa2J9mqmjgyxeaRWKAxBogKFoPC91lvTixrs4m16rEbVK5j 9S+hNi/mfGMPMgoLjzS58xppsJ9Sg5AN6bGsvhcA+ExBxo6e2VQ0HIaeRogvyE0Xs7Iv nhmnGjy2/iAilyfMDcTi4sC2RVyMbvyYgEtHLBtHyDONxHPg4Xj1MN0aJhQOBwzxYUoA dSR1U8gHJcRYgqPzu+k4Xo4dqwRUcet3ZUJ3fUrQ0nl9+f+erLnErPmrMmLhD5ISPOMP GSY1yB+kNb644NhhQMUkvTlZ0wY5d4AA5YXKjNZNFn6zJqlRw86D+DiuYNbjMhh072Bs HScA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i19-20020a1709064fd300b00711f164117csi24966764ejw.883.2022.06.30.07.48.51; Thu, 30 Jun 2022 07:49:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235999AbiF3OhO (ORCPT + 99 others); Thu, 30 Jun 2022 10:37:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235866AbiF3Ogx (ORCPT ); Thu, 30 Jun 2022 10:36:53 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D67E8DFF5 for ; Thu, 30 Jun 2022 07:31:21 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id AF95368AA6; Thu, 30 Jun 2022 16:31:16 +0200 (CEST) Date: Thu, 30 Jun 2022 16:31:16 +0200 From: Christoph Hellwig To: Ren Zhijie Cc: hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, mathieu.poirier@linaro.org, mark-pk.tsai@mediatek.com, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] dma-mapping: Fix build error unused-value Message-ID: <20220630143116.GA6198@lst.de> References: <20220630123528.251181-1-renzhijie2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630123528.251181-1-renzhijie2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, this looks good with a minor nit below: Reviewed-by: Christoph Hellwig Mathieu, can you pick this up through your tree as that is where the offending commit was merged through? > Fixes: e61c451476e6("dma-mapping: Add dma_release_coherent_memory to DMA API") missing space before the opening brace here.