Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp664886iog; Thu, 30 Jun 2022 07:59:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tpN9erBrMoQHHhE7dyQ2hizXWmTt7upvvhf55igisDYtpfNS1wuL2hPyvHFRXX44gc6N8q X-Received: by 2002:a17:90b:2285:b0:1ec:aa3f:8dc1 with SMTP id kx5-20020a17090b228500b001ecaa3f8dc1mr12514137pjb.145.1656601176275; Thu, 30 Jun 2022 07:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656601176; cv=none; d=google.com; s=arc-20160816; b=yUw/cCjyKBe4ydMD50Ci/t+MzwuMXS3kN5uXQLE3BWKOvgQ9kUMQ1/0J+rQlr0csPo AyUBPvak5Pmc88k5M2nVDHCasQfmoYdOOCH8ctpHGMzl8g6gXXCz3wFl8ON41TrsitYG UKjJZwTmReas+61COA9DFEwMu5TgvTIs4PRxcmP5emtR3/D0b3bdJH887ZwXxEqme47X LhISAXnDoEaM76fBP+EGo2eFvtzYrtV10S8GrUlemvHi4s63iNmzCIX+qCZp9Q94CnLY WAUe+QMGvBq0eO98aabAM7hgQIDxPKFRasxM7nHMJ9h2KTHyfhMB1dnhTlJ07oxQUziV ri1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aRM0iidO4omf4Ygc7e95ycYVqUErUP5VSN0IpbZS4DE=; b=j/NHzIWUkf/Gi9kvYEkj8QxbCcIYZGC+7oxofqc4E0Di0Xhuz1sxPNQlpuKCkYjdet xjvZJraE7VW2N3PqRRtgcj3CDGcguHaYoJqfjvRjB183XMfQJXOwXUlw67ca6eYqArW2 lgtkWdxL4KmdOceg4scQ9nppTP3z+6+AVOUP4W3WkprgmWvOIKJT70tPbgzmEjvu9I5x H60YrrgZsfixqj+WiPxi2XKcGI/KsEO5B33nu7vqLI7KTGRWhZ8MkZv/z7uALaTFmXVm +QFi0lNbj7srdT74IRytSpOQpE7k9xfIbabVteDpp1ifDtio0aOd+Val1hexeqJiooeT NxEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sjCZVfdk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q11-20020a056a00084b00b0050dcc1acf09si26613888pfk.111.2022.06.30.07.59.21; Thu, 30 Jun 2022 07:59:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sjCZVfdk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236106AbiF3OAE (ORCPT + 99 others); Thu, 30 Jun 2022 10:00:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236123AbiF3N5n (ORCPT ); Thu, 30 Jun 2022 09:57:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B44553D02; Thu, 30 Jun 2022 06:51:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6F09DB82AD8; Thu, 30 Jun 2022 13:50:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D368DC34115; Thu, 30 Jun 2022 13:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656597053; bh=NbbeKQEkCqGH7eRSg2mh0Rg8B4WuQz46K8KLqlu+Qdo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sjCZVfdku1dYc0E/Zd6KS1tNvHs0gSv9VDanG0wq6+XzT/Ha0shtMXCAY4UUMomiG t+xXs2Db1O8+3IytBln/O+L+W6JWBqeSsjr4vssfrWFpvBgpPMFvxGLsFq8uXrJzh+ Z5A1/ROBfoARh9yKYwyfM9LdV7yXadf1vymdOJ94= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai Subject: [PATCH 4.19 03/49] ALSA: hda/via: Fix missing beep setup Date: Thu, 30 Jun 2022 15:46:16 +0200 Message-Id: <20220630133234.010703384@linuxfoundation.org> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220630133233.910803744@linuxfoundation.org> References: <20220630133233.910803744@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit c7807b27d510e5aa53c8a120cfc02c33c24ebb5f upstream. Like the previous fix for Conexant codec, the beep_nid has to be set up before calling snd_hda_gen_parse_auto_config(); otherwise it'd miss the path setup. Fix the call order for addressing the missing beep setup. Fixes: 0e8f9862493a ("ALSA: hda/via - Simplify control management") Cc: Link: https://bugzilla.kernel.org/show_bug.cgi?id=216152 Link: https://lore.kernel.org/r/20220620104008.1994-2-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c @@ -533,11 +533,11 @@ static int via_parse_auto_config(struct if (err < 0) return err; - err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); + err = auto_parse_beep(codec); if (err < 0) return err; - err = auto_parse_beep(codec); + err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); if (err < 0) return err;