Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5dbedabf-2232-f84f-0622-833c9793fee3@quicinc.com>
Date:   Thu, 30 Jun 2022 20:34:36 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [Freedreno] [PATCH v3 3/4] drm/msm/a6xx: Add speedbin support for
 A619 GPU
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@somainline.org>,
        <~postmarketos/upstreaming@lists.sr.ht>
CC:     <freedreno@lists.freedesktop.org>,
        Jonathan Marek <jonathan@marek.ca>,
        David Airlie <airlied@linux.ie>,
        <linux-arm-msm@vger.kernel.org>,
        "Abhinav Kumar" <quic_abhinavk@quicinc.com>,
        <jamipkettunen@somainline.org>,
        "Jordan Crouse" <jordan@cosmicpenguin.net>,
        Rob Clark <robdclark@gmail.com>, <martin.botka@somainline.org>,
        <dri-devel@lists.freedesktop.org>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <angelogioacchino.delregno@somainline.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        <marijn.suijten@somainline.org>, Sean Paul <sean@poorly.run>,
        <linux-kernel@vger.kernel.org>
References: <20220528160353.157870-1-konrad.dybcio@somainline.org>
 <20220528160353.157870-3-konrad.dybcio@somainline.org>
From:   Akhil P Oommen <quic_akhilpo@quicinc.com>
In-Reply-To: <20220528160353.157870-3-konrad.dybcio@somainline.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/28/2022 9:33 PM, Konrad Dybcio wrote:
> There are various SKUs of A619, ranging from 565 MHz to 850 MHz, depending
> on the bin. Add support for distinguishing them, so that proper frequency
> ranges can be applied, depending on the HW.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
>   drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index 331cd2f6b9e3..a2a30a9ab677 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -1836,6 +1836,22 @@ static u32 a618_get_speed_bin(u32 fuse)
>   	return UINT_MAX;
>   }
>   
> +static u32 a619_get_speed_bin(u32 fuse)
> +{
> +	if (fuse == 0)
> +		return 0;
> +	else if (fuse == 120)
> +		return 4;
> +	else if (fuse == 138)
> +		return 3;
> +	else if (fuse == 169)
> +		return 2;
> +	else if (fuse == 180)
> +		return 1;
> +
> +	return UINT_MAX;
> +}
> +
>   static u32 adreno_7c3_get_speed_bin(u32 fuse)
>   {
>   	if (fuse == 0)
> @@ -1855,6 +1871,9 @@ static u32 fuse_to_supp_hw(struct device *dev, struct adreno_rev rev, u32 fuse)
>   	if (adreno_cmp_rev(ADRENO_REV(6, 1, 8, ANY_ID), rev))
>   		val = a618_get_speed_bin(fuse);
>   
> +	if (adreno_cmp_rev(ADRENO_REV(6, 1, 9, ANY_ID), rev))
> +		val = a619_get_speed_bin(fuse);
> +
>   	if (adreno_cmp_rev(ADRENO_REV(6, 3, 5, ANY_ID), rev))
>   		val = adreno_7c3_get_speed_bin(fuse);
>   

Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>


-Akhil