Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v2 31/35] [RFT] net: dpaa: Convert to phylink
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        linux-arm-kernel@lists.infradead.org,
        Eric Dumazet <edumazet@google.com>,
        linux-kernel@vger.kernel.org
References: <20220628221404.1444200-1-sean.anderson@seco.com>
 <20220628221404.1444200-32-sean.anderson@seco.com>
 <YrxlS7wvgUtg9+y0@shell.armlinux.org.uk>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <c219be52-a847-6f9a-5c1e-e46f1578eccd@seco.com>
Date:   Thu, 30 Jun 2022 11:56:27 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YrxlS7wvgUtg9+y0@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzFkNHE1cm5NWFRNQ09oRFB5dzk4bXN1Si9CdmgyTjlQTDV0d0wxRmRQemt5?=
 =?utf-8?B?SVlaSWgxeXRIS012YSs2L21lUjF5SjFPRHZXek00K3RGaktySXR0RUNyNGJ0?=
 =?utf-8?B?UkdyUnR2MGovaVlWSVNCNWo1K2wwQklMdTNMRjM1L1FaUnFGbDI0d1Z4QkJo?=
 =?utf-8?B?MlgxYjVJRmZ1VEE0WFM1dG1mVmE3M3VNeDJhNVNyTlBncnBCdnZzeFRXcVJX?=
 =?utf-8?B?WE1rbU1FcVowc25KMmtJL3JZM1VUT3UyMXJVYXBydnlXYTZoZjNhOGVCZitW?=
 =?utf-8?B?VlJZSHB3VVlRQzNBZjRuYzQvKzZxdWJzeldPcVl5TndUOTcybnRpSjVMVDZY?=
 =?utf-8?B?emc0ZDI5QnhQK25IVFFXVVFNRmRTVm9OS2VETG1HQ05NOUNNVlVCWFBoenJJ?=
 =?utf-8?B?VDJpaHppUXhVUE1QcmJWbG9nQnc1SDZ6NzdPcGRlTWtIbnhVUW0xUFBzcStv?=
 =?utf-8?B?V01nZlhRV3VYNDNyYUJJREZsYVJ4a1ZEZUpFc0I3VHlZVTZ3R1l1N0Z1WFNL?=
 =?utf-8?B?QnhDTjhiOFp5U0NNWTg5d0I4eEhHSlo0aU9LbnNhbmlBVC9CUzBvRTFFYjBD?=
 =?utf-8?B?ZXQzNlF2cGlTeWhweEo0YmN2UnU1U21na216MjV0aVc5ZXB3c1NqYkJlRGdu?=
 =?utf-8?B?WjRqRU9wV0E4TWhvSG5Hd3ZkMlNxNGJqMXZPZVRKeTVDeHJQS3pNMW1BclNP?=
 =?utf-8?B?elpVRkhQQVBTbXRtL0w1N0tvWTdqZkhTTWVUbHlod1NSRkpVSDNzRW95cEQz?=
 =?utf-8?B?V0pvWmVHeXpiUkt6bW0wc0FpYmhhMGx5d1F2TnpobnZleUdMUENXUFI2K0JZ?=
 =?utf-8?B?WUQ0bFNFTTVWOExxUnRLeGNVa3hhc0dYUEg5UnhZOTRYTmdzR0hVZVROM3Y3?=
 =?utf-8?B?Tkt1aUdRQzN4WmlzckZPMTIxMDIwSFZLeU5rY2xlMmxoTThpQ255ZnQ2Syts?=
 =?utf-8?B?T2lPK1FyQ0J0cVpGeEE5REhBbzV3VHdzU3BvUmxTSDRtNkh5aVlnYjFHbm1y?=
 =?utf-8?B?eHNMaDF6cm9WbCsxNjd4QVcxODYyN21iSVdMc3ROMzFGaVNIR1Q5bjJiVUxn?=
 =?utf-8?B?UWhVRzB4YkVIL1FIL01Sc1BMd2h2YXFvWGxPZDJ3YUpHZGNVbWVxS1RoRmRq?=
 =?utf-8?B?ZTl0MG81WUhONnoweUJJaXdSK0NNZE1OWkJ4VWgrbkNOQ0RvK1VlbEo1Mkdw?=
 =?utf-8?B?MkMzSjU2ZmlnMG54b2k4b01Tbis4aklKeWxjaTRJRGtyZTVvNWkxRGRiSkJG?=
 =?utf-8?B?Q1I5VXMydXRkdFQxMDM3MHp1Smd5UndmbDlwMjM5ZSt1MzUxMUxOYUowdGp3?=
 =?utf-8?B?OXo4OGJBc1AweWUxRllFdHcxeGN1ellwZW42K3B2YVM0Q2Y0enNibGpQc0E5?=
 =?utf-8?B?S3RhZUYycmRqRWRmSnBwVHdaSG9KTm1QaG1oTHBlSU51ZS83UlBGYlBGb010?=
 =?utf-8?B?K0N1b25XSWdPVjhEa284T0lhbmhNd2ZkL3dEQ3A5RjMrbGRVT1dNclNwWlZM?=
 =?utf-8?B?MnQ2YitDZGZpekNGK2puNXl3alNSTzJOL3QwNmhDOTZRaHFCVFlHVzhZMU5k?=
 =?utf-8?B?SnBpbGwxRml4ZWU5MHFYenJpZ21ORW8wVEZTdElJK0YzN1NkZnM3QXBhdU90?=
 =?utf-8?B?NXU1Mzc5RGxZWENBNFRDdCt6dmpmYzRieFVvelJYbytLNzNxbG5tSGlLRkhF?=
 =?utf-8?B?NjFMbm9SM3pKWUdoTW55VitLTlFsaWVhTFMzdlU1TlExajJ0MTAyYVlTOGY3?=
 =?utf-8?B?Yld6VVNMRG1kVVBiY2k3aXY0czFsTWJKZllOOERZZE5SR3d4ajNybnFYeWVP?=
 =?utf-8?B?bTQxNnRoRnhaSU80QXZMaUMyQ2lkcjgxcHROa3RMUkR6a0JPOHBJTzR0OEpX?=
 =?utf-8?B?a1RrdkJUcXVLR28rNitVREpXdDBiY2wrbXgzbDE2RElmZlR4OXBLcGpDakNO?=
 =?utf-8?B?WVEzQitUWldQTXZVa2ZrY1RyUmlFMXVxRHY5N0ZVNFBFcE54R1pOZUY2MXhP?=
 =?utf-8?B?aFc4enhPTXhkajNidFdrN05VU3FBYVQ0THg3NEJaaFc0dDhFQzNkYXQ0NzBh?=
 =?utf-8?B?UGdMcjdCS2s1NDF3a3ZEbXIzSVY5NHV0ZVJuVUpLR2NLOEduaGRQWEVNeXVB?=
 =?utf-8?B?YnVxY0JMTzYyd1JYbEZZWG04M3ZYUjNUKy9ibUE1R0VlM2R5UEFVSUxJamVt?=
 =?utf-8?B?a0E9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c6a5a43-e86d-4075-3709-08da5ab11a96
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB4973.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 15:56:32.9047
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wC8INIAsIyAZwhWEAxjfZ38MgAWSZt/J5pyQzL2ZAYE0mww+diSayMO4VKuPCKrrsKq9R2VlEu9GLf43ke3mxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5861
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Russell,

On 6/29/22 10:44 AM, Russell King (Oracle) wrote:
> On Tue, Jun 28, 2022 at 06:14:00PM -0400, Sean Anderson wrote:
>> +static void dtsec_mac_config(struct phylink_config *config, unsigned int mode,
>> +			     const struct phylink_link_state *state)
>> +{
>> +	struct mac_device *mac_dev = fman_config_to_mac(config);
>> +	struct dtsec_regs __iomem *regs = mac_dev->fman_mac->regs;
>> +	u32 tmp;
>> +
>> +	switch (state->interface) {
>> +	case PHY_INTERFACE_MODE_RMII:
>> +		tmp = DTSEC_ECNTRL_RMM;
>> +		break;
>> +	case PHY_INTERFACE_MODE_RGMII:
>> +	case PHY_INTERFACE_MODE_RGMII_ID:
>> +	case PHY_INTERFACE_MODE_RGMII_RXID:
>> +	case PHY_INTERFACE_MODE_RGMII_TXID:
>> +		tmp = DTSEC_ECNTRL_GMIIM | DTSEC_ECNTRL_RPM;
>> +		break;
>> +	case PHY_INTERFACE_MODE_SGMII:
>> +	case PHY_INTERFACE_MODE_1000BASEX:
>> +	case PHY_INTERFACE_MODE_2500BASEX:
>> +		tmp = DTSEC_ECNTRL_TBIM | DTSEC_ECNTRL_SGMIIM;
>> +		break;
>> +	default:
>> +		dev_warn(mac_dev->dev, "cannot configure dTSEC for %s\n",
>> +			 phy_modes(state->interface));
>> +	}
>> +
>> +	if (state->speed == SPEED_100)
>> +		tmp |= DTSEC_ECNTRL_R100M;
> 
> Please do not refer to state->speed here, it is meaningless. What are
> you trying to achieve here?

Well, it's part of ECNTRL, so I figured I might as well set it all at once.

> It looks like the old dtsec_adjust_link() used to set/clear this when
> the link comes up - so can it be moved to dtsec_link_up() ?

Sure.

---

I forgot to mention this in the commit description, but I touched on this
in our previous discussion: do you have a suggestion for the Aquantia stuff
in dpaa_phy_init? There's no direct access to the phy any more, so it's
harder to bodge it and say "we must enable flow control for this phy".

--Sean