Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fbaca135-891c-7ff3-d7ac-bd79609849f5@oracle.com>
Date:   Thu, 30 Jun 2022 11:40:30 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.0
Subject: Re: use-after-free in srpt_enable_tpg()
Content-Language: en-US
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <17649b9c-7e42-1625-8bc9-8ad333ab771c@fujitsu.com>
 <ed7e268e-94c5-38b1-286d-e2cb10412334@acm.org>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <ed7e268e-94c5-38b1-286d-e2cb10412334@acm.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U253dFJGRkJXMmFVcmxINHhJSHl5am9rNVkzbHpmSVdBUk4waUxxZXF0Ylhw?=
 =?utf-8?B?RWhRMlJpNTBTOWFLOERYdWR3ak5aRXpRM3FxQ2dtenk4dTlDRW9PM0xuQ0dK?=
 =?utf-8?B?S0pOLzExSGFzcWZ0amgxN25LampzUVFSbytGdEVqa1RXM0dHZWpaMkVzcUdl?=
 =?utf-8?B?M05IZDlDN09DVmMxZzJEVWRjR2ZNYmkyd2RuOHB2MnFuUGxzdk14bDU4MHhI?=
 =?utf-8?B?SVVxLzZkd0pqTVU2MFhYWTZwVlpuNlZhOHpjVlVSNmRSQUVEWEtTblRhcldZ?=
 =?utf-8?B?RVNxb0pFWXpQL2NwYlBWTW1DbGdGQ0xLczZzVDhqWXlGSXdFRm1IaXdqM0dN?=
 =?utf-8?B?LzJ5dWhoMS82S0I5eXRmNjUrS2lNYm5mbWsyamFURjJITTNZcEVHaDIwUFpF?=
 =?utf-8?B?SGdtVFVVNi9hNG5DN0QzMDBseVEvRnRIM3pGb1MxQTZiL3h6OGhwa2hWaEhq?=
 =?utf-8?B?YWVpbXJFWHRoV2RFd1JWSlJFY3d0YW13ZDZKNWprK3A3dGRhV0VFYitLYWV4?=
 =?utf-8?B?NW1Ob0YyYXhoOXFmdkUrcHBhaktPV1U0c010Vmk4MksyemFHZFRMSmhpVGFn?=
 =?utf-8?B?NDNKSGlIWEJhVjhnVHJLRHlEMGVzQUNkSUVHamdYMHBUeGpGcFFwQXFtWVpk?=
 =?utf-8?B?VDE2WkZvOVE2Z1dIU29ORnp1MjNIRXVYOG5WN3FqQkl5dkliTWhpVUROcjRC?=
 =?utf-8?B?R3FENm1GZlBPRlRpUWZPWkp5MXp4NHRLVEN2VXl1RlZnY3Q3YW1ZTFdMR3Nu?=
 =?utf-8?B?SU9DSE1wdnYrWU1WTHFRNlo2dExuWE5RTWMyblZ3dUdMU05vSGJPVEY1YXdE?=
 =?utf-8?B?anRSYkdzOWFEUGlSRk8ycjFkNmEyUDJWckVnblV2aGRrZzhNSGUybUwvTjly?=
 =?utf-8?B?OXRsOUxpOTE3LzJnVVRrQmN4MklJYjFWUXlNVkE0a2V2SnEvTFZ3ZTRabHMx?=
 =?utf-8?B?K2dKY3pqd3l3d0ZoZWpDc3g0NDRCUThzOEdURzJWdmFQcUQzZUh3L3QrL2hp?=
 =?utf-8?B?RDFzczdHQjBpWEF0cUFNZVZMM3hoU2tqdXVFUFVYdkxPZnN1Tk8xR1cwUUNU?=
 =?utf-8?B?TTNTV3IzeVRJeG1kVmVDR2R5QjFkcFhiREt3eTh3dUNnS1djVVF4NXFCSWdE?=
 =?utf-8?B?cHYyR3VQbUlFanRlUERHUUJQS1NhU1lneUlNTVNUaFRuZkNsajExcXJJVVA4?=
 =?utf-8?B?NmRRcnpwUG00SHNUNW9tWTFpQlZjSnlBNjY4WU1QU1NjMVloM2s3VDJ3TnNl?=
 =?utf-8?B?dzJVVmh0U2pyeGdTRExYeW1TTU5ybS81bzBQTkpMTlZVa0kxS3dDTVBRN3pT?=
 =?utf-8?B?Z1NTNUZLT05GRktiaFhkanpWL1M2NVZ3TEQraVJqd05naWJVV3p1OUJxZXZr?=
 =?utf-8?B?WDZXNVllTlhTTXpsUG9oS0djdkZPZ1E2ODBPbE1FZU5WMWlSK2Y3cE5aNDM3?=
 =?utf-8?B?b1BYQ2ZnWGE1eVB2WDE4eEVILzdZS1ZXb21iY3EzS0VRcFdKWE1nWjc0VWpn?=
 =?utf-8?B?c1FBMzVlWWdnS3VweFlRK3NiQ1RDeXloaWJwUEhpUCtraWJMRGNnM0ZIUFJt?=
 =?utf-8?B?djFWUEFHU1FzQlpVemJ2aVNzSG5Md1l3Nksyd09qMnVxbVRyV2NrM2RmZkNv?=
 =?utf-8?B?bGRra3NNU3V0V29sNWtkaWJVQ2R3K0N2VzdwME56a1B6VkRDUFhwTFZieVh0?=
 =?utf-8?B?bFZDZk5aUk9ZN3lTYUhldGM3ajRmYTUzZlVkOVRBcXZiTWZSWWhUd2lLK3hu?=
 =?utf-8?B?YWttRU8wMnBlMWJSSDNsNnVVSXNyODcrcVAwUEU3WWlyQlVpYUttcVBIQkMz?=
 =?utf-8?B?NW1DLy9PRktmTktwbUhjcm9pdnBWVitKa2lyMmpuNHRMMHVPOWFCV1NSSzhs?=
 =?utf-8?B?MDVyblhpMURROTUyb0ExRE1WL1VTazI0bEMvZEhNU1N4a2Zxdk9KcEZiQmMv?=
 =?utf-8?B?aVhlZVRaZkpkcG5kSjBUV3ZmSEI2Q0J5N1loZlNzSytnejBBQXMwSjU0OU9P?=
 =?utf-8?B?blE1TVFUQVVIRFdhWk94bnNSRC9yOGdkRXRBc296dEp1bTArQ2lmSFVLeit0?=
 =?utf-8?B?TFB1YlpXaDJMWGw5bFNiY3Z4MU9rM05wSVFyUGkzZTBUajNqNktHTEpjck5s?=
 =?utf-8?B?ajVpNmk0enFZZnlBOUh6ekNLNWFKNU5uK1Q5OW5rSGdrVXVBZWxJYVR3eUsy?=
 =?utf-8?B?Ymc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 782f2e6b-a3de-4c6b-b1a7-08da5ab73fd5
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 16:40:32.3924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E1PlBrrtaO0GQSCMtG4R5uvtLsQZZmP75yol1dJjHQECJ76a+HjEoUAecyfRhxjhHjiK9sfsnjkLgjg2vvD/AYlFqixIlKMI2yEJVS1Sp7Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3704
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-30_12:2022-06-28,2022-06-30 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=425 suspectscore=0
 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206300066
X-Proofpoint-ORIG-GUID: Q6X25LXANvqn4PXYcr0WiDSG92F8xcgc
X-Proofpoint-GUID: Q6X25LXANvqn4PXYcr0WiDSG92F8xcgc
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/27/22 11:37 AM, Bart Van Assche wrote:
> On 6/27/22 00:09, lizhijian@fujitsu.com wrote:
>> So far, I doubt if the previous defect of configfs mentioned in
>> 9b64f7d0b: "(RDMA/srpt: Postpone HCA removal until after configfs
>> directory removal)" has got a better solution. if not, i have no a
>> clear mechanism to avoid it yet.
>>
>> feedbacks are very welcome.
> Mike, are you perhaps aware of any plans to add functions to the LIO core for removing tpg and wwn objects?
> 

I don't know any work being done in this area. I was only working
on the refcounting/configfs parts for sessions in those configfs/sysfs
patchsets. However, I think I hit similar issues with the session.
I went around the world with solutions but didn't really like them
so I never pushed the patches for inclusion.

What was the hang caused by 9b64f7d0bb0a?