Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0183984a-c95f-c92e-629e-775071b5cd23@nvidia.com>
Date:   Thu, 30 Jun 2022 12:01:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE
Content-Language: en-US
To:     Peter Xu <peterx@redhat.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Linux MM Mailing List <linux-mm@kvack.org>,
        Sean Christopherson <seanjc@google.com>
References: <20220622213656.81546-1-peterx@redhat.com>
 <20220622213656.81546-2-peterx@redhat.com>
 <c196a140-6ee4-850c-004a-9c9d1ff1faa6@nvidia.com>
 <YrtXGf20oa5eYgIU@xz-m1.local>
 <16c181d3-09ef-ace4-c910-0a13fc245e48@nvidia.com>
 <YruBzuJf9s/Nmr6W@xz-m1.local>
 <177284f9-416d-c142-a826-e9a497751fca@nvidia.com>
 <Yrx0ETyb2kk4fO4M@xz-m1.local>
 <17f9eae0-01bb-4793-201e-16ee267c07f2@nvidia.com>
 <Yr2p7sR3IjiGTGd3@xz-m1.local>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <Yr2p7sR3IjiGTGd3@xz-m1.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHh2Z2RnZ0Njdnk0UnFqVWRFQlpjMUF0aiswVE1tVDBHUkI5cU9OeUVNQ2U3?=
 =?utf-8?B?MDRvcUdwV0QyVEE5MmZZTHQ1MGw4Q09STjkxZVZGcXNKT0NLdmxaV0VsWnBN?=
 =?utf-8?B?VHFlNlp3UnZScUUyLzMwM0NaLytjbWl4aEhSenlTUlpEeVRYN3hQZ1BoNFpT?=
 =?utf-8?B?THZjN0VxbFFqY2pDdTJUbEVybnVtSSs0bWFid01DQ3cwbHhCVHlSNWFTS3ds?=
 =?utf-8?B?R1ViYm8rM3RoTnFwaGowakJUbWN1dmQrdWE1Y3NjcW5UTUd2VnZBYXNKVVpl?=
 =?utf-8?B?U1NXVjVOdmNwQVJRY3BRSkpzS01Oc01PUWRZaVE5bTNEU2hVTjFnQnE2VElp?=
 =?utf-8?B?UE05K0RKQUk2QkFFbWpBN0NMWE5JditLTjRja1hZTkkySVBidkFsRWpWaDh5?=
 =?utf-8?B?U2pvOWFMdzhCK2xmMkdFQW43N3Y4TTRab1lKOUpBNlV4N3A0MmhpMkxOelNJ?=
 =?utf-8?B?Y29QekFuZmVPY2Z3K0s1SUlJZ2QySGJ0VEQreXJsTmFtVXJycXRaWTJ6UzRD?=
 =?utf-8?B?bU1uNlhJeFpCcFlNMHlhZ3hPYWRvRGlLdXFZTm5HQndXMU4vMEhpZHhRWG0z?=
 =?utf-8?B?WEErRHd5M3pxeDFDUHBpVzVZTUgydDloMk5iajUzWXhGUlBQcitEOXVLTG1t?=
 =?utf-8?B?UVhmVERtL2s4N0J6M3pRYWdjRUNXZisrZ2dmUzRNdWhJbzlCY1hMMUQ2d0hX?=
 =?utf-8?B?NVFnQ1gyRWYwVHVFaGdMemJQU0tGd1VUeFpKcEtKZ2lINmdqUnlkcnlEOTFj?=
 =?utf-8?B?VGFrUE5RU1pabHp4czNhcHpZc1A4WDhTTVNyNTFuYVorWUt5dnFGeEY2ZzFi?=
 =?utf-8?B?SFkxeURNSHYvdEZRM2hGUlNkQU9va2F4a3lKWGJQdWFpWThWd01wWDNaYWRr?=
 =?utf-8?B?MGR3WDlzT29ZaE9ZOXdWR0NIaDhaT0NvYmY4Z0hBOWt3eFFOa1FTeGk3dWtZ?=
 =?utf-8?B?TU9IZVpReVNiSzBtS2N0b0VxdWNhYUd2NW9nSjRqUU1RZGt3YXk4SWdLY0pn?=
 =?utf-8?B?bDFMTXQ0cWVuR2x0L0xGOUtzaHY3clJBb01yRy9Bbm5TU0hhSzU3N3RIQ0Vk?=
 =?utf-8?B?R3M5Q0Y3MlExOWd4YndKaElUQi9uWVZ1SndjbzRGUVhIaDRzNmRjMXJKb2Nl?=
 =?utf-8?B?VitRSTlza05Mb1RZS0U0Zk1SVkJPMFRZbnpDUGlDY2cyMmJFQVdqZVJ0RDZP?=
 =?utf-8?B?NzRNbGd2a0Z0b0NFcngwM3VaekMxMUc2QVZtaERkNzhtczJZeUdidlEvMzBm?=
 =?utf-8?B?Z2IvZ0pNMlBIbVFaemp0bEcyclF3dTg1VlZ4NzQ4MUFlRTN5SFEyWEwra0dC?=
 =?utf-8?B?TzZyb3JxZVhpOFkrS0hSZldRK3J4bk1XWmRlaHl6WDdSU0pHbXR3STJzOG5V?=
 =?utf-8?B?YjcxWlRpWlYvS20reG5zU1VaV0xYSFhZdUdEejZpamVZMkxGY3JTdGc1L3Jn?=
 =?utf-8?B?WjFRZWFsc1FhUlZDZTkyRm5HbGswaUc3ZElCTHZ1NG02Rk50NnJ2N1g1NkIv?=
 =?utf-8?B?YXV0bWlvTDMxckZYeHhhNGRma2ZvRXg4d2Y3VzZEejc5eGhhZ2h3YnpzY1dS?=
 =?utf-8?B?L0RhS3RrTTBTc0tZa2R4MFlZSUxiQndSQ0t3NU1uMmZucFRZV1VCQnprQUo2?=
 =?utf-8?B?dm9XOHFwZ2RldFVKN09NMW0ra2hoK0xBUkNMWm1nWVpKd1ZTRkhQV0RuNDFi?=
 =?utf-8?B?ZjZNZWJZKzF0dmtpa2RLL3JmTnpCSW9IOTI5K1BpaVhpTUlpS2JrRDBsS3Uz?=
 =?utf-8?B?SlZqVmZLWW1aOWRrbEZXamNhMXFXbGl2dDdyZk5wZHBUa3FqaGpPRzExb1dW?=
 =?utf-8?B?QkV3bm91Y2xsTzhIOVZqcFdQdEtQbHZYdXM1OWVmS2w1dTMydkFkS0pveEVr?=
 =?utf-8?B?VU1zUmt4MmpiZ1ozOU1UT3B5MklQaG9kdGtla1lBL1BXdlJKOFZOblRhbDdJ?=
 =?utf-8?B?UEp0bzEzRXo2TURmMTVVdmw5VUM2UHprY1ljRG5QMFduZkVGejB4Z0NvNlZZ?=
 =?utf-8?B?L0tvQ3VUSGdRQWNRbG5oalBlNmtYU0R5U3ZUZUpPZld5dVRoZWdNVzRmbklR?=
 =?utf-8?B?UENCQURGTTVFa1cvZmJIaDVvUHRxOUpiRVR0RFkzSVJhZjFpczI3RkE4LytX?=
 =?utf-8?Q?GomH2GuK+6rgeEVOYxsL3ZGGw?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea10d29a-c539-43de-f89a-08da5acb0031
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 19:01:55.6043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: krVu5kwn0wlnZ7DSC+7RBtGnQ+ij7kaTfGxAPzgGyiM3mSVYkAbpbo9d7L0RuxQdYNJpNKIiQrM40bMHf0QBYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5088
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/30/22 06:49, Peter Xu wrote:
> Looks good to me, I'd tune a bit to make it less ambiguous on a few places:
> 
> 		/*
> 		 * FAULT_FLAG_INTERRUPTIBLE is opt-in. GUP callers must set
> 		 * FOLL_INTERRUPTIBLE to enable FAULT_FLAG_INTERRUPTIBLE.
> 		 * That's because some callers may not be prepared to
> 		 * handle early exits caused by non-fatal signals.
> 		 */
> 
> Would that be okay to you?
> 

Yes, looks good. With that change, please feel free to add:

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA