Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b84edc24-0a3a-a4d2-6481-fb3d4cee6dda@amd.com>
Date:   Thu, 30 Jun 2022 15:12:07 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v5] ACPI: skip IRQ1 override on 3 Ryzen 6000 laptops
Content-Language: en-US
To:     Chuanhong Guo <gch981213@gmail.com>, linux-acpi@vger.kernel.org
Cc:     stable@vger.kernel.org,
        Tighe Donnelly <tighe.donnelly@protonmail.com>,
        Kent Hou Man <knthmn0@gmail.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220630022317.15734-1-gch981213@gmail.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20220630022317.15734-1-gch981213@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3NGbGtlalNidm1nQ0JLeUc1NkZJRUVHUDRQUGsyU1pDOWlGY1IvVUVPQVNG?=
 =?utf-8?B?dGxSZ1IvbWEvRkxhd1UxRk1qRWNST0psVndreXM0WWoyd1JrM1U0b05reHBY?=
 =?utf-8?B?OEdoTXdJc1NtTllZWDl0WWJOeTBuazMvV0d0U2IzM2ZtR0oxWmc1cHhXT1NG?=
 =?utf-8?B?ZGJsSVFSRW03dDRycWFrbjY2dzVNN0Nmd3dweTdhZThWOUd5L0F3U1VvS0V1?=
 =?utf-8?B?bGMxbGN3WFFmWWhEWm9CY3g2SzV6U1psaUtJNFpLUy9uMGQvZEk2dmprV1d0?=
 =?utf-8?B?SGx4dktkM2hTbWRWZFAyY1FUM2FaSGFPa0Z3NXZLK0pUeWdTZTdVZTVZeS9R?=
 =?utf-8?B?QmIzNW9MK0lnQ0U1OW9qK0JOVXZybjYxT0FBYnFtZ3hFM1haN3FoMXltalVp?=
 =?utf-8?B?ZkFsWVJKM0huLzVPMGNKdlNPdTJGZllVaGlzRkxIOVFJa0lwdE4vSTlXR0p0?=
 =?utf-8?B?cVlWSW9wNkFnQUdtZXkyV2FaeDhzRnNtUWpjL25MOVBRN1FScnFxd1JRZ2tz?=
 =?utf-8?B?MHhISEo2OCthZmlSSUw3M3RMaDIyRzlJRGg5S0dMWnh2emlyakZwMlYyenhi?=
 =?utf-8?B?VXhSM1h5ZTVTVVZESlVXS0V6MVlQOGgvZ3Nzd3lRbjhEQWtPNlRkb0VGQkph?=
 =?utf-8?B?K1BEcEo5U2doVG9VTXV0QnZvWXJsRGE1NU81YUhCUFVTZVdTc3NJL2xySDBx?=
 =?utf-8?B?WXMrYnNUUTFCMU92YlQrczVWelFDVUl5UnFISUpuZHZSOGNMU0NyQTFUaDdM?=
 =?utf-8?B?amJLUkRFV0t2bHZKZWJMS3VPQ3JWcjJjcDg3Si9MMURwQXNUYzlPcjErT0RS?=
 =?utf-8?B?U3lQazJvb1JueFQ3NHE0aFRTemI5SVhaUVJIaUI5WnN2SjdNWVRkVlBTZ1Fl?=
 =?utf-8?B?U1VsZW40TGlnUFYyUjRrZkJubzlyZUZLUVNyT1drRjNsNXNlODNnRjlrWHVC?=
 =?utf-8?B?Z1puNXhLbk1RcmFNcVpZejU0SG1ZTmtteHA3NVZTWTluV0tyUHpoY0ltN2U1?=
 =?utf-8?B?NjdNUUF0RXJKZ2FXWHJpc1B1bE5pczRFdnpmK2svekJ5YWZra1ZXR3cxdS9V?=
 =?utf-8?B?Vk53NVV5T0hXZFJkazlMOEtXZjk0UDZOMXNlc1JnOG1tQ1JTM3Fjak9USU1K?=
 =?utf-8?B?a0l5MWhRSWl2Sk5rdE0xQlJzOFRvY0NOaEcxVkVFc2VhY1h5eFl6MHZvazVs?=
 =?utf-8?B?ZEYyOUZsclU5dDdBYkU2a293TzNFdXFmakZWSjRGczJqeHY1MGZWRVZjUHQr?=
 =?utf-8?B?NTRXS0UwOFRmMFJlRzVPMVJzaGxVQ0RRb0pPS29tZjZSWHNMU3NjOHFnZS9H?=
 =?utf-8?B?MjdoNHNFYU04S2FTbmg5QTUrSFU2bnF2TDJ0OHg0ZE5iOW9DcFE3a3h2cmhh?=
 =?utf-8?B?SUdWOGppNDRrZVhDaUMyVkFIdFZOaGc0YTNaTWR3VFIrUCttTWxEUTlwa3Nk?=
 =?utf-8?B?U2hwdDVNMjQ0L0p5U05CM0NJRDZydW0wMCtCcllDQ1dWL0ZUZ0Jwb0R1d2Zw?=
 =?utf-8?B?bUZNeHQzeTIzZDBmTEU5K0FINDJFMkJVdjA2aDBJUXFkb2xZc0xLWVZWUFZq?=
 =?utf-8?B?aGhLTlJKUWZaaWxoUzJ2M3h3UFNhUjhsUEEyMDYrc0lHQWgzNnFKNGhwUjNB?=
 =?utf-8?B?aWRORk1CMDBOZU9JaEovOENqTFlVWStWd1I3Qk05VEZXS3dyUFFieENsbHl6?=
 =?utf-8?B?V1BJU0cvNXdlSTlUcHZ2aTdZYjVxdlVWOVFQeitZVjJKZkpYaTFMWnN1ekxD?=
 =?utf-8?B?UHlSZjJkWEFTVGxkNXZCeEpBYmNrb1dSNVU1dWMxWnVqZmJQZHdKYzhBcXNU?=
 =?utf-8?B?eVkrRkUxcFBwNnE1ZWpUNUZyYkxPV2RRKzZKOEpqV2NGdlNYelpDcG1rbm9B?=
 =?utf-8?B?VHFRdmRodkZ1cGhjRzdWRGhNTk9lMlhXbzVCOWsvd1FQWVk3cVBEMVZReUVY?=
 =?utf-8?B?TEkzNXVMcTdXRFJWV0FKYXpsZTBjRGFmL3hGZEZYNmFYaG1peXp6WkFLSlFX?=
 =?utf-8?B?aGYySTVPZ1ZPM3loaGdodzZGNklPUWk1cS9MdTh2alhBYmpuQll3aWRJRjVv?=
 =?utf-8?B?bVMzb1hVaWVoWEFLY3pqOG95ZGhqTkRGcExSLzBydE5raTJ1dzZPbFl6cTAr?=
 =?utf-8?Q?D8XYCBz2F1gkuBiUiAgPoqQ8K?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91ecb7f9-fc40-406e-f386-08da5ad4cf87
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 20:12:08.8800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3s/s/xqTxgcpIhe8+hItZZ/AtwhduBs9AP4F289RRcCtnAvJlYdROYOwfiLyvNXj1R0p0vezw9YyFkjdmDdLZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6470
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/29/2022 21:23, Chuanhong Guo wrote:
> The IRQ1 of these laptops with Ryzen 6000 and Insyde UEFI are active
> low and defined in legacy format in ACPI DSDT. The kernel override
> makes the keyboard interrupt polarity inverted, resulting in
> non-functional keyboard.
> 
> Skip legacy IRQ override for:
> Lenovo ThinkBook 14G4+ ARA
> Redmi Book Pro 15 2022 Ryzen
> Asus Zenbook S 13 OLED UM5302

It's really unfortunate that these laptops have the bug.  This was found 
and fixed in the reference BIOS for Ryzen 6000 too (via an MADT override 
service) very early in development.  It seems these manufacturers didn't 
pick up (or ignored) the solution.

However I do want to point out that Windows doesn't care about legacy 
format or not.  This bug where keyboard doesn't work only popped up on 
Linux.

Given the number of systems with the bug is appearing to grow I wonder 
if the right answer is actually a new heuristic that doesn't apply the 
kernel override for polarity inversion anymore.  Maybe if the system is 
2022 or newer?  Or on the ACPI version?

> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Tighe Donnelly <tighe.donnelly@protonmail.com>
> Signed-off-by: Kent Hou Man <knthmn0@gmail.com>
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> ---
> Changes since v1:
>   Match DMI_PRODUCT_NAME for ThinkBook because the board name
>   is used for other completely different Lenovo laptops.
>   Add a patch for RedmiBook
> 
> Changes since v2:
>   Fix alphabetical order in skip_override_table
>   Add a patch for Asus Zenbook
> 
> Changes since v3:
>   Merge patches as requested
>   Fix another alphabetical ordering between two structs
> 
> Changes since v4:
>   rename the ident in RedmiBook entry.
>    There's also an Intel version of this series, so
>    rename it to make it specific.
>   reword commit title
> 
>   drivers/acpi/resource.c | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+) >
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index c2d494784425..0491da180fc5 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -381,6 +381,31 @@ unsigned int acpi_dev_get_irq_type(int triggering, int polarity)
>   }
>   EXPORT_SYMBOL_GPL(acpi_dev_get_irq_type);
>   
> +static const struct dmi_system_id irq1_edge_low_shared[] = {
> +	{
> +		.ident = "Asus Zenbook S 13 OLED UM5302",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_BOARD_NAME, "UM5302TA"),
> +		},
> +	},
> +	{
> +		.ident = "Lenovo ThinkBook 14 G4+ ARA",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
> +		},
> +	},
> +	{
> +		.ident = "Redmi Book Pro 15 2022 Ryzen",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "TIMI"),
> +			DMI_MATCH(DMI_BOARD_NAME, "TM2113"),
> +		},
> +	},
> +	{ }
> +};
> +
>   static const struct dmi_system_id medion_laptop[] = {
>   	{
>   		.ident = "MEDION P15651",
> @@ -408,6 +433,7 @@ struct irq_override_cmp {
>   };
>   
>   static const struct irq_override_cmp skip_override_table[] = {
> +	{ irq1_edge_low_shared, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1 },
>   	{ medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0 },
>   };
>