Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <584fc348-7a60-26a2-af61-9edc4f4830e4@amd.com>
Date:   Thu, 30 Jun 2022 17:01:01 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for
 PPC64 builds
Content-Language: en-US
To:     Guenter Roeck <linux@roeck-us.net>,
        Harry Wentland <harry.wentland@amd.com>
Cc:     Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Michael Ellerman <mpe@ellerman.id.au>,
        Daniel Axtens <dja@axtens.net>
References: <20220618232737.2036722-1-linux@roeck-us.net>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20220618232737.2036722-1-linux@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWVYc1Z6NVhobm1FR3F1bURZNFozV3l5QjdFZjJQS2l4RVpmMEtGTUFnTUVB?=
 =?utf-8?B?R2NaLzE0Yms0ZGtDYTZBUkRnQ1NiMjNZL0Qybi9XaE1aTklKUDNiWUJ1L0dr?=
 =?utf-8?B?aFNnVmpPR1lIdXRjQVFjVGIvYVZobnY1YnpHUUdIWitlNnNWeDVSaFJYSG5p?=
 =?utf-8?B?WHZGNi9tbHBsL0YwUkFzTkRrcjFoUHhuemt3S0liRGdPbjBLK0FTS1hrelJN?=
 =?utf-8?B?dENFUkdobTV1clFTbmxMTXkxUDBLUm1WMG5IQkdaQVVHSWM0M2ZmdEpFNmhu?=
 =?utf-8?B?UFNzd0gyQTNnWmZnU0VDQ1A0MDYxMEo1L3pwWVFCaVVPMmVwUUp2VE81WlJZ?=
 =?utf-8?B?bkpCS21ZUVJJS2k3a2xTWTYxRlhPV1ljK1UvcGtrVXBzMTNpNWttVFdZSFFk?=
 =?utf-8?B?VmRvMzdPcWs0MVBRTk5ETloxNzlOUG5OVVJOczh6U0lmT2hMMzg3ZGRLdElU?=
 =?utf-8?B?cWdMckVwZmVKQmZtcmVNMGphdllkMGJIYWUyMmVDaXRGN0d5b004aklhVEI0?=
 =?utf-8?B?VmhlUU9JeldObVdJNzV3c0lRMmJNZmxVNmhVUndVbnBwY1VCVS96RWtGV0dC?=
 =?utf-8?B?aUZJSHRaaGwzRGdRVmJkZkpyMDBPNlAvblptR0hVNC9UR2ZRNGNQaW9EZ2di?=
 =?utf-8?B?RERycklMdTE1d2FoZFp4ckFQKzNQaVg4di8zd0Flb01BOWFqaGFycGI0bTZa?=
 =?utf-8?B?djM1Q0pjbHQwalBJMUpZQVpXNjhtNXlHekZ5eHlpYllheGJtVkZVbHI4QWVy?=
 =?utf-8?B?NzF1RXF2YUtIOTNFVGd6UjVaOUplRDRiL0g3OXIvcmdoNG1QS1JWOXhDbjFz?=
 =?utf-8?B?NGxoOWpobWdNdU9vZWZIOXVpelI2UXZxMUZ3TkJyK2dJRy9ldGRIcnBYQXJW?=
 =?utf-8?B?a2VOYlhPdlNGd2M1aEZHdWlMTXZWN01rdThJYmtXdnBpb3loSXZxUlRYRDJo?=
 =?utf-8?B?RTJqaUtkREo3MG84d0gyNitZaHFESjFJd21lV2JPMm5leW1QUHRLMUhsSVEy?=
 =?utf-8?B?SHVOc0hTeDNRZStNLzlEeGJnUlNrTm5jbTYvcFJpZkJqNlZGOHhDaWxJb0E3?=
 =?utf-8?B?NkNWek41UW9aL0xabkRXNkNybDAwSHFZZTZqc0o3ZVQ5Vk9tNVRJSG1oRVln?=
 =?utf-8?B?S1VQUHdNU1cyQm5kMWcrSjRFcVpVUGtIVCs0VGpnTmxIaEtIY1FvTWc2aU5y?=
 =?utf-8?B?TWRlVG9zUFM1cGFlL25zdGQ0Q3B2NU10eGVKb1REKzFINzA1V0JNNURkWjRN?=
 =?utf-8?B?RURwZlIvSEJMc2toeDJ0N2d3bnRPc2tVM0lPL3VhTnk5Zk42OTZzakN4bkJY?=
 =?utf-8?B?a0I2LzNSNFQwV00rYkR2bVRWK3J1djdaSDBnaFM5dWJFc2VqbUhic0o4dU0x?=
 =?utf-8?B?amhUMkNYVHVRdXQ0NmpGeHppOC9VR0dNQnByK2RKWGEyQ0loQUx0VEN3a1Rk?=
 =?utf-8?B?YmNHQkdrdWV0ck5QWTJtQ040bFdWZGNnOUQrUHVCcmpNKy9xckJXMjF4SHps?=
 =?utf-8?B?UHlqcnIzOEYyTmExdm9hR0hMMFBHYWN2Wndna0Z5VnlmRUhQMTUwRU1mdHgw?=
 =?utf-8?B?V3N4Z2VhNW1JTnJSVi9qNlh5YTQxVWd5TGExeU9iK1o1allRZ1RYVDhOdVNP?=
 =?utf-8?B?MmZsM3ZZYXFOby9lWHAvdXhHTXZIcFZaTmlpeEVoMStvRXU4TjZHWWRaWXJr?=
 =?utf-8?B?ekhmcTIwK3FMYXZCREZmSkdnRmhseXdsdDE1cWYyN2poUU1TazFxN20zK0Iy?=
 =?utf-8?B?RnFLeVAyazNRbXlpWEVDakdYKzhRd0JQVWxlV282V1FaMFNtak56RzZqNzFR?=
 =?utf-8?B?Uno3UEhJZTJEaTd0K3lNNlZXeUZIa1F4S0lHUjEyVHg5VUplVm9FeXlORytw?=
 =?utf-8?B?Wk5LMHN2YTFvQUJObllaL0drbytnTjNYK2prOEw1VmFib2VlOEtQdzIzZmR4?=
 =?utf-8?B?RHl3ckxicnk1NW90K01wd1c4ZmEyb2lUWHMzQmRLQXIwRE9kRnZKQUhKOXQ1?=
 =?utf-8?B?QzFVVmhMaVg0ZVVZWGVMd3phYS9vNlQ4SGZ1MHduTGdMNTdYRGRoSTIvenp6?=
 =?utf-8?B?TE5jV1cxdW90WDY0aEhyWmcwWisveDlDbDcrbVV2SGNIT3Y0Vnl4MDNtTlpG?=
 =?utf-8?Q?e7vX4qftbxb8q7GJQ0WEOBIRp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88951fcf-81c5-4a7a-1333-08da5adba46c
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 21:01:03.0792
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y+te8ttIDozBVp5HZCHTD/suoeOq0Tv6C4AxEv2K1nDZ2j8lGo0cwB014W2lc9DVUsfg7eQfnkPXd/jjegA+xg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1513
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-06-18 19:27, Guenter Roeck wrote:
> ppc:allmodconfig builds fail with the following error.
> 
> powerpc64-linux-ld:
> 	drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o
> 		uses hard float,
> 	drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_resource.o
> 		uses soft float
> powerpc64-linux-ld:
> 	failed to merge target specific data of file
> 	drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_resource.o
> powerpc64-linux-ld:
> 	drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o
> 		uses hard float,
> 	drivers/gpu/drm/amd/amdgpu/../display/dc/dcn315/dcn315_resource.o
> 		uses soft float
> powerpc64-linux-ld:
> 	failed to merge target specific data of
> 	file drivers/gpu/drm/amd/amdgpu/../display/dc/dcn315/dcn315_resource.o
> powerpc64-linux-ld:
> 	drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o
> 		uses hard float,
> 	drivers/gpu/drm/amd/amdgpu/../display/dc/dcn316/dcn316_resource.o
> 		uses soft float
> powerpc64-linux-ld:
> 	failed to merge target specific data of file
> 	drivers/gpu/drm/amd/amdgpu/../display/dc/dcn316/dcn316_resource.o
> 
> The problem was introduced with commit 41b7a347bf14 ("powerpc: Book3S
> 64-bit outline-only KASAN support") which adds support for KASAN. This
> commit in turn enables DRM_AMD_DC_DCN because KCOV_INSTRUMENT_ALL and
> KCOV_ENABLE_COMPARISONS are no longer enabled. As result, new files are
> compiled which lack the selection of hard-float.
> 
> Fixes: 41b7a347bf14 ("powerpc: Book3S 64-bit outline-only KASAN support")
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Daniel Axtens <dja@axtens.net>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   drivers/gpu/drm/amd/display/dc/dcn31/Makefile  | 4 ++++
>   drivers/gpu/drm/amd/display/dc/dcn315/Makefile | 4 ++++
>   drivers/gpu/drm/amd/display/dc/dcn316/Makefile | 4 ++++
>   3 files changed, 12 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/Makefile b/drivers/gpu/drm/amd/display/dc/dcn31/Makefile
> index ec041e3cda30..74be02114ae4 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/Makefile
> @@ -15,6 +15,10 @@ DCN31 = dcn31_resource.o dcn31_hubbub.o dcn31_hwseq.o dcn31_init.o dcn31_hubp.o
>   	dcn31_apg.o dcn31_hpo_dp_stream_encoder.o dcn31_hpo_dp_link_encoder.o \
>   	dcn31_afmt.o dcn31_vpg.o
>   
> +ifdef CONFIG_PPC64
> +CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o := -mhard-float -maltivec
> +endif
> +
>   AMD_DAL_DCN31 = $(addprefix $(AMDDALPATH)/dc/dcn31/,$(DCN31))
>   
>   AMD_DISPLAY_FILES += $(AMD_DAL_DCN31)
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn315/Makefile b/drivers/gpu/drm/amd/display/dc/dcn315/Makefile
> index 59381d24800b..1395c1ced8c5 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn315/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dcn315/Makefile
> @@ -25,6 +25,10 @@
>   
>   DCN315 = dcn315_resource.o
>   
> +ifdef CONFIG_PPC64
> +CFLAGS_$(AMDDALPATH)/dc/dcn315/dcn315_resource.o := -mhard-float -maltivec
> +endif
> +
>   AMD_DAL_DCN315 = $(addprefix $(AMDDALPATH)/dc/dcn315/,$(DCN315))
>   
>   AMD_DISPLAY_FILES += $(AMD_DAL_DCN315)
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn316/Makefile b/drivers/gpu/drm/amd/display/dc/dcn316/Makefile
> index 819d44a9439b..c3d2dd78f1e2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn316/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dcn316/Makefile
> @@ -25,6 +25,10 @@
>   
>   DCN316 = dcn316_resource.o
>   
> +ifdef CONFIG_PPC64
> +CFLAGS_$(AMDDALPATH)/dc/dcn316/dcn316_resource.o := -mhard-float -maltivec
> +endif
> +
>   AMD_DAL_DCN316 = $(addprefix $(AMDDALPATH)/dc/dcn316/,$(DCN316))
>   
>   AMD_DISPLAY_FILES += $(AMD_DAL_DCN316)

Hi,

I don't want to re-introduce those FPU flags for DCN31/DCN314/DCN316 
since we fully isolate FPU operations for those ASICs inside the DML 
folder. Notice that we have the PPC64 in the DML Makefile:

https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/dc/dml/Makefile

Could you share what you see without your patch in the 
amd-staging-drm-next? Also:
* Are you using cross-compilation? If so, could you share your setup?
* Which GCC/Clang version are you using?

Thanks
Siqueira