Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932326AbXE1Vuj (ORCPT ); Mon, 28 May 2007 17:50:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752425AbXE1Vua (ORCPT ); Mon, 28 May 2007 17:50:30 -0400 Received: from mail.tmr.com ([64.65.253.246]:32823 "EHLO gaimboi.tmr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750963AbXE1Vu3 (ORCPT ); Mon, 28 May 2007 17:50:29 -0400 Message-ID: <465B4E96.30108@tmr.com> Date: Mon, 28 May 2007 17:50:14 -0400 From: Bill Davidsen User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061105 SeaMonkey/1.0.6 MIME-Version: 1.0 Newsgroups: gmane.linux.ide,gmane.linux.kernel To: Jeff Garzik CC: Gregor Jasny , Linux Kernel Mailing List , Linus Torvalds , linux-ide@vger.kernel.org, Alan Cox Subject: Re: Linux v2.6.22-rc3 References: <9d2cd630705270801m2826be60p3f802c502b26c531@mail.gmail.com> <46599E6B.1000209@pobox.com> In-Reply-To: <46599E6B.1000209@pobox.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1457 Lines: 31 Jeff Garzik wrote: > Several people have reported LITE-ON LTR-48246S detection failed > because SETXFER fails. It seems the device raises IRQ too early after > SETXFER. This is controller independent. The same problem has been > reported for different controllers. > > So, now we have pata_via where the controller raises IRQ before it's > ready after SETXFER and a device which does similar thing. This patch > makes libata always execute SETXFER via polling. As this only happens > during EH, performance impact is nil. Setting ATA_TFLAG_POLLING is > also moved from issue hot path to ata_dev_set_xfermode() - the only > place where SETXFER can be issued. > > Note that ATA_TFLAG_POLLING applies only to drivers which implement > SFF TF interface and use libata HSM. More advanced controllers ignore > the flag. This doesn't matter for this fix as SFF TF controllers are > the problematic ones. > Not only kills two birds with a single store, but will avoid having to re-solve the problem at sometime in the future. That's good software! -- Bill Davidsen "We have more to fear from the bungling of the incompetent than from the machinations of the wicked." - from Slashdot - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/