Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <528a5c36-d47d-e36a-f5f2-dda464eae982@oracle.com>
Date:   Thu, 30 Jun 2022 16:54:27 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2 2/9] mm/mshare: pre-populate msharefs with information
 file
Content-Language: en-US
To:     "Darrick J. Wong" <djwong@kernel.org>
Cc:     akpm@linux-foundation.org, willy@infradead.org,
        aneesh.kumar@linux.ibm.com, arnd@arndb.de, 21cnbao@gmail.com,
        corbet@lwn.net, dave.hansen@linux.intel.com, david@redhat.com,
        ebiederm@xmission.com, hagen@jauu.net, jack@suse.cz,
        keescook@chromium.org, kirill@shutemov.name, kucharsk@gmail.com,
        linkinjeon@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        longpeng2@huawei.com, luto@kernel.org, markhemm@googlemail.com,
        pcc@google.com, rppt@kernel.org, sieberf@amazon.com,
        sjpark@amazon.de, surenb@google.com, tst@schoebel-theuer.de,
        yzaikin@google.com
References: <cover.1656531090.git.khalid.aziz@oracle.com>
 <34e2eabbef5916c784dc16856ce25b3967f9b405.1656531090.git.khalid.aziz@oracle.com>
 <Yr4Xqe22CI/ff0ge@magnolia>
From:   Khalid Aziz <khalid.aziz@oracle.com>
In-Reply-To: <Yr4Xqe22CI/ff0ge@magnolia>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTBJWXo4dlozWnlweVFvUzZDcGlGdGNSMHFUMGg2UTh1MjVJSStySW9SaXdG?=
 =?utf-8?B?ZXlONDNFYTlPK1ZxZFg0ZDdCNFYvTFNzSmFkNWRJVkEwa3BhNCtUK1I2QlBs?=
 =?utf-8?B?SnUzRXpkaFVVWkhYVjkyMmQrL1ZoSnBaaUp3K2o2SS9tdU92MmlneG5qdmxq?=
 =?utf-8?B?MVVzYWsyUGd3VEhmSEM2ckJpMkpVKzdWN21yanRYWWViNldkUlh3eVdwQUh4?=
 =?utf-8?B?NDJkcW9Eb2prUHN4OW9yMUszZEx5c1dmKy9Fc1M0T3plc2hTRytuQkk3RjRp?=
 =?utf-8?B?MXZPMWNsdUFrbG9pLzRrdjhSWUpDWjVwMXdNUnpUWksraVAvQ0ZPRmh5YzVp?=
 =?utf-8?B?RjRpbG5jTFZadytIcWdwNmI2WDdUY1ZvUEFXWk9raVBwcS9rbklNeG1INGh6?=
 =?utf-8?B?bnNvdHZ0cDgzZElZTEdFS0RjOHZyL20xRTA3S1NicUp4KzBrK0lGQmxjbmxO?=
 =?utf-8?B?bnBBRnRNNHFZS3BybjVqaGROVFh1ZlJRb2RIc3J2TzFYWktYWm0vYm53aWJW?=
 =?utf-8?B?cjF4QkwzRVBOOTNvb2dSVm9zUGNUMUt4MHNUby9MTUxtcUdVaGlqMkpjNmRR?=
 =?utf-8?B?ZUxPMjMvbEo0UTEyNHhSMjV4TXllR1lZQWJSZ2hnVUE4eDRmY0k4b3ppNkpQ?=
 =?utf-8?B?RXNEMjBzRFhDbzNTNTF0S0xaaFViNzVtOHl2S3RaUzNJVVV5c1N3RXhNSHJG?=
 =?utf-8?B?c3V2Mi9WOExNazE2aVd6YjFXMnJsQ2NWWFZjNjV4M1R1ZjZOUXdlUzhERHpx?=
 =?utf-8?B?WkN0TklORlN0ekxNdmFqSFp2OUNxOG9EcDF6WjhnNkFhSnVZdUdaUHh3VTNR?=
 =?utf-8?B?RUJUcU54em9nWE02bWk0ODE5dHkrOG9paUhKYW5MRi9paWRXZnQrL05SWEZO?=
 =?utf-8?B?VUNiczhzTWt6MlpYdG0yOHNVTERpSVZ6d3BhUHAyaTAwM0VMWnBCOHA1Kyta?=
 =?utf-8?B?RTh3WmtMcHNZL1g0MEp6Y0hLMWZ0YWIyMDM2T0trOGtFTnN3QVJUWWMzQUgz?=
 =?utf-8?B?UUxKcnB3L0VzNkxJd3BBTFgxVmFOTnRSQ2NLeEZqUE9JQU9Dd1ZVdlFRM05r?=
 =?utf-8?B?cWNqOUpXS2djNjBDQ0lzOGhRVTRLZ2VHTm9naW8xVmRqdjRuSUtaQWc4OFBn?=
 =?utf-8?B?ZXVja2wrTFNiV2p2WC9FMWlEcFZwQzhQSXdFMkdYb1pSQUNEMXpscTdCZnJD?=
 =?utf-8?B?UW83aHRqcW9FdFZLOVBkOExkaVREQlpwcnFrYUI3S0RXejJhOXNORzFwWWtN?=
 =?utf-8?B?OFZSM2Zvdjh3Z01MdWdnTy9LbmZ5TXFuazRrbzJNbGdVMktxSjlkU2lvb1FR?=
 =?utf-8?B?T256WStvUmFPS1l1b0tJTDNTRHU1cCtScllIRTlLLzIrQjBxQjFVWTRsY292?=
 =?utf-8?B?T0dlMkw2aytlWGlJR2I0RkhLLy9UdzRWeWdHYzhma3NhVWJjbTBkaWVUR1po?=
 =?utf-8?B?WUNXdVlDQkZNZzJsMmFnMmxxMFpWVVhHRGJOZ3BOV0x3R0h0T0dZMXUzNEZk?=
 =?utf-8?B?a1R3UUw2UTUrKzlzdGR2WXQyTmNKK0E0VzI3NmdtQ1pYMjJjeWtsREROR3VT?=
 =?utf-8?B?eGo0MmQreFhVTjFwU2VKQzF4cThzOWhwelY3ZEM1aWxPYWVjWXhQTmY5V1NG?=
 =?utf-8?B?YWUyUzM4V1pudjNDRzBiSXlhaENRVDBVTW9UUXFlcmNOM0VTYzl3cHhjcjZi?=
 =?utf-8?B?ckl4czZkTC9LVTVqS2g2NXlzbnRYazJkVnZPNVJ5OGV5WjZ6MHFrdldjdTdv?=
 =?utf-8?B?dzZZeGs2eCtKSFZ2bTNiL3JqNUlheHA3V3ozUlZqYVdiR1NFZDF4YnBqNmFZ?=
 =?utf-8?B?UmJMQll3WkxkbXV3d1JVVEJUZGZOWGRVQmVRYXNtL1N6bnErK0FDcHd2RG01?=
 =?utf-8?B?NFB1d1d1VXljK2ZwUzRFZ0pmc05tUGJyRmRFL1hpQXVBRnlpdHlCaE5YTVh2?=
 =?utf-8?B?RUEwZWtkOFlRUzg0aHVVNlhOTm41dkhMS2doR1RxRm9ib0F2QnNmcmNxNU9y?=
 =?utf-8?B?SFJUaHF3MlUwaHF5NjE1VXg0UGozVG8xVit0QlFRWVBNUEoyRWpoaE40WmNr?=
 =?utf-8?B?Q0RiOHpFanl6RlB0a0VZeUZ3Z05GODR1V2ovbm9rM2hQYnB5bkh4RExwVmQ2?=
 =?utf-8?B?WHpqTEd4eG80Q0E4ZVlDUzk0aG1NTC8xRnVSMFJWTU1sNUVaWTFzWlI1UGYx?=
 =?utf-8?B?RlV3c0lNY0hLODhrRE13UWs5MFByZjZxY1d3QVErYjI3WnRvZElzbWZkNHFk?=
 =?utf-8?B?bUNVTm01RzIwTkRIc1IvNENRN3B3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53d904c9-3a78-443f-4759-08da5aeb7e7b
X-MS-Exchange-CrossTenant-AuthSource: BN8PR10MB3220.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 22:54:31.4200
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jijvP81MuG09+VbCLT0xZpfcfcTIbX4rXKy+FN2bdf3xX1akGke1a+bpg8u6p+HBJulb2Fs5EEJTvZi7l53IHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1594
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-30_14:2022-06-28,2022-06-30 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206300088
X-Proofpoint-ORIG-GUID: ORIPBe99zvzfjDOwyygxLAPwxfguexAF
X-Proofpoint-GUID: ORIPBe99zvzfjDOwyygxLAPwxfguexAF
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/30/22 15:37, Darrick J. Wong wrote:
> On Wed, Jun 29, 2022 at 04:53:53PM -0600, Khalid Aziz wrote:
>> Users of mshare feature to share page tables need to know the size
>> and alignment requirement for shared regions. Pre-populate msharefs
>> with a file, mshare_info, that provides this information.
>>
>> Signed-off-by: Khalid Aziz <khalid.aziz@oracle.com>
>> ---
>>   mm/mshare.c | 62 +++++++++++++++++++++++++++++++++++++++++------------
>>   1 file changed, 48 insertions(+), 14 deletions(-)
>>
>> diff --git a/mm/mshare.c b/mm/mshare.c
>> index c8fab3869bab..3e448e11c742 100644
>> --- a/mm/mshare.c
>> +++ b/mm/mshare.c
>> @@ -25,8 +25,8 @@
>>   static struct super_block *msharefs_sb;
>>   
>>   static const struct file_operations msharefs_file_operations = {
>> -	.open	= simple_open,
>> -	.llseek	= no_llseek,
>> +	.open		= simple_open,
>> +	.llseek		= no_llseek,
> 
> I feel like there's a lot of churn between the previous patch and this
> one that could have been in the previous patch.

I will look at what changes can be consolidated between two patches, including this change. Thanks for catching this.

> 
>>   };
>>   
>>   static int
>> @@ -42,23 +42,52 @@ msharefs_d_hash(const struct dentry *dentry, struct qstr *qstr)
>>   	return 0;
>>   }
>>   
>> +static void
>> +mshare_evict_inode(struct inode *inode)
>> +{
>> +	clear_inode(inode);
>> +}
>> +
>>   static const struct dentry_operations msharefs_d_ops = {
>>   	.d_hash = msharefs_d_hash,
>>   };
>>   
>> +static ssize_t
>> +mshare_info_read(struct file *file, char __user *buf, size_t nbytes,
>> +		loff_t *ppos)
>> +{
>> +	char s[80];
>> +
>> +	sprintf(s, "%ld", PGDIR_SIZE);
> 
> SO what is this "mshare_info" file supposed to reveal?  Hugepage size?
> I wonder why this isn't exported in struct mshare_info?

This file gives the alignment and size requirement for mshare regions which is the same for every mshare region. struct 
mshare_info is a per-mshare region structure that provides starting address and size for just that region.

--
Khalid

> 
>> +	return simple_read_from_buffer(buf, nbytes, ppos, s, strlen(s));
>> +}
>> +
>> +static const struct file_operations mshare_info_ops = {
>> +	.read   = mshare_info_read,
>> +	.llseek	= noop_llseek,
>> +};
>> +
>> +static const struct super_operations mshare_s_ops = {
>> +	.statfs	     = simple_statfs,
>> +	.evict_inode = mshare_evict_inode,
>> +};
>> +
>>   static int
>>   msharefs_fill_super(struct super_block *sb, struct fs_context *fc)
>>   {
>> -	static const struct tree_descr empty_descr = {""};
>> +	static const struct tree_descr mshare_files[] = {
>> +		[2] = { "mshare_info", &mshare_info_ops, 0444},
>> +		{""},
>> +	};
>>   	int err;
>>   
>> -	sb->s_d_op = &msharefs_d_ops;
>> -	err = simple_fill_super(sb, MSHARE_MAGIC, &empty_descr);
>> -	if (err)
>> -		return err;
>> -
>> -	msharefs_sb = sb;
>> -	return 0;
>> +	err = simple_fill_super(sb, MSHARE_MAGIC, mshare_files);
>> +	if (!err) {
>> +		msharefs_sb = sb;
>> +		sb->s_d_op = &msharefs_d_ops;
>> +		sb->s_op = &mshare_s_ops;
>> +	}
>> +	return err;
>>   }
>>   
>>   static int
>> @@ -84,20 +113,25 @@ static struct file_system_type mshare_fs = {
>>   	.kill_sb		= kill_litter_super,
>>   };
>>   
>> -static int
>> +static int __init
>>   mshare_init(void)
>>   {
>>   	int ret = 0;
>>   
>>   	ret = sysfs_create_mount_point(fs_kobj, "mshare");
>>   	if (ret)
>> -		return ret;
>> +		goto out;
>>   
>>   	ret = register_filesystem(&mshare_fs);
>> -	if (ret)
>> +	if (ret) {
>>   		sysfs_remove_mount_point(fs_kobj, "mshare");
>> +		goto out;
>> +	}
>> +
>> +	return 0;
>>   
>> +out:
>>   	return ret;
>>   }
>>   
>> -fs_initcall(mshare_init);
>> +core_initcall(mshare_init);
>> -- 
>> 2.32.0
>>