Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAODwPW9E8wWwxbYKyf4_-JFb4F-JSmLR3qOF_iudjX0f9ndF0A@mail.gmail.com>
 <CAODwPW8fiFSNehZbZDdR9kjHxohLGiyE7edU=Opy0xV_P8JbEQ@mail.gmail.com>
 <3bb0ffa0-8091-0848-66af-180a41a68bf7@linaro.org> <CAODwPW89xZQZiZdQNt6+CcRjz=nbEAAFH0h_dBFSE5v3aFU4rQ@mail.gmail.com>
 <8f51aed8-956b-ac09-3baf-2b4572db1352@linaro.org>
In-Reply-To: <8f51aed8-956b-ac09-3baf-2b4572db1352@linaro.org>
From:   Julius Werner <jwerner@chromium.org>
Date:   Thu, 30 Jun 2022 17:52:08 -0700
Message-ID: <CAODwPW9MvYJo8QbKOoVcUAKJ8Hxon2MCv_H5qpv=yaSTLLc+ug@mail.gmail.com>
Subject: Re: [RFC] Correct memory layout reporting for "jedec,lpddr2" and
 related bindings
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Julius Werner <jwerner@chromium.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Dmitry Osipenko <digetx@gmail.com>,
        Jian-Jia Su <jjsu@google.com>,
        Doug Anderson <dianders@chromium.org>,
        Rob Herring <robh+dt@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Nikola Milosavljevic <mnidza@outlook.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> How the asymmetric SDRAMs report density? This is a field with
> fixed/enum values, so does it mean two-rank-asymmetric module has two
> registers, one per each rank and choice of register depends on chip select?

Yes, each rank has a completely separate set of mode registers.

> Manufacturer ID is taken from compatible. LPDDR3 has it deprecated.

Oh! Oh no, I only just saw that. I wish you had CCed us on that patch. :/

That really doesn't work for our use case, we can't generate a
specific compatible string for each part number. This may work when
your board is only using a single memory part and you can hardcode
that in the DTB blob bundled with the kernel, but we are trying to do
runtime identification between dozens of different parts on our
boards. The whole point of us wanting to add these bindings is that we
want to have the firmware inject the raw values it can read from mode
registers into the device tree (with just the compatible string
"jedec,lpddr3"), so that we can then delegate the task of matching
those values to part numbers to a userspace process. We don't want to
hardcode long tables for ID-to-string matching that have to be updated
all the time in our constrained firmware space.

Can we please revert that deprecation and at least keep the property
around as optional?