Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1147246iog; Thu, 30 Jun 2022 18:33:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tXG/Osne4g/wWlfaxFlN5HmC/TIMxR1sPxVyNuH9CwwVJLoDcJqXsHxvmHQAMeQyXkAGuh X-Received: by 2002:a17:906:6a11:b0:726:97b8:51e9 with SMTP id qw17-20020a1709066a1100b0072697b851e9mr11848176ejc.115.1656639198559; Thu, 30 Jun 2022 18:33:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656639198; cv=none; d=google.com; s=arc-20160816; b=or3Ap9OtDXNTTYFncL0FVaasWNfpw0Nsoy2YJ12+cfjiRfCpYIGlIzbQZN8YxRg/R9 xHvh7pmTv/LRpkB8RZ0v0sECgLMlAMv5sSWxBWSBYvw3r2FFjX+8UtkYp7+Ooe/1dMEf KiqeUsQNj9oVFLi4+CXEvqwMWQI4I8h1J6RFvYCReOLf8HB9NMOKJ/TU7Pfyl4nzCtj6 XiR14kfT+sywnSAdGEl7+Ln/mc497RqBx50F2PQt3/F+iYv0Bghi/6p9fa5HJ2H7tql+ qAp9i7mLBtqn6zzFwIZG6jzMwbxpgtDM+JXGAIu9VVpm2c7xQmgv/bXLir1VarOjsvPg MYdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=ygHT2jAw914f43IVltgvjT9GLQcCfN55KKGJRNI/BxE=; b=ItDNr98K89aj/zWnYRCFmNLM9Rt/CD1IWBOaaMxRZyozoyvUhOIIgX9rYNqvrVDYDn Z7feEigNe00+anCwFhvZkk0O+QSeXJ4sCpgWGmW40FRKgsry5CBQnw0y7hCKZerbh0Do x21yKAVgWniWXWV8LN7mZ9ZuCPNO+RxTAmjChYWMEgY4Bn0DDU6EZeyrkGlImBtbXgc9 IhhykT2pYZWUCD8Y9r4QPEMEv55TMMz9ZRi4CapU4dGt+5Bo+PFH5VNfvZNIfTZlV+NY GF1OhhZppeh8fAhVnUammVNq313n6FPNS79kXB8b5BqtKiPEPWMCnp8bTKz846hAwS2L C96Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TCbSrA2C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hq33-20020a1709073f2100b00726b8501cd4si16602144ejc.91.2022.06.30.18.32.52; Thu, 30 Jun 2022 18:33:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TCbSrA2C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231640AbiGABJp (ORCPT + 99 others); Thu, 30 Jun 2022 21:09:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbiGABJo (ORCPT ); Thu, 30 Jun 2022 21:09:44 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0E1B599E7; Thu, 30 Jun 2022 18:09:43 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id o18so927497plg.2; Thu, 30 Jun 2022 18:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ygHT2jAw914f43IVltgvjT9GLQcCfN55KKGJRNI/BxE=; b=TCbSrA2CBbCo9r/tWWtCU9TspHb5SREc2B0ylUhPwlb2whHLQfZFQzJi65Z+vfWSbd uP2dWtdU3KgH+GVGXOSsufjmUvdD/CJNe+3EYzSboinSUektABBkXvJSdsCgGT20YU8+ /Ynz+i5I93xJUPaVJwlt0gN21yvCKCPf/rOr7C8TBfdxzRLoYG9ThANACmZ7cBNE9Wha OyJM9vDGT+FDZOcejtNfzZtlyEsfRsSdwNxn3gAwmGoM0YPxIc/eqkUhHyCZeaVJiZiz 8AKXVAsicGkNEF5XMjb8Lw81j9YpQH6mA/pQQQYurQ1VI+TfBB92M0uLtCvqQvybytzr hRag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=ygHT2jAw914f43IVltgvjT9GLQcCfN55KKGJRNI/BxE=; b=UezIONrFFpnsOxpr4v/t7/+QpmsBJw+Zj5TxhB1kHWITbowjQgRAHDrHFxuWYJ+Ft+ ZRFAC+HQNH5Ga0afyG724R+IDPbv7PFwmKdj56A5OxnEgjYFWjrlqItBACkhcidehGV/ ftDh0jsfg+vShf4HAZESW6gptTyXfVCaJjKsJ6PcHq4GW3nNvX2+hB3Kn9nsI/rIcfY4 UXNjnFt9bNyyPh752gVUTCUGk5/XH/fjuFCYVttgApVWyYL7UMSxtkqJmbVyJeZcYrKz FBqDI6rjmnVtw7qMP1kXyGNkynkBS7xGNhcMfQsrxhn59rnurK+hqfmQ1KuMTUpYoP3U YrEQ== X-Gm-Message-State: AJIora/UKchaifISSadQAflvRrUhYCvE9QwtECHuqZg4e4QdsTL4kYfZ WNDcVWE0+djDEyCyDlPxyKe97aKCF9ZQeA== X-Received: by 2002:a17:902:cec9:b0:16a:416c:3d27 with SMTP id d9-20020a170902cec900b0016a416c3d27mr18407818plg.107.1656637783113; Thu, 30 Jun 2022 18:09:43 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:4f4a]) by smtp.gmail.com with ESMTPSA id y17-20020a1709027c9100b0016648412514sm14107965pll.188.2022.06.30.18.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 18:09:42 -0700 (PDT) Sender: Tejun Heo Date: Fri, 1 Jul 2022 10:09:40 +0900 From: Tejun Heo To: Lin Feng Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup-v1: use find granularity format identifiers to make /proc/cgroups show pretty Message-ID: References: <20220630082539.83602-1-linf@wangsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630082539.83602-1-linf@wangsu.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2022 at 04:25:39PM +0800, Lin Feng wrote: > The listing subsys info is unaligned with the header columns and we can > make the output more intuitive to read by specifying "left alignment" > and "fixed length" format styles for seq_printf. This has been proposed before but the file is useful only in cgroup1 which is in maintenance mode and the format has been like that since forever. Given that there's some chance that it can break dumb parsers, the choice has been to leave it alone. It's such a dumb file format to begin with and just leaving it to wither and die seems to be the right direction. Thanks. -- tejun