Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1178511iog; Thu, 30 Jun 2022 19:26:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1twn5Q5vkS+M9Awoq6nnx3WFV/RmAhZWKQ69xnZ3sHYxgyvLbPmF3/x5iCAj0dmc7v+jsr9 X-Received: by 2002:a17:90b:128f:b0:1ec:8aa9:586e with SMTP id fw15-20020a17090b128f00b001ec8aa9586emr13899390pjb.109.1656642406410; Thu, 30 Jun 2022 19:26:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656642406; cv=none; d=google.com; s=arc-20160816; b=k1OWOxQnWxBmdhvS3nHuVgJt9drVly/GfBgQw4jxdPUKxAOmH7KJSyLNBHsVkvJMuR 2MDUOyWRfhJ/5Xl3xlrPBLd3zMw18GvgIuGerEmOCDA4RGJsHellvekFreJHREc/vtDe NizGI9bOXLPPU/W3QjLPVOmYMoQUgiEECckretzvs8/S7SC39crXFD2luLVlpCAeftTU CDUBli+wESbYdRiro7juzrSeD4OeRtHq6O76dzZphUiggXP+4Ch07Cl1bhcHOHBmZciu 5kHTRu54lfUg8HJJlkYNwq72M6CfO+TwHNyNuAh/KLLXC2g6hEiF60mxewjMsJfiW2Qe QSKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=5hdOnEiAwGAddPiK1q8w4RE8DNCM6WiaxzTHUb4VXV4=; b=j2GEGnkxlbGn1hdi5gNW02zJ5YDB+tbPX99991R4CAQGAIgbP3boX8cXVMfhgZHuTB sjW67DyxlN7lIUVnW3O9o13F1ZCIt+VxvmEs4JB6fI7AhSYmMDNIYDzQuEDETk28+0q/ FeWwttEGwx9KnqbPNgf/L/NlwS8r+cngaxLkrKs79Iy/91kmdPM0dIFxhLRG/qR/4zwq hjKwJefNpPAId8pLtrGDKiwtvQ+qFhqh4vn2L7P0V8Y7zlgel0mhADlFMB1FTT65U82O 2/F1sEmAXdrS9ONd7nTFXfG6kYCYv8IJzHi0++CKhHaXPbH0be/3fXQ7cSXNhFZcSZ4R tkDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a63690a000000b00411acdb551asi341398pgc.46.2022.06.30.19.26.34; Thu, 30 Jun 2022 19:26:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232320AbiGACDX (ORCPT + 99 others); Thu, 30 Jun 2022 22:03:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbiGACDW (ORCPT ); Thu, 30 Jun 2022 22:03:22 -0400 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAD5F175A0; Thu, 30 Jun 2022 19:03:19 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=guangguan.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0VHvCiPi_1656640996; Received: from 30.43.104.202(mailfrom:guangguan.wang@linux.alibaba.com fp:SMTPD_---0VHvCiPi_1656640996) by smtp.aliyun-inc.com; Fri, 01 Jul 2022 10:03:17 +0800 Message-ID: <3e801eb5-6305-aa87-43a6-98f591d7d55c@linux.alibaba.com> Date: Fri, 1 Jul 2022 10:03:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH net-next v2] net/smc: align the connect behaviour with TCP Content-Language: en-US To: Wenjia Zhang Cc: davem@davemloft.net, Karsten Graul , liuyacan@corp.netease.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com References: <26d43c65-1f23-5b83-6377-3327854387c4@linux.ibm.com> <20220524125725.951315-1-liuyacan@corp.netease.com> <3bb9366d-f271-a603-a280-b70ae2d59c00@linux.ibm.com> <8a15e288-4534-501c-8b3d-c235ae93238f@linux.ibm.com> From: Guangguan Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/1 04:16, Wenjia Zhang wrote: > > > On 30.06.22 16:29, Guangguan Wang wrote: >> I'm so sorry I missed the last emails for this discussion. >> >> Yes, commit (86434744) is the trigger of the problem described in >> https://lore.kernel.org/linux-s390/45a19f8b-1b64-3459-c28c-aebab4fd8f1e@linux.alibaba.com/#t  . >> >> And I have tested just remove the following lines from smc_connection() can solve the above problem. >> if (smc->use_fallback) >>       goto out; >> >> I aggree that partly reverting the commit (86434744) is a better solution. >> >> Thanks, >> Guangguan Wang > Thank you for your effort! > Would you like to revert this patch? We'll revert the commit (86434744) partly. Did you mean revert commit (3aba1030)? Sorry, I think I led to a misunderstanding. I mean commit (86434744) is the trigger of the problem I replied in email https://lore.kernel.org/linux-s390/45a19f8b-1b64-3459-c28c-aebab4fd8f1e@linux.alibaba.com/#t, not the problem that commit (3aba1030) resolved for. So I think the final solution is to remove the following lines from smc_connection() based on the current code. if (smc->use_fallback) { sock->state = rc ? SS_CONNECTING : SS_CONNECTED; goto out; } Thanks, Guangguan Wang