Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1220114iog; Thu, 30 Jun 2022 20:40:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1swgpz3CYuK09lrJXyBjrk0inTvoYryDlqT1z85sDBtcyKAYJTmikKpEc8icX/zRMNd/Y2s X-Received: by 2002:a05:6402:d05:b0:425:b7ab:776e with SMTP id eb5-20020a0564020d0500b00425b7ab776emr16195668edb.142.1656646800612; Thu, 30 Jun 2022 20:40:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656646800; cv=none; d=google.com; s=arc-20160816; b=ptoJBlEQt+nAyVTwCKK9jwfv/3kZXS1AcIjJg7OBoFQuOu0L61N7jDDy+bYAiMaUgL mdm1GOMgiEyQ5Z4wJRKrk7AbAisVlOBk+aPXpFMDHYRdL9x+YZmRdXpCxDsfNOtZNSEQ QxP0SLUq+t+2iqQu2IVqYaywtdyXskSTb90SRAYvb1tv1ygqajDcfm5ViFn3vbzonASB OWRFbN448A14pey16ziKMkmTrvIjtPJyd41rpC1D147yodObpkW4e7obafpF2pVdArwn H43OyeV6rMQmATK9yfB0Z1o1dOct/N+me5BtTFT/laLXwlQIKt4LNf7xT0R3AoDtmXB3 RyEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=jCMsr3g6vbd5km2FikY7PRz2aHTNVB9T9iQXPSYKXOc=; b=JApF1ygoV4Vmr/I62F+edOil8bmNvbYfV5DbqsKU60ZdHQ5bXpUAcfzNMCRUHj/+0f cT7syl0OEw39AQhoKulejm9AvfhzdXvDTw8b1xKofjYZQEUuF7XogVKV+hJvBs6J8DYk stm7p3HpAfGSDqqFIElgcrZ3KE3mZqi2L5y9Bjn7OMqQLREOAsQ4oemtt4F+BKCulZph kEeQvYzfoz/i8Xo8EBU77faRFTl1tBF+mZqx3/6PeGYhSWGD0HNVB0PJ4rISk+zdY0Yf FOXKAc0HSWksfGijgKinqdAmeig3wKjVJI5TBubksPP1QVDNV6cGrLNnS355DWBSmZPo R6eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kgjbyh3i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b11-20020a056402084b00b004359f8055e3si16723176edz.4.2022.06.30.20.39.32; Thu, 30 Jun 2022 20:40:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kgjbyh3i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234017AbiGADT3 (ORCPT + 99 others); Thu, 30 Jun 2022 23:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233948AbiGADT2 (ORCPT ); Thu, 30 Jun 2022 23:19:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 903DA5924D; Thu, 30 Jun 2022 20:19:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2A3156226C; Fri, 1 Jul 2022 03:19:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 427FAC34115; Fri, 1 Jul 2022 03:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656645566; bh=Wu4LyrwBIXBMGUuBfkoa+RPX9Idpr9pjdu3wscaPnds=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kgjbyh3i2XIZ19rO5ftMUoo8DPoFt2NWUdxvGlsmAaXugcR3qu11845WpDRfFxu9N NphLmbEYKPN7RAhY4zdSxlrWPpItAeReSRkddycSl9vHE9EtfDKYv5c0yTVJLhkbVK dsYWwL70m1KFJ7QPGb/r2k3oy84quFaOd1k1DrM/KWc+lJU48K8LKIFj887vfRyAFS qtXE2AAh4HQIRBNCBTsQHbY59DOz+XeGRtyhxg7csjDm2NPO+P2G9n91vEBfEgRgvW iF3fnVkD/Qbz027/8x1d2B1pJdpaUK9Fj6yUiKBLhktrbQFV3RjQsSTbm3y7Axfpv9 mNV5SqCtiUSbw== Date: Thu, 30 Jun 2022 20:19:25 -0700 From: Jakub Kicinski To: Jianglei Nie Cc: irusskikh@marvell.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: atlantic: fix potential memory leak in aq_ndev_close() Message-ID: <20220630201925.4138ab9c@kernel.org> In-Reply-To: <20220629175645.2163510-1-niejianglei2021@163.com> References: <20220629175645.2163510-1-niejianglei2021@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jun 2022 01:56:45 +0800 Jianglei Nie wrote: > err = aq_nic_stop(aq_nic); > - if (err < 0) > - goto err_exit; > aq_nic_deinit(aq_nic, true); > > err_exit: label is now unused, please make sure you build test your changes with W=1