Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1221710iog; Thu, 30 Jun 2022 20:42:32 -0700 (PDT) X-Google-Smtp-Source: AGRyM1udlvbczZOd8fQX+zwPuygP0Zjt8uYmv/f0nSRdoCYF1bCAdEE/saX+zCAegaYqKObLPMfU X-Received: by 2002:a05:6402:5c8:b0:433:545f:a811 with SMTP id n8-20020a05640205c800b00433545fa811mr16118570edx.101.1656646952713; Thu, 30 Jun 2022 20:42:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656646952; cv=none; d=google.com; s=arc-20160816; b=akr6r/1ZOnfM41ULn7o1BLhlQmNdggIZpJeaM5+M6yA7W89J3rwjWolk03MO4G3sY0 LKaIvNga8O6MsoQOp9r1sqZ1Nr43IiT8AQ8OwI0fLlHxaTGeS69AqvOP2TegDwayxbQC SgBzlr+wTEtxeE/8bky1swfC2+TbyaugSkkTwUlMml1XNO0TWEYwRcQhYgtRqndIu+FT GQDA9j+HhSeuQhD2by51Rjy/WZxdl5vqMDNS5ltp07jDvtqtfZszJplq6UrMVFcnGYLY Lw1yes0ffWA6JX6VJQH9r+yUxtfIxYBuvUQ0AltXYosBsF3Z3T50eKDiHLPVs3ZFfWeJ rapw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=PGgwm8tF6Er4XvcaubNSeDGlcC3sySQ4+pqb5AHynn0=; b=WKspmideJml9us++dbKtVR1ocZ4TyO1yzvhYGykG5SK6mgoOMIaFmCXWjsvJgctC2W 3jDK1isST9Q1H4FmdVkYtle4pHVODJOLlTnFGhgPJMJKsSygxQ/zSzmf4v7tOQP+ROe7 xmgyAAKrdrdiCF9aLvTwviW0nfVPQJEBapJ6Zg2Zq8+3X4+gXzwE/tHG7MtxBXmZ2VGR Ev00wb8S/jBm/96FsqomfH/FDqXLB7PlBt1ajkf6yzvo50XdpujURIntFsoZNojKhK6d pxf9EUQZT/F9TFJsHvIHidcKBMvXDEhv8mT2vGwBhSeGkV1YpBNPSTbwZjgoiRh8B0bF 7FFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=IhmZEdkb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v23-20020aa7cd57000000b0042dec850ef4si511984edw.486.2022.06.30.20.42.02; Thu, 30 Jun 2022 20:42:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=IhmZEdkb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234063AbiGADjF (ORCPT + 99 others); Thu, 30 Jun 2022 23:39:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232859AbiGADjE (ORCPT ); Thu, 30 Jun 2022 23:39:04 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB47B61D72; Thu, 30 Jun 2022 20:39:01 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2613cNaE066029; Thu, 30 Jun 2022 22:38:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1656646703; bh=PGgwm8tF6Er4XvcaubNSeDGlcC3sySQ4+pqb5AHynn0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=IhmZEdkbPvgMFyYOVifB5W/q2788cxRd9E3Vfl59jk0JZn9Q62SEKZhDmkSIxn6gZ iU32rYeGVldEgFUaQtNjrwKAdwo07P0nAcG3ABURfS4rwHUYES6ETplYgWa+Ee03jw x9UnYi1wtfLW9ku+pXcCjLiAkgFHz8i1ubyqAOvc= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2613cNVL096920 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Jun 2022 22:38:23 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 30 Jun 2022 22:38:23 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 30 Jun 2022 22:38:23 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2613cNkl020254; Thu, 30 Jun 2022 22:38:23 -0500 Date: Thu, 30 Jun 2022 22:38:23 -0500 From: Nishanth Menon To: Javier Martinez Canillas , Nuno =?iso-8859-1?Q?S=E1?= , Christophe JAILLET , Alexandru Ardelean , Lars-Peter Clausen , Jonathan Cameron CC: , , Subject: Re: [PATCH] iio: adc: ti-adc128s052: Fix number of channels when device tree is used Message-ID: <20220701033823.gkp5hfowv7f3eemx@tinsel> References: <20220630230107.13438-1-nm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220630230107.13438-1-nm@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18:01-20220630, Nishanth Menon wrote: [...] > diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c > index 622fd384983c..21a7764cbb93 100644 > --- a/drivers/iio/adc/ti-adc128s052.c > +++ b/drivers/iio/adc/ti-adc128s052.c > @@ -181,13 +181,13 @@ static int adc128_probe(struct spi_device *spi) > } > > static const struct of_device_id adc128_of_match[] = { > - { .compatible = "ti,adc128s052", }, > - { .compatible = "ti,adc122s021", }, > - { .compatible = "ti,adc122s051", }, > - { .compatible = "ti,adc122s101", }, > - { .compatible = "ti,adc124s021", }, > - { .compatible = "ti,adc124s051", }, > - { .compatible = "ti,adc124s101", }, > + { .compatible = "ti,adc128s052", .data = 0}, I should probably cast these as .data = (void *)0 thoughts? [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D