Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1223089iog; Thu, 30 Jun 2022 20:45:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vrmTaLIuchdr6K9ANTp6njJqw+iy8He5z/RkTl0T6p/SgnLvTElhZXCAi5VscmMnEm12wI X-Received: by 2002:a17:906:6416:b0:722:e812:1000 with SMTP id d22-20020a170906641600b00722e8121000mr12720314ejm.275.1656647114045; Thu, 30 Jun 2022 20:45:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656647114; cv=none; d=google.com; s=arc-20160816; b=WdMHRdgX9K3jAGgFGat5H+8dLmKjyK+n2J3RKa8+8nyfYtGuqPUjVKcoav6tFRX6SE 9zuYGXBdGtAN7DokggCxRVfRjYvMjzs8Ag4zILyVEZcXUPwF4zLyXG0X2DpwaM7W2cMB /3ht40VYJzEs92b824n/tMMd5c9gH3X+ZSacWBapob6H62Ygv1tS3MD/F6fcoyx68beD xpELz/szoi1MZeCa8jfjylJiMC9oTFxTKM9jcOExDwoeeYxNN0vohnfsBfkGyEPoO/O7 aVbQqmzSsJTHGLtpWlFYw9AWgOVVSQYueRPSIqX+y33uGJR/PxSzmkA1RN46kDPPJ7Pz Ze8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=SNyMMml18XgTkCAqyjbnJ14CSdNDKRvne4D0Jx0VSE8=; b=Q8QbgflZ+KIlxNfClDJsYkcohdY7la7C0qfmqTHqIH7YpA5+EFvl2eYY3EmFIkoVgn MMhILkgG1exC+WIbxWYOBwp8SuyK814oZZdwKUiTrgG/AkiMe7QIcP/UcdFRjvWLVp9M skDJy/OY9Qsjcf8409bqetOl4pApC4zB2hYCBik7ymFFqwSPPjhNnjP0OS/s8uEvyPOu 2Z1MJGME/etxrV4zAl6VQgy2oABA+X9uHmVVLFlYYEH9G7Bc3xRMe0tMAVOybvGoTwyY y8OEPdGiKE/SJhkquaguIu/WGQk3QGZYob3bFGxxG7F4hkaA/9JKJMfNUCKxyeo5X71T tU/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a11-20020a05640213cb00b0042d85351337si6159072edx.120.2022.06.30.20.44.47; Thu, 30 Jun 2022 20:45:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234422AbiGADlP (ORCPT + 99 others); Thu, 30 Jun 2022 23:41:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234131AbiGADke (ORCPT ); Thu, 30 Jun 2022 23:40:34 -0400 Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37EF664D41; Thu, 30 Jun 2022 20:40:34 -0700 (PDT) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id D77C2201153; Fri, 1 Jul 2022 05:40:32 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id A03422035BC; Fri, 1 Jul 2022 05:40:32 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 065611802204; Fri, 1 Jul 2022 11:40:30 +0800 (+08) From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, festevam@gmail.com, francesco.dolcini@toradex.com Cc: hongxing.zhu@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: [PATCH v14 15/17] PCI: imx6: Disable clocks in reverse order of enable Date: Fri, 1 Jul 2022 11:25:33 +0800 Message-Id: <1656645935-1370-16-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1656645935-1370-1-git-send-email-hongxing.zhu@nxp.com> References: <1656645935-1370-1-git-send-email-hongxing.zhu@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas imx6_pcie_clk_enable() enables clocks in the order: pcie_phy pcie_bus pcie imx6_pcie_enable_ref_clk Change imx6_pcie_clk_disable() to disable them in the reverse order. Signed-off-by: Bjorn Helgaas Acked-by: Richard Zhu --- drivers/pci/controller/dwc/pci-imx6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 0b2a5256fb0d..79a05e190016 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -655,10 +655,10 @@ static int imx6_pcie_clk_enable(struct imx6_pcie *imx6_pcie) static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) { + imx6_pcie_disable_ref_clk(imx6_pcie); clk_disable_unprepare(imx6_pcie->pcie); - clk_disable_unprepare(imx6_pcie->pcie_phy); clk_disable_unprepare(imx6_pcie->pcie_bus); - imx6_pcie_disable_ref_clk(imx6_pcie); + clk_disable_unprepare(imx6_pcie->pcie_phy); } static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie) -- 2.25.1