Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bfcbbc3aff61f373a238c5ecb6a996eb963831d7.camel@nxp.com>
Subject: Re: [PATCH v2] drm/bridge: imx: i.MX8 bridge drivers should depend
 on ARCH_MXC
From:   Liu Ying <victor.liu@nxp.com>
To:     Neil Armstrong <narmstrong@baylibre.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Robert Foss <robert.foss@linaro.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Marek Vasut <marex@denx.de>
Cc:     dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Fri, 01 Jul 2022 15:09:19 +0800
In-Reply-To: <123b8767-7ea4-e6fe-6d47-0f2444a88dd9@baylibre.com>
References: <42c542b53a1c8027b23a045045fbb7b34479913d.1656072500.git.geert+renesas@glider.be>
         <b625ba83-fee9-b668-09db-976cb3bef3ca@baylibre.com>
         <9f5b511708ca9b30ef101a46a5d1b76f03b2c4fc.camel@nxp.com>
         <123b8767-7ea4-e6fe-6d47-0f2444a88dd9@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGt5bWhRWEVaNXhQOHZ4ejF1bjIwblJVTGJLU3Vac0hkYmpyZWd4Um1XYUdV?=
 =?utf-8?B?T3ptck9waW9lc0ZiSzZPUlo2dm11aWVJNFExRWtoQ3Fka2luUFAzQlBCNWNM?=
 =?utf-8?B?MjBPc2pUSEtkTXNVaHRraHFQSDRHN1kxN0NvTzJLMWVxV2dhb0UxWkMvcGIx?=
 =?utf-8?B?a2xjQzJ2U0pQajNzbXV1Y3ArT2EyQ2h0WDR0cXpLVzVxTm8vTTh1anR6aHNW?=
 =?utf-8?B?d0V4eW5zM0pFT212WFFET2ZHMXIveFJudjFFbzlhVDJmNjMzR3JWZlBRSHVZ?=
 =?utf-8?B?LzFkcVZVVVZ6ckhEUW4yeTljK3ZQbDIveFJHUGh5emVGQ3BzVStLNVFMTUlZ?=
 =?utf-8?B?RFRNcDYzOTZjZjJUamtEb3AybkdMeDZndk9oZk9jYjA2N0Jnc1ZZQnQ0QkFO?=
 =?utf-8?B?bUtScTI1L0pORWtQTW9CWFdQc0lmR2daOW5iaDNlWHE2S1p0L3dUeCtDVFc5?=
 =?utf-8?B?ZmN3S3VEUXErbmFaSWw5bnVUbWZmaWh0T0hZSUFqbE95bExxUzA2clNzTUVa?=
 =?utf-8?B?bjh3NHVaRlNEazk5d2Y0TEswT2Rjc1dvd0Q2RmZSb3NQTWo3eS9VY0YrenRn?=
 =?utf-8?B?SXB0YWtBcWJUQ2VPcU9aRjRmc3pKMjhJczhDQi9ienBxMW9ZMDlPZWxxNHhr?=
 =?utf-8?B?dUVMYVdDTXZESEZQU0lKVG9oVWFTRVUxVk9IR2VjcEcyNlNLeWhQYmg1bTBY?=
 =?utf-8?B?L3hBNGI0ZW84Y3dWemU4MzJoVElPMXZtQkRqL1U4ZlB6dU1jMzFVVVhDdFJk?=
 =?utf-8?B?SHd2VHZQelBmVEwvMUhmWFVBWEg1cDJTZjFaa3hNM3RXQnNKOXlwcXJDNEoz?=
 =?utf-8?B?T0NRaU9UTzA2NGpNemR5cTNwWTVqaXB1c2QrMjlyOE1qYVo1V3RaamxGUDFq?=
 =?utf-8?B?Kyt6aTlqb0srU1dSTDFMNVJ5Q25lYVFCZUhpKzJhOWpCK0sxdFNscUlWRmhr?=
 =?utf-8?B?UGpJS3czL1lyb01VZXFBSStwaTlydTg2UU9XazhSeUFld3FPRmpPUFlkVW5Q?=
 =?utf-8?B?bFl6NDFqc1lodE4yZHc3dWIzVHZQSCsyR09MSWlhamNzUjU1R3MzS1JmSWgr?=
 =?utf-8?B?SXhPNUNVeXB2VEVyMGF6cFJFcnMvdDZ6N204YjlXOW5NSFZTSkp1Wk1sb3ZH?=
 =?utf-8?B?ZWhSSFRBQVFDcnBRWGZkbG85Y2dSU0tOOWh0dndQMUlqdzByWkRMVU9jaWRS?=
 =?utf-8?B?WHZobnZPU1l5alV3Q3Y5aEZ6MnRoZ3FqQXoyTjdBZDVHV2tYMUhzMmZ5WDMx?=
 =?utf-8?B?aXNQMmdRd3B6NWNUMzV6MGN2VE13TUpVNDBDYjA5WkZySW1iaisySlFyRXRv?=
 =?utf-8?B?bHVaNEtackYvZHVjSDJ2YjRicCtLSENFTVRzbW1qQzY5NVI3RzBINzUveDZs?=
 =?utf-8?B?R2Y4SktKU2ZwQzlRaWNqZFQxbUdPUXZRM0ZodGRON2FQbmw3MmU4US9YcVp2?=
 =?utf-8?B?NSt0T1VLZVR5cURTWS83aC9BNmNHWTB6SE1md1dJMk1hK2pGNGFBWTRldy9X?=
 =?utf-8?B?Wjh2eHBwMlc1cDVNMklMUXo5VjEyZnN4d0xRejQ2UEJYN0RzbEpkWXJiNFBs?=
 =?utf-8?B?a0llK3pKZDJmWXAvR0pyUkZ5Vk4vSlpCaTI0YnE4bG9SNUJ6dkF0SDBKMUJ3?=
 =?utf-8?B?UEdTVmYvNUlCS1ptck93Zm5NSEFpWXJtMFRDeTZOcTJpY3lYT0E0S2Zia3ZX?=
 =?utf-8?B?KytKdzNyVnA0OUZxcFhEYjcyRWp4a0tiMnNoNjFSRVZDbmo4QVNNamFFbDlq?=
 =?utf-8?B?Z3llTytMS05Fdkh2MXQ4dkxuZnVxSlZEUWRuNXlFUG5uRWs0dXdWbld2US84?=
 =?utf-8?B?V2RERFJiWi81eldpYTBKdUpGamFIQjBKdzlNeWtkY0RuR0N6ZEtsbTU4amg2?=
 =?utf-8?B?a3ZZU0QrZ01zdVBueGhpSmlPTGJnVFJuMUh1K2FLVU00MmVSdVZaeWRLUU1z?=
 =?utf-8?B?UW8yZ0g0dmpFV1BrOERoNk1OZnRBd1VQNElRTkpnUGNBVnhKVE1ZM1ZhRFQ5?=
 =?utf-8?B?bU10TFZJcVZXMThsMFcwMkRSeVFqTjQ1UTNIdnYyYU5SaDhabWU2cGVwcXpk?=
 =?utf-8?B?eExOYWxvb1hFSXZuYjZXNC9OSXJaMU1UeG9tYlNRN2VBWVdDRVd4VmpkK2Q3?=
 =?utf-8?Q?BnZGVCyv4jDigXJza64vSm1N3?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4fc675f-5adc-4b24-ac64-08da5b30a564
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 07:09:32.0398
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qfCWRCUheRuB0gfRn+qNFAhqh6x/Tj6zWrAQRRxeOqSFMYElcvcM/BybkRkl2dutRktWnoR6WY/QSY5fhjNzuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6446
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Neil, Robert,

On Tue, 2022-06-28 at 09:10 +0200, Neil Armstrong wrote:
> On 28/06/2022 04:31, Liu Ying wrote:
> > On Mon, 2022-06-27 at 14:22 +0200, Neil Armstrong wrote:
> > > Hi,
> > 
> > Hi,
> > 
> > > 
> > > On 24/06/2022 14:10, Geert Uytterhoeven wrote:
> > > > The various Freescale i.MX8 display bridges are only present on
> > > > Freescale i.MX8 SoCs.  Hence add a dependency on ARCH_MXC, to
> > > > prevent
> > > > asking the user about these drivers when configuring a kernel
> > > > without
> > > > i.MX SoC support.
> > > > 
> > > > Fixes: e60c4354840b2fe8 ("drm/bridge: imx: Add LDB support for
> > > > i.MX8qm")
> > > > Fixes: 3818715f62b42b5c ("drm/bridge: imx: Add LDB support for
> > > > i.MX8qxp")
> > > > Fixes: 96988a526c97cfbe ("drm/bridge: imx: Add i.MX8qxp pixel
> > > > link
> > > > to DPI support")
> > > > Fixes: 1ec17c26bc06289d ("drm/bridge: imx: Add i.MX8qm/qxp
> > > > display
> > > > pixel link support")
> > > > Fixes: 93e163a9e0392aca ("drm/bridge: imx: Add i.MX8qm/qxp
> > > > pixel
> > > > combiner support")
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > Reviewed-by: Liu Ying <victor.liu@nxp.com>
> > > > ---
> > > > v2:
> > > >     - s/i.MX8MP/i.MX8/,
> > > >     - Add Reviewed-by.
> > > > ---
> > > >    drivers/gpu/drm/bridge/imx/Kconfig | 4 ++++
> > > >    1 file changed, 4 insertions(+)
> > > > 
> > > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig
> > > > b/drivers/gpu/drm/bridge/imx/Kconfig
> > > > index 212a7b0e64fd8b5a..608f47f41bcd1c81 100644
> > > > --- a/drivers/gpu/drm/bridge/imx/Kconfig
> > > > +++ b/drivers/gpu/drm/bridge/imx/Kconfig
> > > > @@ -1,3 +1,5 @@
> > > > +if ARCH_MXC || COMPILE_TEST
> > > > +
> > > >    config DRM_IMX8QM_LDB
> > > >    	tristate "Freescale i.MX8QM LVDS display bridge"
> > > >    	depends on OF
> > > > @@ -41,3 +43,5 @@ config DRM_IMX8QXP_PIXEL_LINK_TO_DPI
> > > >    	help
> > > >    	  Choose this to enable pixel link to display pixel
> > > > interface(PXL2DPI)
> > > >    	  found in Freescale i.MX8qxp processor.
> > > > +
> > > > +endif # ARCH_MXC || COMPILE_TEST
> > > 
> > > I was wondering why those were added in
> > > drivers/gpu/drm/bridge/imx
> > > since they are specific to NXP SoCs,
> > > I think they should be moved in the right drm imx subsystem
> > > instead
> > > of this change.
> > 
> > There are 2 directories which contain display controller drivers
> > for
> > i.MX SoCs:
> > a. drivers/gpu/drm/imx - i.MX51/53/6qdl IPUv3, i.MX8mq DCSS and
> >     i.MX8qm/qxp DPU([1], not landed yet)
> > b. drivers/gpu/drm/mxsfb - i.MX23/28/6sx/8mq LCDIF and i.MX8mp
> >     LCDIFv3([2], not landed yet)
> > 
> > Bridges added in drivers/gpu/drm/bridge/imx make it possible to
> > share
> > bridge drivers across display controllers.  I see chance to use the
> > LVDS Display Bridge(LDB) helper(imx-ldb-helper.c) for i.MX6sx LDB.
> 
> Thanks for the explanation, LGTM
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Care to pick this up?
I don't have permission to push this to drm-misc.

Regards,
Liu Ying