Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Jul 2022 10:26:25 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ricardo Ribalda <ribalda@chromium.org>
Cc:     kbuild@lists.01.org,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-kernel@vger.kernel.org, tfiga@chromium.org,
        senozhatsky@chromium.org, yunkec@google.com, lkp@intel.com,
        kbuild-all@lists.01.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v7 2/8] media: uvcvideo: Add support for per-device
 control mapping overrides
Message-ID: <20220701072625.GQ11460@kadam>
References: <20220617103645.71560-3-ribalda@chromium.org>
 <202206301144.r7yv0yk2-lkp@intel.com>
 <CANiDSCu1+0C7mfmm20ERVdvbzyJmoifnp6tcjEcd7EJfUAijSQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANiDSCu1+0C7mfmm20ERVdvbzyJmoifnp6tcjEcd7EJfUAijSQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xnXpWzGKORxTKriFf368p4Ey6v86nHbSLAmzOntNPzc/FXyjGyM6/v1nIqzX?=
 =?us-ascii?Q?hbcT8dlgQ9nbrYQZ8z6GTE1XiJDV8vUF2/bRQ3lbX8zCPnZzsWuS1gTkUNIc?=
 =?us-ascii?Q?pf9Jbz/EiYT1HOBJ9/mBg1flHZOxwqnm3XXCvHqpJuEvQZ46XcMHtYk4FulQ?=
 =?us-ascii?Q?juY/ov8ICScT249cGx1LRuyUAqVSmAzv1eHAyJbGpHrj2wOFxyo17QGMlQ/9?=
 =?us-ascii?Q?SaLbCj5Uz9LFnqNZHsOZW1wcya1TD10Ulj3rgcglPxbEMHmVZblSQWQi1Zbj?=
 =?us-ascii?Q?QDqYc8JHW4UCVcSHEbULdN/OIPnNlUj1JBtEtu95WNr6GN1JT7H61y4XDMC4?=
 =?us-ascii?Q?1/JoQU6ipwJqGXU57iRinOo+hLJjZH41ojYdKqmBl5m+vbHvjqeZpoE6MqoD?=
 =?us-ascii?Q?MTVXH77oam8RILlml5zsQ0k16scEs9dADmB1sOmJKlu3IfDqMoEh0bgScxAk?=
 =?us-ascii?Q?g1pCEQ+v1dz1hHKGXbhBnesGDFdiixEwubcJqo5jRuV+ND5RzyT2xIFjacP3?=
 =?us-ascii?Q?bgjixd4R4kr0mBPZHl9hYfL9IqPZr3HY32iT8n+sqkXMEF7Nj5l/EAXJF43u?=
 =?us-ascii?Q?hbtcrcX7GAnz/ei68jMJL/sLg4SWUpFrfCWauWFQv657DKaRJKxiZYUT5TXY?=
 =?us-ascii?Q?qgtGve5nbq05nZXrmsMI0mLersYRoQLDXMdSgECovO5kV9x4Gh+/rllvjriK?=
 =?us-ascii?Q?2eINpdoZxY5/VZYyDdwPrYLZbA87FS9uAtV3VfSxuc+9QwfzvSKFC69AtHrG?=
 =?us-ascii?Q?NYF4cGutVduazhhvQ5TnFoFHKulVpsjmK/xA9plnTc+K7Y6WhMLb6oPFNehz?=
 =?us-ascii?Q?Qnu5fL/k8oKUf1HUdGt+/btWxSNK7sMy+K4En6WGvNIwqOfv4LnKnIe71bbu?=
 =?us-ascii?Q?GApNFODPC5K4Gl+ZFxMYnyExhxscGUwKObBMSS6B4Fwh1GE4vVgIHPp4PEj4?=
 =?us-ascii?Q?UinbCTwBCoAZDpxEUeQEFrKwTb+UtYiNNoyrYNuHNNEgpXPnvjkFbVjtqNJq?=
 =?us-ascii?Q?pJg8HoE6i1Hd2RwuVArnS1cdVcblIjzDRAGBmNcXqUZULfO9Si8I4c9itKzj?=
 =?us-ascii?Q?tmqmEPaqzVy5tgqwWpxSlPJgCtbKy4vOl6if++5/CrfB+fSIa1QxYXLdww3K?=
 =?us-ascii?Q?hHj60akb33tlxcn+BEZg/uO/nO18lhgyeh4KRG+jXc1Zy62ajeiYTfGsF5ry?=
 =?us-ascii?Q?AdqKRjuo7/7hXGaYvjSy/6dW+XwychYsGAGtUpn0fnJEL1eZDV0iLcUkuL5X?=
 =?us-ascii?Q?f7Lw+oRyj5U07zkfVG76ENL99uLiMr1GI8c/AFWa1UxOX+OA17S6+dPzv4G8?=
 =?us-ascii?Q?MKPZPBB5dNW8qDoI9l4MEHRqELarPPUdjfdL0Dk5MXD/o1R+GEtDpl+P0MGL?=
 =?us-ascii?Q?pZfYHiBqT+xYmOogBPlFFTtFC8IWtTmsWhjksOfHqxrJf51zeVlaAtC15dD+?=
 =?us-ascii?Q?5b4nnwNBoiggtfybdVcUBHz3PrvbK2mju01hROanpMOj/KXj67auCNylTfI1?=
 =?us-ascii?Q?wXlI/monBnmcmQUB4kLeGLxOf5X6orIUwFBXgHCteZUA9ggrYGyS2Hh61++b?=
 =?us-ascii?Q?Hrt02dsKQ8hbOpvNB3UFJuk8Eek2EanVUcCcIlCokbI/gbdGkcJdRxlfbgEo?=
 =?us-ascii?Q?4w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d08bce0-b489-4d74-f331-08da5b33110a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 07:26:52.2017
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zmExewhtjyfciP6RGe+bbuWDbtgjAP/cGQJZ2K6Uq/UZ450VWOOd8TPs1lzk3NDG1jxSaT7HrIUOGCDP+GC1oAv4qDNAJ/dYNcCwvxeb8lI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3458
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-01_04:2022-06-28,2022-07-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=895 suspectscore=0
 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2207010025
X-Proofpoint-ORIG-GUID: yXNkXfnSRvH2mM1KcNaeXp2LpWDskif-
X-Proofpoint-GUID: yXNkXfnSRvH2mM1KcNaeXp2LpWDskif-
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 01, 2022 at 01:16:23AM +0200, Ricardo Ribalda wrote:
> >
> > "mapping" uninitialized if chain->dev->info->mappings is NULL.
> >
> > 10bdca4191d7a8 drivers/media/usb/uvc/uvc_ctrl.c   Ricardo Ribalda  2022-06-17  2457
> > 10bdca4191d7a8 drivers/media/usb/uvc/uvc_ctrl.c   Ricardo Ribalda  2022-06-17  2458     /* Process common mappings next. */
> > 10bdca4191d7a8 drivers/media/usb/uvc/uvc_ctrl.c   Ricardo Ribalda  2022-06-17 @2459     mend = mapping + ARRAY_SIZE(uvc_ctrl_mappings);
> >                                                                                                ^^^^^^^
> >
> > 10bdca4191d7a8 drivers/media/usb/uvc/uvc_ctrl.c   Ricardo Ribalda  2022-06-17  2460     for (mapping = uvc_ctrl_mappings; mapping < mend; ++mapping) {
> >
> > I'm surprised this made it through testing...  Anyway, the easier way to
> > to iterate through an array of structs is just say:
> 
> There is already a new version under review that fixes this:
> 
> https://patchwork.linuxtv.org/project/linux-media/patch/20220617235610.321917-3-ribalda@chromium.org/ 
> 
> 
> >
> >         for (i = 0; i < ARRAY_SIZE(uvc_ctrl_mappings); i++) {
> >                 mapping = &uvc_ctrl_mappings[i];
> >
> 
> I agree, and that is what I normally used, but that driver iterate this way...

That's not really an excuse.  Imagine you were a lemming and Disney
employees were trying to chase you off a cliff!

> 
> Thanks again!
> 
> PS: Any idea why the test was triggered 14+ days after the patch was sent?

I don't know how kbuild works.  I run Smatch on linux-next so I would
have caught it eventually.  Plus the clang people would have caught it.

regards,
dan carpenter