Received: by 2002:ac0:c50a:0:0:0:0:0 with SMTP id y10csp1025226imi; Fri, 1 Jul 2022 01:07:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1umijm275NSpE+JJytHwwBU3QE1Yr/HLHf/f3ZmxnMIEawyxfRrx65HNtysQyjqCJYnSmqv X-Received: by 2002:a62:29c2:0:b0:527:ab6a:c310 with SMTP id p185-20020a6229c2000000b00527ab6ac310mr19616161pfp.12.1656662849857; Fri, 01 Jul 2022 01:07:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656662849; cv=none; d=google.com; s=arc-20160816; b=dv31fnmJ9abtL9ysru98DQ3nii31sYcWTdJJJmQm6OmtiLeLSBwB5aw2/gdNbj3zwG 6pvRwi7uxysEHvGYCFzIbq+GS65Tqg36SKIdilPZHKoIG9ZXebEz1ULPindYvncSCON8 wu22hxHJwpMJgeabsT/zgnPLUzGBb6c4bjU2zfk54tdPI49wsSEgNtPMNSiTJvVTim1J 8tz8YE9ZhmnhfFuGoxY1AqoZS01Sdr10wigthCo6FyOusRWWpYDKc3Wj5+c5iafMOOt7 UrbgiJf9TAcl5c3uFyQ0HVqrwTg4RV3EnJxy+kJcOrRY0iLEgDP6flOjgXibSh57Ly5I 5iUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:abuse-reports-to:tuid:mime-version:message-id :date:subject:cc:to:from; bh=zUXSSqzS9XX06kaf/gv/RuGHLpGnAlpaVxPmO/r/wGI=; b=AFGhTEjOCzdmEXdwvYraj+3L62v9V8Jni9fzgp18bHfIMKprjsTwWvUSmQO2Lh96M5 oeXqObjpruFkh5G1IKFudM1kUYXkdAHZJdlYD39DrNmNpRStGJMy3SoSbIKiICJa+yIY Vl74iXOcHr7SIW7er8nXfw6W2kb3I9x+wgsKAQGVi6fX26bVU88SxIEi9BPI3aSthytP ZBOFwchXAFFP6fqguyKQ6xErMN66UhA4Hw9Ekw2NnM3wG+gXL376FukuXnnJ9WEcgB8h Lr6j2bk6XmI1IV/Ac/OAA8NXhrB+gf4++8C8LAlKOyN2T4XSNe/aUtrqL0mhTegRK/e8 /pNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o10-20020a056a001bca00b005254254cfd8si24695995pfw.12.2022.07.01.01.07.17; Fri, 01 Jul 2022 01:07:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235360AbiGAHiC (ORCPT + 99 others); Fri, 1 Jul 2022 03:38:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235222AbiGAHiA (ORCPT ); Fri, 1 Jul 2022 03:38:00 -0400 Received: from unicom145.biz-email.net (unicom145.biz-email.net [210.51.26.145]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 310536D576 for ; Fri, 1 Jul 2022 00:37:58 -0700 (PDT) Received: from ([60.208.111.195]) by unicom145.biz-email.net ((D)) with ASMTP (SSL) id VEM00054; Fri, 01 Jul 2022 15:37:54 +0800 Received: from localhost.localdomain (10.200.104.97) by jtjnmail201607.home.langchao.com (10.100.2.7) with Microsoft SMTP Server id 15.1.2507.9; Fri, 1 Jul 2022 15:37:53 +0800 From: Bo Liu To: , , CC: , , , Bo Liu Subject: [PATCH] iommu/amd: Handle return of iommu_device_sysfs_add Date: Fri, 1 Jul 2022 02:20:08 -0400 Message-ID: <20220701062008.6988-1-liubo03@inspur.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.200.104.97] tUid: 2022701153754142284bb54b59ca6fffe76b63419a9b2 X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As iommu_device_sysfs_add() can fail, we should check the return value. Signed-off-by: Bo Liu --- drivers/iommu/amd/init.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index 3c82d9c5f1c0..a3c4fdd40f04 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -2058,8 +2058,11 @@ static int __init iommu_init_pci(struct amd_iommu *iommu) amd_iommu_erratum_746_workaround(iommu); amd_iommu_ats_write_check_workaround(iommu); - iommu_device_sysfs_add(&iommu->iommu, &iommu->dev->dev, + ret = iommu_device_sysfs_add(&iommu->iommu, &iommu->dev->dev, amd_iommu_groups, "ivhd%d", iommu->index); + if (ret) + return ret; + iommu_device_register(&iommu->iommu, &amd_iommu_ops, NULL); return pci_enable_device(iommu->dev); -- 2.27.0