Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91e03ee2-a11c-7c71-73f6-d76e07c10cd0@microchip.com>
Date:   Fri, 1 Jul 2022 10:16:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] ARM: dts: lan966x: Add mcan1 node.
Content-Language: en-US
To:     Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>,
        <alexandre.belloni@bootlin.com>,
        <krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
        Claudiu Beznea <Claudiu.Beznea@microchip.com>
CC:     <arnd@arndb.de>, <soc@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <UNGLinuxDriver@microchip.com>
References: <20220627110552.26315-1-kavyasree.kotagiri@microchip.com>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
In-Reply-To: <20220627110552.26315-1-kavyasree.kotagiri@microchip.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/06/2022 at 13:05, Kavyasree Kotagiri wrote:
> Add the mcan1 node. By default, keep it disabled.
> 
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>

Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

We'll queue in the next dt branch soon, for integration through arm-soc 
tree.

Thanks, regards,
   Nicolas

> ---
>   arch/arm/boot/dts/lan966x.dtsi | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 3cb02fffe716..25cfa89dde7b 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -473,6 +473,21 @@
>   			status = "disabled";
>   		};
>   
> +		can1: can@e0820000 {
> +			compatible = "bosch,m_can";
> +			reg = <0xe0820000 0xfc>, <0x00100000 0x8000>;
> +			reg-names = "m_can", "message_ram";
> +			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "int0", "int1";
> +			clocks = <&clks GCK_ID_MCAN1>, <&clks GCK_ID_MCAN1>;
> +			clock-names = "hclk", "cclk";
> +			assigned-clocks = <&clks GCK_ID_MCAN1>;
> +			assigned-clock-rates = <40000000>;
> +			bosch,mram-cfg = <0x4000 0 0 64 0 0 32 32>;
> +			status = "disabled";
> +		};
> +
>   		reset: reset-controller@e200400c {
>   			compatible = "microchip,lan966x-switch-reset";
>   			reg = <0xe200400c 0x4>;


-- 
Nicolas Ferre