Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Jul 2022 09:07:52 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Arun.Ramadoss@microchip.com
Cc:     andrew@lunn.ch, linux-kernel@vger.kernel.org,
        UNGLinuxDriver@microchip.com, vivien.didelot@gmail.com,
        ast@kernel.org, bpf@vger.kernel.org, olteanv@gmail.com,
        devicetree@vger.kernel.org, robh+dt@kernel.org, andrii@kernel.org,
        songliubraving@fb.com, f.fainelli@gmail.com, daniel@iogearbox.net,
        john.fastabend@gmail.com, kuba@kernel.org, edumazet@google.com,
        pabeni@redhat.com, kpsingh@kernel.org, netdev@vger.kernel.org,
        Woojung.Huh@microchip.com, krzysztof.kozlowski+dt@linaro.org,
        yhs@fb.com, davem@davemloft.net, kafai@fb.com
Subject: Re: [Patch net-next v14 10/13] net: dsa: microchip: lan937x: add
 phylink_get_caps support
Message-ID: <Yr6rWE38HH3dSQHV@shell.armlinux.org.uk>
References: <20220630102041.25555-1-arun.ramadoss@microchip.com>
 <20220630102041.25555-11-arun.ramadoss@microchip.com>
 <Yr2KuQonUBo74As+@shell.armlinux.org.uk>
 <4cf0a3ba409dcb0768150c2a1a181753dddc595b.camel@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4cf0a3ba409dcb0768150c2a1a181753dddc595b.camel@microchip.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Fri, Jul 01, 2022 at 05:51:33AM +0000, Arun.Ramadoss@microchip.com wrote:
> > > +void lan937x_phylink_get_caps(struct ksz_device *dev, int port,
> > > +                           struct phylink_config *config)
> > > +{
> > > +     config->mac_capabilities = MAC_100FD;
> > > +
> > > +     if (dev->info->supports_rgmii[port]) {
> > > +             /* MII/RMII/RGMII ports */
> > > +             config->mac_capabilities |= MAC_ASYM_PAUSE |
> > > MAC_SYM_PAUSE |
> > > +                                         MAC_100HD | MAC_10 |
> > > MAC_1000FD;
> > 
> > And SGMII too? (Which seems to be a given because from your list in
> > the
> > series cover message, SGMII ports also support RGMII).
> 
> No, SGMII port does not support the RGMII. I have mentioned in the
> cover message that LAN9373 has 2 RGMII and 1 SGMII port. No other part
> number has SGMII port.

So when using SGMII, there's no way for pause frames to be supported?
It seems a bit weird that the pause frame capability is dependent on
the interface type, as pause frames are just the same as normal
ethernet frames, except they're ggenerally enerated and/or interpreted
by the MAC.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!