Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220630230107.13438-1-nm@ti.com> <20220701033823.gkp5hfowv7f3eemx@tinsel>
In-Reply-To: <20220701033823.gkp5hfowv7f3eemx@tinsel>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 1 Jul 2022 12:08:05 +0200
Message-ID: <CAHp75VfAMtb1jZHdLsb=TtajGC6WFZ0z-5k31Vy=cG7ytjByTg@mail.gmail.com>
Subject: Re: [PATCH] iio: adc: ti-adc128s052: Fix number of channels when
 device tree is used
To:     Nishanth Menon <nm@ti.com>
Cc:     Javier Martinez Canillas <javier@osg.samsung.com>,
        =?UTF-8?B?TnVubyBTw6E=?= <nuno.sa@analog.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Alexandru Ardelean <ardeleanalex@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Jonathan Cameron <jic23@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Stable <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 1, 2022 at 5:41 AM Nishanth Menon <nm@ti.com> wrote:
> On 18:01-20220630, Nishanth Menon wrote:

...

> >  static const struct of_device_id adc128_of_match[] = {
> > -     { .compatible = "ti,adc128s052", },
> > -     { .compatible = "ti,adc122s021", },
> > -     { .compatible = "ti,adc122s051", },
> > -     { .compatible = "ti,adc122s101", },
> > -     { .compatible = "ti,adc124s021", },
> > -     { .compatible = "ti,adc124s051", },
> > -     { .compatible = "ti,adc124s101", },
> > +     { .compatible = "ti,adc128s052", .data = 0},
>
> I should probably cast these as .data = (void *)0 thoughts?

The 0 is default. You shouldn't use that in the first place for
something meaningful rather than "no, we have no driver data for this
chip).

-- 
With Best Regards,
Andy Shevchenko