Received: by 2002:ac0:c50a:0:0:0:0:0 with SMTP id y10csp1171038imi; Fri, 1 Jul 2022 04:42:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t1vvG4h0FoN9uUc1q7vOktF0ytoi4Z+9EYKMzhWDkRNYh9EpyudqXT/Wq0ojy0RAy8PvxN X-Received: by 2002:a63:8ac3:0:b0:40d:5fd6:1ec0 with SMTP id y186-20020a638ac3000000b0040d5fd61ec0mr11877493pgd.624.1656675775556; Fri, 01 Jul 2022 04:42:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656675775; cv=none; d=google.com; s=arc-20160816; b=zUIWvkGlPoGVDmSwEwjJuT/hmsJWFs8BE4jYq/TC/0QuzeKE9dCmgvz8IT+Cj8vITE 8nvRhgnSp546nEmm+Ped1UsfGJwxTY04HKC306VmKiViClIsg9LC0GIyZuG+kiqvxqE/ oGu1dZdqIBI+SyVmN44C2/6fELHAKkWjuMzrFZ+qdGfJbBxp0OyfV9fVdO2LQOJxlOiM CucZmuwQrY70tASbs9j7OFo8PzFItrqMThMwXvednRImBXkg/uEKGl6Td28LSU1P0udJ zdbT5vxmGbGN+yx87/DiZwvM+okUs/yFr9mozja2JuVa+sRbUAn3zUF8PizgQtw4KrvU OwWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Lfukoe1qXfzQYNYDkT4KQdVH2B36dULHsrTKqWB3wHM=; b=mL7MPto5/ANnZ05gYidHk9qGFvGxHbXA3dvITaQc3wvPxHVP3GL5qNkgm9UsAa3eMt 8yqrvv12F9uKHFOjasNh2BHTWwMocVIBh6gp/nSQHqUeufhg3P5x0d6QwfjPLSWMGET6 0XU6tdXKA8pcdg3X/2QbxgDLc+A8TRQxcK1NJ1wHdc/OzME4h5k6Rj9uKkMhnIXIq49+ TRGXCDAuSQHPyPQtjOR5BnREV1bVrqtmTCROeS9fkCAqTyj9XrKcF0z0hV7zPpBT9LNF yxnVTfgekNw7MImfCwDlZLfjA5/f0QV8L3JTL0VQyvsQ1h8TwgA4v8c/V6vI1mTD7zC2 WzsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=skacddQv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 9-20020a630009000000b003fcc51079ebsi31860316pga.704.2022.07.01.04.42.44; Fri, 01 Jul 2022 04:42:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=skacddQv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbiGALEL (ORCPT + 99 others); Fri, 1 Jul 2022 07:04:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234650AbiGALEJ (ORCPT ); Fri, 1 Jul 2022 07:04:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C09C3AA51; Fri, 1 Jul 2022 04:04:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C2BBA6250D; Fri, 1 Jul 2022 11:04:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CF6DC3411E; Fri, 1 Jul 2022 11:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656673447; bh=+ABAnANVQ/DhXXLzXAs7MdYrtbtEhES8rL57K6aHPcs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=skacddQvgwz+Q5tHSdriEwEb3vmAoRpC1qMhzWo47UcfeDfecvCKO1bIc8KpEqyBu vQL6cxIfVkbdfMn7/uHvw7C+wmvqKiuDRwsR+QccJ8K6n4XHAO79H0p+WnapeJj0b5 9gOiwEeiyUmDRXxe/d2rFiwydAb6uQF805ZuoGW2ya1gROxpjFD7Iw7N1Y8tl+qUP7 jt5Rwjptvya/J82QFEotvwxrieUfj0GPJR0+luamILZueWaJOSk5DINEFfpeAQkR9o Iw9X+IpftnPAwoWNyfzaOO6oR81FA95NJUnnJeNWKtjfZ1t/d+mv/r4IeYTQwaRATP QSha7eCbfAS2A== Date: Fri, 1 Jul 2022 16:34:02 +0530 From: Vinod Koul To: Caleb Connolly Cc: Andy Gross , Bjorn Andersson , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Stephan Gerhold Subject: Re: [RESEND PATCH v2] dmaengine: qcom: bam_dma: fix runtime PM underflow Message-ID: References: <20220629140559.118537-1-caleb.connolly@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220629140559.118537-1-caleb.connolly@linaro.org> X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-06-22, 15:06, Caleb Connolly wrote: > Commit dbad41e7bb5f ("dmaengine: qcom: bam_dma: check if the runtime pm enabled") > caused unbalanced pm_runtime_get/put() calls when the bam is > controlled remotely. This commit reverts it and just enables pm_runtime > in all cases, the clk_* functions already just nop when the clock is NULL. > > Also clean up a bit by removing unnecessary bamclk null checks. Applied, thanks -- ~Vinod