Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220630195103.4088-1-andriy.shevchenko@linux.intel.com> <20220701113141.GB28070@willie-the-truck>
In-Reply-To: <20220701113141.GB28070@willie-the-truck>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 1 Jul 2022 13:38:16 +0200
Message-ID: <CAHp75Ve5ZNCEQ2ktAmeCWT_biibnNfqamxyzzRA+zaJBv_oX9g@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] drivers/perf: thunderx2_pmu: Replace open coded acpi_match_device()
To:     Will Deacon <will@kernel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 1, 2022 at 1:33 PM Will Deacon <will@kernel.org> wrote:
> On Thu, Jun 30, 2022 at 10:51:03PM +0300, Andy Shevchenko wrote:
> > Replace open coded acpi_match_device() in get_tx2_pmu_type().

> This doesn't even build for me:

Neither to me :-(

> Have you tested this at all?

It was a last minute change from __acpi_match_device() to
acpi_match_device() where arguments were swapped and obviously this
wasn't properly tested, sorry.

-- 
With Best Regards,
Andy Shevchenko