Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220630022317.15734-1-gch981213@gmail.com> <b84edc24-0a3a-a4d2-6481-fb3d4cee6dda@amd.com>
In-Reply-To: <b84edc24-0a3a-a4d2-6481-fb3d4cee6dda@amd.com>
From:   Chuanhong Guo <gch981213@gmail.com>
Date:   Fri, 1 Jul 2022 20:44:54 +0800
Message-ID: <CAJsYDVL=fgExYdw3JB-59rCwOqTbSt2N0Xw2WCmoTSzOQEMRRg@mail.gmail.com>
Subject: Re: [PATCH v5] ACPI: skip IRQ1 override on 3 Ryzen 6000 laptops
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        "Limonciello, Mario" <mario.limonciello@amd.com>
Cc:     linux-acpi@vger.kernel.org, stable@vger.kernel.org,
        Tighe Donnelly <tighe.donnelly@protonmail.com>,
        Kent Hou Man <knthmn0@gmail.com>,
        Len Brown <lenb@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 1, 2022 at 4:12 AM Limonciello, Mario
<mario.limonciello@amd.com> wrote:
> However I do want to point out that Windows doesn't care about legacy
> format or not.  This bug where keyboard doesn't work only popped up on
> Linux.
>
> Given the number of systems with the bug is appearing to grow I wonder
> if the right answer is actually a new heuristic that doesn't apply the
> kernel override for polarity inversion anymore.  Maybe if the system is
> 2022 or newer?  Or on the ACPI version?

The previous attempt to limit the scope of IRQ override ends up
breaking some other buggy devices:
https://patchwork.kernel.org/project/linux-acpi/patch/20210728151958.15205-1-hui.wang@canonical.com/

It's unfortunate that the original author of this IRQ override doesn't
limit the scope to their exact devices.

Hi, Rafael! What do you think? should we skip this IRQ override
one-by-one or add a different matching logic to check the bios date
instead?

-- 
Regards,
Chuanhong Guo