Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220701042122.5273-1-liubo03@inspur.com>
In-Reply-To: <20220701042122.5273-1-liubo03@inspur.com>
From:   Jim Mattson <jmattson@google.com>
Date:   Fri, 1 Jul 2022 06:08:45 -0700
Message-ID: <CALMp9eSFvTFn5Uogyu2XJbu6gcNL89R7OqbeF1yop650PUhYJw@mail.gmail.com>
Subject: Re: [PATCH] KVM: x86/mmu: Return true/false from bool function
To:     Bo Liu <liubo03@inspur.com>
Cc:     seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jun 30, 2022 at 10:50 PM Bo Liu <liubo03@inspur.com> wrote:
>
> Return boolean values ("true" or "false") instead of integer values
> from bool function.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
>  arch/x86/kvm/mmu/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index bfb50262fd37..572e0c487376 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -1024,7 +1024,7 @@ static bool rmap_can_add(struct kvm_vcpu *vcpu)
>         struct kvm_mmu_memory_cache *mc;
>
>         mc = &vcpu->arch.mmu_pte_list_desc_cache;
> -       return kvm_mmu_memory_cache_nr_free_objects(mc);
> +       return !!kvm_mmu_memory_cache_nr_free_objects(mc);

This is entirely unnecessary, since conversion of any scalar type to
bool already converts 0 to false and non-zero to true.

>  }
>
>  static void rmap_remove(struct kvm *kvm, u64 *spte)
> --
> 2.27.0
>