Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Jul 2022 15:52:49 +0200
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Magnus Karlsson <magnus.karlsson@gmail.com>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Network Development <netdev@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MAINTAINERS: adjust XDP SOCKETS after file movement
Message-ID: <Yr78Md1Nqpj+peO0@boxer>
References: <20220701042810.26362-1-lukas.bulwahn@gmail.com>
 <Yr7mcjRq57laZGEY@boxer>
 <CAJ8uoz16yGJqYX2xOcczTGKFnG4joh8+f1uPGMAP4rmm3feYDQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJ8uoz16yGJqYX2xOcczTGKFnG4joh8+f1uPGMAP4rmm3feYDQ@mail.gmail.com>
Precedence: bulk

On Fri, Jul 01, 2022 at 03:13:36PM +0200, Magnus Karlsson wrote:
> On Fri, Jul 1, 2022 at 2:38 PM Maciej Fijalkowski
> <maciej.fijalkowski@intel.com> wrote:
> >
> > On Fri, Jul 01, 2022 at 06:28:10AM +0200, Lukas Bulwahn wrote:
> > > Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves
> > > files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust
> > > the XDP SOCKETS (AF_XDP) section in MAINTAINERS.
> > >
> > > Adjust the file entry after this file movement.
> > >
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > > Andrii, please ack.
> > >
> > > Alexei, please pick this minor non-urgent clean-up on top of the commit above.
> > >
> > >  MAINTAINERS | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index fa4bfa3d10bf..27d9e65b9a85 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -22042,7 +22042,7 @@ F:    include/uapi/linux/xdp_diag.h
> > >  F:   include/net/netns/xdp.h
> > >  F:   net/xdp/
> > >  F:   samples/bpf/xdpsock*
> > > -F:   tools/lib/bpf/xsk*
> > > +F:   tools/testing/selftests/bpf/xsk*
> >
> > Magnus, this doesn't cover xdpxceiver.
> > How about we move the lib part and xdpxceiver part to a dedicated
> > directory? Or would it be too nested from main dir POV?
> 
> Or we can just call everything we add xsk* something?

No strong feelings. test_xsk.sh probably also needs to be addressed.
That's why I proposed dedicated dir.

> 
> > >
> > >  XEN BLOCK SUBSYSTEM
> > >  M:   Roger Pau Monn? <roger.pau@citrix.com>
> > > --
> > > 2.17.1
> > >