Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220618214009.2178567-1-aidanmacdonald.0x0@gmail.com>
 <20220618214009.2178567-14-aidanmacdonald.0x0@gmail.com>
 <cafd8a40ad35dcf8a35350261af6031c@walle.cc>
 <me4ummrWKIPseIG4ay7yCfrumN8sIdvc@localhost>
 <01a338e8f94b077df3fe2c4f13d4da28@walle.cc>
From:   Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To:     Michael Walle <michael@walle.cc>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, wens@csie.org, jic23@kernel.org,
        lee.jones@linaro.org, sre@kernel.org, broonie@kernel.org,
        gregkh@linuxfoundation.org, lgirdwood@gmail.com, lars@metafoo.de,
        rafael@kernel.org, quic_gurus@quicinc.com,
        sebastian.reichel@collabora.com, andy.shevchenko@gmail.com,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 13/16] pinctrl: Add AXP192 pin control driver
In-reply-to: <01a338e8f94b077df3fe2c4f13d4da28@walle.cc>
Date:   Fri, 01 Jul 2022 16:51:59 +0100
Message-ID: <HVuKY4uz71KVTEQCbjewrX6SufiowzOP@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Michael Walle <michael@walle.cc> writes:

> Am 2022-06-27 15:12, schrieb Aidan MacDonald:
>
>>> I *think* what is needed for gpio-regmap to support this is:
>>>  - support values and masks for the direction, for now, we
>>>    only support single bits.
>>>  - support the pinctrl_gpio_direction_{input,output} calls
>>> -michael
>> That sounds about right, thanks for taking a look.
>
> I thought you were trying to add these to gpio-regmap? Unless
> I'm missing something, that should be easy enough.
>
> -michael

Yeah, I can send patches this weekend. One detail I missed was the
to_irq() part, so I'm going to add a hook for that too.

The alternative is using hierarchical IRQ domains, but that seems
like a lot of added complication when to_irq() works just as well.