Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     tj@kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk
Cc:     m.szyprowski@samsung.com, nathan@kernel.org, michael@walle.cc,
        robh@kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, guillaume.tucker@collabora.com,
        pmladek@suse.com
Subject: [RESEND PATCH] kernfs: Avoid re-adding kernfs_node into kernfs_notify_list.
Date:   Sat,  2 Jul 2022 01:46:04 +1000
Message-Id: <20220701154604.2211008-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7W6igPfxDwrbem49vMCxJ26Vqi+kY81DbA62vVjN9VNnqY2BlBQlwT4LTL12?=
 =?us-ascii?Q?Vp9XA/gd+UBNvRaOEZtCvf/lF9ocN37pDhzg/z08gOuHoHUfrl1FnJCzSVQU?=
 =?us-ascii?Q?5d4Bl6Pk35HNfFwTzTyqGLQx220a7FTrxf8pczHQ9HwMSFwaVdgteizfeH7S?=
 =?us-ascii?Q?a/HJx5EWCN0WOHLDhIdcvpgqCQmVqVytPXFlxZrAGSix3XguJsovOiNgBypN?=
 =?us-ascii?Q?SpLe7XzpCmrm2Nrm9yv4dFYity+U1a3TipQD2CAK3hA8trVb/UfY3/uRK0Ql?=
 =?us-ascii?Q?q+6sgXdql6xg8dFBL8VvXGUjhCgEYYC8aiyzPyjtiq0/k3yGxY2iNON3I/0z?=
 =?us-ascii?Q?SJ4D0izq0IAyafKYf0pswOmB/WGci9y2ROrSH0tzeh74NNhT6zl7wJyu9rjm?=
 =?us-ascii?Q?IlVKTo7bZ9yxPHVuK7zBdAMjR1PvRMPmnVwW1m8NDNwctp+QJdxiUeXADgm0?=
 =?us-ascii?Q?IMAyl0gMHkmcNMwgcclddtElqjcGjfxnirzisX3kj8m8u5AYF1OcPl/f5LSx?=
 =?us-ascii?Q?BTONnfXzJhrVY+KenaBjcJKjabeEsEeL1zoI14O9BWoUy5GWDZ/v79c6iHE6?=
 =?us-ascii?Q?UlyXzepfNIqN5r+xBaUqT/wF8CZUyqivfY4HvGToB5x3urdW2cepJlvbz+Ep?=
 =?us-ascii?Q?MqS3pZuEGtQA2mgFfBsE4Qpx7y5aNx6fqcRAGdBBQqbyrlElFFfxCG9ioO41?=
 =?us-ascii?Q?62UMA2vUj+3cebl/+goNJYXJtP4R0O5aO2ojLNz3IaqLMbt/v3J6Q9AlJCDd?=
 =?us-ascii?Q?DdGwLB3ggg5Xq7XmzUbBgoF56FwPBoNhJz0I2GcHzj8JnxAWBgH9PZ2fXzTb?=
 =?us-ascii?Q?L0gfF4ZnUxxmNYEtI50PskHU7YjCcWDuifVK9QoE9M4EDjpknhNjhge+XLOY?=
 =?us-ascii?Q?hgjZHwWZy904JCQW/5EXfHEpuj4UbMnSv2f/GT7Gj3n5mM9OxQBnWKpYBAz4?=
 =?us-ascii?Q?Tk8St5uds6Xy0UPOASoHxsVATub+Ck2ph6Mkv8PHJp8Yiu19PmJLt24eSWyT?=
 =?us-ascii?Q?NXyz98yvhdlILEt9RCuieFeDthsFRl04REfZIFeo+9wLKm6nQR4kIq9a8JL1?=
 =?us-ascii?Q?O/pqhS7bUHME7kZWotIsKHJL7WwjRe2XVY1mOs8fUK5BikuxLgy0Dba3fMnh?=
 =?us-ascii?Q?MxxTNPtD11+mok0DElDOBxdiOOaj/0IaDaaxlEZxqHcn1PxLsAAf8aVDAeEq?=
 =?us-ascii?Q?qJs1FSGGiMCDbTcUE3EsEsT7LOPtOWjnyJvKlt+2zWxWbBXBbJ7c6TdHqVR2?=
 =?us-ascii?Q?+pxn/sXPV4FT19lgz7wSkcWfy9YbtYJF8MPSl9HiK/8nOSrBQgk59edRhy4j?=
 =?us-ascii?Q?SYDxCSLxky7tjpZY1hquPNLPnN3qObWNWQTs75SzRbO6v95YxI70Ucl2Se5V?=
 =?us-ascii?Q?SSI/3mSx/vvpl3Vsqx+mOEVfHv3CY8mvJjxYA1xErmKgEnWH8bYRYS6Nj0Zw?=
 =?us-ascii?Q?yfJs+mRzSLc76eBBOpJYXCj6CQmZHeK8ZMmbsY5TYUd8ZdMg6QJLRI+hHmYT?=
 =?us-ascii?Q?ZCDZFZj6GisyRbgj/yx93zrG82GXVrmANoAcqK4EspSl1gtIa5KKf6wuvG9f?=
 =?us-ascii?Q?0lf/xGpJMy4xE2V9D6vXwVIAo+yUeBLVitbq3+CgwUDGvgNrjfzBfOmThxWz?=
 =?us-ascii?Q?SA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4814e7d-74c7-45db-e179-08da5b78d6ab
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 15:46:18.3700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EgLYvDdysZwN09nsrFPQp3N0lgDM5xO3J13QHuq/ZrSTcW/ViXoZOCF+MdKSjiJ2F2J80kGI7VhR2k4XAlOX1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3603
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-01_08:2022-06-28,2022-07-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2207010062
X-Proofpoint-GUID: ZkSY6QeAvlpLZu6liEeAwSVnBtoft2Oc
X-Proofpoint-ORIG-GUID: ZkSY6QeAvlpLZu6liEeAwSVnBtoft2Oc
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Kick fsnotify only if an event is not already scheduled for target
kernfs node. commit b8f35fa1188b ("kernfs: Change kernfs_notify_list to
llist.") changed kernfs_notify_list to a llist.
Prior to this list was a singly linked list, protected by
kernfs_notify_lock. Whenever a kernfs_node was added to the list
its ->attr.notify_next was set to head of the list and upon removal
->attr.notify_next was reset to NULL. Addition to kernfs_notify_list
would only happen if kernfs_node was not already in the list i.e.
if ->attr.notify_next was NULL. commit b8f35fa1188b ("kernfs: Change
kernfs_notify_list to llist.") removed this checking and this was wrong
as it resulted in multiple additions for same kernfs_node.

So far this bug only got reflected with some console related setting.
Nathan found this issue when console was specified both in DT and in
kernel command line and Marek found this issue when earlycon was enabled.

This patch avoids adding an already added kernfs_node into notify list.

Reported-by: Nathan Chancellor <nathan@kernel.org>
Reported-by: Michael Walle <michael@walle.cc>
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Fixes: b8f35fa1188b ("kernfs: Change kernfs_notify_list to llist.")
Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
---

Resending after adding Reported-by and Tested-by tags missed earlier.

 fs/kernfs/file.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index bb933221b4bae..e8ec054e11c63 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -917,6 +917,7 @@ static void kernfs_notify_workfn(struct work_struct *work)
 	if (free == NULL)
 		return;
 
+	free->next = NULL;
 	attr = llist_entry(free, struct kernfs_elem_attr, notify_next);
 	kn = attribute_to_node(attr, struct kernfs_node, attr);
 	root = kernfs_root(kn);
@@ -992,9 +993,11 @@ void kernfs_notify(struct kernfs_node *kn)
 	rcu_read_unlock();
 
 	/* schedule work to kick fsnotify */
-	kernfs_get(kn);
-	llist_add(&kn->attr.notify_next, &kernfs_notify_list);
-	schedule_work(&kernfs_notify_work);
+	if (kn->attr.notify_next.next != NULL) {
+		kernfs_get(kn);
+		llist_add(&kn->attr.notify_next, &kernfs_notify_list);
+		schedule_work(&kernfs_notify_work);
+	}
 }
 EXPORT_SYMBOL_GPL(kernfs_notify);
 

base-commit: 6cc11d2a1759275b856e464265823d94aabd5eaf
-- 
2.30.2