Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5312a278-b6c2-4778-97c8-3c8628d9ee38@oracle.com>
Date:   Fri, 1 Jul 2022 10:08:42 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2 1/9] mm: Add msharefs filesystem
Content-Language: en-US
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     akpm@linux-foundation.org, willy@infradead.org,
        aneesh.kumar@linux.ibm.com, arnd@arndb.de, 21cnbao@gmail.com,
        corbet@lwn.net, dave.hansen@linux.intel.com, david@redhat.com,
        ebiederm@xmission.com, hagen@jauu.net, jack@suse.cz,
        keescook@chromium.org, kirill@shutemov.name, kucharsk@gmail.com,
        linkinjeon@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        longpeng2@huawei.com, luto@kernel.org, markhemm@googlemail.com,
        pcc@google.com, rppt@kernel.org, sieberf@amazon.com,
        sjpark@amazon.de, surenb@google.com, tst@schoebel-theuer.de,
        yzaikin@google.com
References: <cover.1656531090.git.khalid.aziz@oracle.com>
 <de5566e71e038d95342d00364c6760c7078cb091.1656531090.git.khalid.aziz@oracle.com>
 <Yr4qY32eHzJy5vvw@ZenIV>
From:   Khalid Aziz <khalid.aziz@oracle.com>
In-Reply-To: <Yr4qY32eHzJy5vvw@ZenIV>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjRqNjZnaUJrYkM5SHVnUE1kc1NXMzJSM2t6SmEyTTFtem1jRjFJLyszVGJi?=
 =?utf-8?B?YVRKMENCOGV2M2NUSEdTbnEveXBMN0NhaEZJSUJvcm14N2JHR0xkaDI0dUxo?=
 =?utf-8?B?a05jQ016dUc1Y0poS1AxZzVZbkUzOUI0NUVadTlXS2VpZkNla2VuS3ZPOExa?=
 =?utf-8?B?aHhvd2Jtdjd0MHZ5WWNFalg5bWQvT1NUWi9tYVpxUWJGMmdTeFNmRmI2Ujk0?=
 =?utf-8?B?RFRSZmtqTHFDdVVvSFkwOElUVy9mUkhBQnFqV3JoZ1JrbFVXR3FORmNhdUt1?=
 =?utf-8?B?T2wxcFc5SXRUNG42VHJyRG9CQkgvOHRQSmUycVRXbGJJcEZKb1NJUWdhcWlZ?=
 =?utf-8?B?aTdKRmV0d2J2MVpUWHlheVZYZTlKdEhqalJDbnB3RWZwZXZYTVlsN3AxRGVi?=
 =?utf-8?B?ZFJwVStXRFdYT3o2YjdXalQ0N3grZE1ZbXdxVGw2YTY4RlRSVEd1Q1JKb0NF?=
 =?utf-8?B?Wk1yZVlZUWFHKzV5ZVFtN2RTOFF6L0VCSjB2MDRQZGFhRlltSTN1OVJYQ1Zn?=
 =?utf-8?B?L0pGT3UzK2dScnBqMFlWSDlmaUN2Y2RjU3lrUjJNVVpONmplaytkRWhMOHNR?=
 =?utf-8?B?dlNlcUJzeUp4VFFaWGZNTEVBL3N6Q0lZOEVWRDUzUFZMMU5vMHpuRE5FNnZT?=
 =?utf-8?B?WFhFNGZJSzNYTXE2YkdxYkFKR2F4N01sWGZja3FMbWxmNnpMY3BoNS8xZ1R3?=
 =?utf-8?B?ckoyMExHSFJ1N1h2dzlxTmZGYTV2blp0NUF2NmR5NVVKQXRNSWdJSmpKWWxH?=
 =?utf-8?B?ZGIvRFpTYVVUd1ZJYlMwVFhPbDAwc2ZUcHF2SWtwK3pKTFl1RWEyRTNhVnFE?=
 =?utf-8?B?ZkYzMGY4bmg0V0NSZVRSQjU1QUM0d29VS2lORWJ1TWsvWE5ZQ1QvWUJBOEY3?=
 =?utf-8?B?ZzdIWUlXajdsVXA1VUpYYWIrN09zNEhzaWJ1ZExFZFZ2VFNjR3hBVUpwQlNW?=
 =?utf-8?B?azRDSDIwdXhCUEl0eVpIWTdGMkZxZmtCUDZKRXBHZFFLbWMyVEN4d3dBVzBF?=
 =?utf-8?B?YXo2cDRTRTlVU01Oc0NMZ0VnVVRMczZ5OEI2RjFpNmZUMXMxcHZKSzhvVmZr?=
 =?utf-8?B?Vy9mSkpITWtTdWhWU1Y0NVhQdE16L2xTdmhudUpXRmNKOFNsSzY4blkxM3hR?=
 =?utf-8?B?OVRpdmsrMVltT3JpeWZKeWZMQTIzNGd6RUc2MFdRZnErc3c3SEhScFRSekE5?=
 =?utf-8?B?Y1NMNGVLcEh0N0w1VDJYMUF0S0NlUVVvNTh6V0Ira0VRY0lHK2cwRDhEL1Ra?=
 =?utf-8?B?WVRDaFZqU29ZanhJSWpzNkhMYXlqS1BTcWR3ODA4TnZraFNxM05uYVdVRyty?=
 =?utf-8?B?M3RKdUJJb013bzEyWG5QL0ZFd0JQQmZUbWJsVjhWZkRSckVyMFQxRjVnRmRB?=
 =?utf-8?B?UjJ1VVp1dFB2ZnN3R0N1ekJrbEtHMVBXNDlGN0EzcHl6VnI0SDMyVnl0ZEI0?=
 =?utf-8?B?akwyditTcUNKN0J0REpac3JnM1pKdjVObzFyOFVCc3BLUXhVVlhpalU3Q2wy?=
 =?utf-8?B?dDVPQ2ZrZmNibGt0MjMrYkdsYmJpMzlrbEUwZFo3ZXUvZ3ZkUHVvenYrV3Bs?=
 =?utf-8?B?STB0bHgxME5QOGpNTW50MzhBVS9rNU1zVFBvcUY3TVdzYjhsTXFTb2lRZDln?=
 =?utf-8?B?Sng4THJTMnRqQmc4OHlrSmFQejNzb2d5WjVrSDVHSGM4RmsrdW04bnc4MFFj?=
 =?utf-8?B?UnkxY3RBcEtJUXQ1TGhLSC9ONlNMRmo4MWZaU2ROU3lvakZqRG9aQ1dXeE8v?=
 =?utf-8?B?ZEI0MTBVQStaa3NSbTB2T3pQN3NmczkxRnk1TG9lUEZUU1B5SVhLNE1mWjVZ?=
 =?utf-8?B?REx6TWZCM3R2UmlFdmxXMCtRRWZTTktuYnovVCtCSkc3VVlhM2NiVWNzOUZk?=
 =?utf-8?B?WjQxaXBJMFRPMnhoSkVCaHV4L2hPY0pwRDB4ZVJPYUs5d2RqbnhIME9IZHpn?=
 =?utf-8?B?bTNKdWhKcTFlR0JaWFBiZGoxNmR5M0tuT0hSaDFqVjhWdVgxWHJBTDAyWUda?=
 =?utf-8?B?QkpIUmN0K09VRHVzZkpDeTNwZENzQm1RbUFoMzFYN0VCbkZiUi9ZY1lOdVdw?=
 =?utf-8?B?bzA0UUpndWJSUHkxQlB0RC8yNithdExEKy9BaldXblp2T2dqRnk1K1FlVk1K?=
 =?utf-8?Q?3Vl9oZN1P/2CmSfNRmGMkuHSf?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77100e97-dcf0-4adb-7ebb-08da5b7bf9d5
X-MS-Exchange-CrossTenant-AuthSource: BN8PR10MB3220.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 16:08:45.8844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m5NerDvstpXe5Ln1VwCFiqCCR5xqdH/uA0FvyAm2i6KtrTtJ816hZCWub0pvdvpQm1c/0SgqOpLA241cNwuE0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3892
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-01_08:2022-06-28,2022-07-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0
 malwarescore=0 mlxlogscore=746 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2207010064
X-Proofpoint-ORIG-GUID: 7rl-QwhHTWJ1FQtmvyKuJ5kG3U0wh0Gy
X-Proofpoint-GUID: 7rl-QwhHTWJ1FQtmvyKuJ5kG3U0wh0Gy
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/30/22 16:57, Al Viro wrote:
> On Wed, Jun 29, 2022 at 04:53:52PM -0600, Khalid Aziz wrote:
>> +static int
>> +msharefs_d_hash(const struct dentry *dentry, struct qstr *qstr)
>> +{
>> +	unsigned long hash = init_name_hash(dentry);
>> +	const unsigned char *s = qstr->name;
>> +	unsigned int len = qstr->len;
>> +
>> +	while (len--)
>> +		hash = partial_name_hash(*s++, hash);
>> +	qstr->hash = end_name_hash(hash);
>> +	return 0;
>> +}
> 
> What do you need that for and how is it different from letting it
> use full_name_hash() (which is what it will do if you leave
> dentry_operations->d_hash equal to NULL)?

I don't have a specific reason to use msharefs_d_hash(). If full_name_hash() can work, I don't mind reducing amount of 
code in my patch. I will take a look at it.

Thanks,
Khalid