Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <85ce95fc-0baa-8b25-8393-bed1268cc17b@oracle.com>
Date:   Fri, 1 Jul 2022 10:11:40 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2 2/9] mm/mshare: pre-populate msharefs with information
 file
Content-Language: en-US
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     akpm@linux-foundation.org, willy@infradead.org,
        aneesh.kumar@linux.ibm.com, arnd@arndb.de, 21cnbao@gmail.com,
        corbet@lwn.net, dave.hansen@linux.intel.com, david@redhat.com,
        ebiederm@xmission.com, hagen@jauu.net, jack@suse.cz,
        keescook@chromium.org, kirill@shutemov.name, kucharsk@gmail.com,
        linkinjeon@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        longpeng2@huawei.com, luto@kernel.org, markhemm@googlemail.com,
        pcc@google.com, rppt@kernel.org, sieberf@amazon.com,
        sjpark@amazon.de, surenb@google.com, tst@schoebel-theuer.de,
        yzaikin@google.com
References: <cover.1656531090.git.khalid.aziz@oracle.com>
 <34e2eabbef5916c784dc16856ce25b3967f9b405.1656531090.git.khalid.aziz@oracle.com>
 <Yr4rP7rfxqOzxbCZ@ZenIV>
From:   Khalid Aziz <khalid.aziz@oracle.com>
In-Reply-To: <Yr4rP7rfxqOzxbCZ@ZenIV>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnJuaDFqYmU5ZC9DbW1WUFY5MWxMZzRGdHJLWjJ2YndIOVBlc0o0VjhwZGda?=
 =?utf-8?B?VUFJdW5mdDU0cytOLzdsSE8zV1FTcUljUWxGaTVRRzRnT2lPbEcxek5LRExP?=
 =?utf-8?B?MTl1TnpRK2x4dTRraVNFRjl6cGo2elFXTVJONFAxSHpnM2ZuMklJS0F6NXBz?=
 =?utf-8?B?UlMxVXhwM01JcklINjhMcHBibEpKYlAydFZ6em5nU2dVVUplcFAzVW1TT3R0?=
 =?utf-8?B?VlkzRDVRU3hvS3U2cE9VaCtNWFM1QjU3L2l6cTRIUHkzcEVoamhRS21xZjVk?=
 =?utf-8?B?SWZFVVZDQXRDS3E0U295SFk0Z3NHQVZVU3VTMFZIRytmcCtFb0svUjl6K01o?=
 =?utf-8?B?VEM3L3BqaFlNaTZXRTdtVjhWZVdsYnlYVE9yVDVaTGl4SnpKUzIyTU5qQ3Nw?=
 =?utf-8?B?OWVIZG5IazlFNXlsZ3Vtc1dMYmkwSDY2SmFqc2puZ1NiR25yNjFWQjYxZk5y?=
 =?utf-8?B?aUd1RlVzbXBYK0hwOEp2bHhIWGYwSVlvREZMSzA1aUczcHo5Y0dXS3QrL2Zq?=
 =?utf-8?B?cUdQc3NyNUpKajEwdWQzNFZjQkprcnEwUzZEb2J2K0JLQk8yOGsvWTNFTnJp?=
 =?utf-8?B?L2xZZHZFRWpFMGFtbmhzZlBJVndlZnhYOTZ1UXc5OVBKWEN3enJzQlNYL3Rm?=
 =?utf-8?B?ZStQMGFVSnNYbElkY3dkSFVrWUhXNm1CVUZoeWlJYjFZck84UW15NDhPM2Rs?=
 =?utf-8?B?eDVGcFJUNDlGWmg2Uy9LTlBqRWZ2ZE4rbG03TEN1WkdVb1d2TXFkYjRvS1lB?=
 =?utf-8?B?aUozcTJEYTFzS1RyNE1vSXB5aTR4YitEeHExSFA5SUdPaDl3L2hHNllCbjlC?=
 =?utf-8?B?NGxTWVZZSjViRjVheFB5cE5rL2NURkhWcjhmbU5MVUduaitkVndtNTNvdU9t?=
 =?utf-8?B?bTB0WUtDSFE3aVMyM2pvYVpnWUJ5TTRmaXhGSVUvS3V0S1AySU1maUtJd1FJ?=
 =?utf-8?B?bi9qcHVNWDRCVGlteC9WRDRDNENIa3ZxTUtCN2xxZHNvemg4NVc4S1AvRnRl?=
 =?utf-8?B?dGYvaWlPa014dSsyaEFHWWpCbUp2aE92c3N0TjQ3OEFYdjJXYi9WcktDS1N1?=
 =?utf-8?B?cXAzVlhLaGxCdHlxcE1VMzBEaW05M0tZQkdCNzFMelhjMW9LdWtpYytyaDJK?=
 =?utf-8?B?Vk5uM2dXWkJKZEVUTFkyMHhDa1JvWUJCeFhBWGxGUGtnaXY4RVk2a3B2eERK?=
 =?utf-8?B?czFMU3A3QUdOOEhlaVJoMm5yZmtVNWNzR2k3cy9EeUJxbTdLcW5yNCtLdzNx?=
 =?utf-8?B?YWovaFZOczFCWnYwWFpML0lOekJCaEpYc1plb1RzSHQ4Mk1WdUtwUVk0b0RZ?=
 =?utf-8?B?V25hcUg4b0hLaEZjMElPQmxaMU14elVKeHROUzlPenY3NHZObjc5cVg0eWdu?=
 =?utf-8?B?MjZ0bGZQallBdnpCc0FUVFIxK0E5ZUhFYUxKZGtxSDlTbUlsQVpiWEVTRS9x?=
 =?utf-8?B?TklFakdnU0o1cDdqS0dCdTlGZ3RaSTJWQzArVGMyYzI2SC96SVRpRVl3ZC95?=
 =?utf-8?B?TEJDSTNBdEFCSmFqMS9ZY3U2cDZqdFNwaFJBOGdpeVlsdzRsK2daS2t6TVVM?=
 =?utf-8?B?ZGhuaDZwT21qSkRDelBJcWRKSlVZdTR1NjVkQlBLUDFhZVltb3VKbkZ3OHBN?=
 =?utf-8?B?SlJhUCtqV1dFWis3M1paQmtUTzBIY3h6VFdqcjhGUDV4Z0w1cWpwSU9LVlFR?=
 =?utf-8?B?Q1pTWGNGSnB4TDRqWis0a0NHTEduSk1kb25DV1VVSXpLMHhjSk1OYnZWN20r?=
 =?utf-8?B?c2ZIWlpvN2RuQ2ttN2YxYXRLSVlUQjV2UHM2M3QrblV5U2grUEJJSXhTSmN0?=
 =?utf-8?B?S0Y1eVV2R2NkcWRWczVKbGlQYklVa0t3M1lyMEVpalNaU01CZUN2TnNVUEpm?=
 =?utf-8?B?Y2R3SktQZFRiSFBicjZhalh5QzNTQkNzM25HMnUwYzNpbWFKakZnNFozWk9M?=
 =?utf-8?B?dlZHanl3YWJJZEtFbEZZKytLbzZkSXNPTEZTREZpUjF0bjFXdTYydVN5ZFFo?=
 =?utf-8?B?cmQxZDdVdk1uVlVJT2xZV0xRODdmUVZ5enh6TnBqQXNER05zdGZ5dE41ZW45?=
 =?utf-8?B?d3VhK0tIYjdGVVF1MnNVbk5raTdCaysxQWYxOTlkNUUvZnF6MEdIM1RneHFq?=
 =?utf-8?Q?M2jztSd8KFfnFwA0jP1amu+Sm?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67f5b534-a055-46fb-2ed3-08da5b7c6514
X-MS-Exchange-CrossTenant-AuthSource: BN8PR10MB3220.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 16:11:45.8427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I/jvWvKNoi5rLzH6atAeTZcxknn1gcE0SdHSuoNmVFMTQB4/gtqsJrpbt1IsSjKSlDLSng8Zl1nCf+fxDhelmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3892
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-01_08:2022-06-28,2022-07-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0
 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2207010064
X-Proofpoint-GUID: HrQmfynTd3aoLlPF5Db_sW8OCyytZXh0
X-Proofpoint-ORIG-GUID: HrQmfynTd3aoLlPF5Db_sW8OCyytZXh0
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/30/22 17:01, Al Viro wrote:
> On Wed, Jun 29, 2022 at 04:53:53PM -0600, Khalid Aziz wrote:
> 
>> +static void
>> +mshare_evict_inode(struct inode *inode)
>> +{
>> +	clear_inode(inode);
>> +}
> 
> Again, what for?  And while we are at it, shouldn't you evict the
> pages when inode gets freed and ->i_data along with it?
> IOW, aren't you missing
>                  truncate_inode_pages_final(&inode->i_data);
> That, or just leave ->evict_inode NULL...

Good suggestion. I thought I would need to do more in evict_inode() but turned out I didn't. It is time to eject this 
routine from my code.

Thanks,
Khalid