Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 01 Jul 2022 18:46:40 +0000
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Reply-To: Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH 1/4] arm64: dts: qcom: Add LPG to pm8916, pm8994, pmi8994 and pmi8998
Message-ID: <2e506766-39f3-b70f-b91e-ce120293d05e@connolly.tech>
In-Reply-To: <20220505022706.1692554-2-bjorn.andersson@linaro.org>
References: <20220505022706.1692554-1-bjorn.andersson@linaro.org> <20220505022706.1692554-2-bjorn.andersson@linaro.org>
Feedback-ID: 10753939:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 05/05/2022 03:27, Bjorn Andersson wrote:
> Add PWM/LPG nodes to the PMICs currently supported by the binding.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
fwiw:
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> ---
>   arch/arm64/boot/dts/qcom/pm8916.dtsi  |  8 ++++++++
>   arch/arm64/boot/dts/qcom/pm8994.dtsi  | 10 ++++++++++
>   arch/arm64/boot/dts/qcom/pmi8994.dtsi | 10 ++++++++++
>   arch/arm64/boot/dts/qcom/pmi8998.dtsi | 11 ++++++++++-
>   4 files changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/q=
com/pm8916.dtsi
> index d58902432812..99bf8387bfb6 100644
> --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> @@ -125,6 +125,14 @@ pm8916_1: pmic@1 {
>   =09=09#address-cells =3D <1>;
>   =09=09#size-cells =3D <0>;
>
> +=09=09pm8916_pwm: pwm {
> +=09=09=09compatible =3D "qcom,pm8916-pwm";
> +
> +=09=09=09#pwm-cells =3D <2>;
> +
> +=09=09=09status =3D "disabled";
> +=09=09};
> +
>   =09=09pm8916_vib: vibrator@c000 {
>   =09=09=09compatible =3D "qcom,pm8916-vib";
>   =09=09=09reg =3D <0xc000>;
> diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/q=
com/pm8994.dtsi
> index 5ab46117d737..ab342397fcd8 100644
> --- a/arch/arm64/boot/dts/qcom/pm8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> @@ -135,6 +135,16 @@ pmic@1 {
>   =09=09#address-cells =3D <1>;
>   =09=09#size-cells =3D <0>;
>
> +=09=09pm8994_lpg: lpg {
> +=09=09=09compatible =3D "qcom,pm8994-lpg";
> +
> +=09=09=09#address-cells =3D <1>;
> +=09=09=09#size-cells =3D <0>;
> +=09=09=09#pwm-cells =3D <2>;
> +
> +=09=09=09status =3D "disabled";
> +=09=09};
> +
>   =09=09pm8994_spmi_regulators: regulators {
>   =09=09=09compatible =3D "qcom,pm8994-regulators";
>   =09=09};
> diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/=
qcom/pmi8994.dtsi
> index 6e7c252568e6..b1b50c99ada2 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> @@ -27,6 +27,16 @@ pmic@3 {
>   =09=09#address-cells =3D <1>;
>   =09=09#size-cells =3D <0>;
>
> +=09=09pmi8994_lpg: lpg {
> +=09=09=09compatible =3D "qcom,pmi8994-lpg";
> +
> +=09=09=09#address-cells =3D <1>;
> +=09=09=09#size-cells =3D <0>;
> +=09=09=09#pwm-cells =3D <2>;
> +
> +=09=09=09status =3D "disabled";
> +=09=09};
> +
>   =09=09pmi8994_spmi_regulators: regulators {
>   =09=09=09compatible =3D "qcom,pmi8994-regulators";
>   =09=09=09#address-cells =3D <1>;
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/=
qcom/pmi8998.dtsi
> index 0fef5f113f05..7af106683f8d 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -42,6 +42,16 @@ lab: lab {
>   =09=09=09};
>   =09=09};
>
> +=09=09pmi8998_lpg: lpg {
> +=09=09=09compatible =3D "qcom,pmi8998-lpg";
> +
> +=09=09=09#address-cells =3D <1>;
> +=09=09=09#size-cells =3D <0>;
> +=09=09=09#pwm-cells =3D <2>;
> +
> +=09=09=09status =3D "disabled";
> +=09=09};
> +
>   =09=09pmi8998_wled: leds@d800 {
>   =09=09=09compatible =3D "qcom,pmi8998-wled";
>   =09=09=09reg =3D <0xd800 0xd900>;
> @@ -52,6 +62,5 @@ pmi8998_wled: leds@d800 {
>
>   =09=09=09status =3D "disabled";
>   =09=09};
> -
>   =09};
>   };
> --
> 2.35.1
>

--
Kind Regards,
Caleb