Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 01 Jul 2022 18:49:16 +0000
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Reply-To: Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH 2/4] arm64: dts: qcom: sdm845: Enable user LEDs on DB845c
Message-ID: <d12442a6-a0f1-0cb4-caa0-b7bb22fff28d@connolly.tech>
In-Reply-To: <20220505022706.1692554-3-bjorn.andersson@linaro.org>
References: <20220505022706.1692554-1-bjorn.andersson@linaro.org> <20220505022706.1692554-3-bjorn.andersson@linaro.org>
Feedback-ID: 10753939:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 05/05/2022 03:27, Bjorn Andersson wrote:
> The DB845c has 4 "user LEDs", the last one is already supported as it's
> just wired to a gpio. Now that the LPG binding is in place we can wire
> up the other 3 LEDs as well.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> ---
>   arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 31 ++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot=
/dts/qcom/sdm845-db845c.dts
> index 194ebeb3259c..e4d3de0a1e6d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -5,6 +5,7 @@
>
>   /dts-v1/;
>
> +#include <dt-bindings/leds/common.h>
>   #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>   #include <dt-bindings/sound/qcom,q6afe.h>
> @@ -606,6 +607,36 @@ resin {
>   =09};
>   };
>
> +&pmi8998_lpg {
> +=09status =3D "okay";
> +
> +=09qcom,power-source =3D <1>;
> +
> +=09led@3 {
> +=09=09reg =3D <3>;
> +=09=09color =3D <LED_COLOR_ID_GREEN>;
> +=09=09function =3D LED_FUNCTION_HEARTBEAT;
> +=09=09function-enumerator =3D <3>;
> +
> +=09=09linux,default-trigger =3D "heartbeat";
> +=09=09default-state =3D "on";
> +=09};
> +
> +=09led@4 {
> +=09=09reg =3D <4>;
> +=09=09color =3D <LED_COLOR_ID_GREEN>;
> +=09=09function =3D LED_FUNCTION_INDICATOR;
> +=09=09function-enumerator =3D <2>;
> +=09};
> +
> +=09led@5 {
> +=09=09reg =3D <5>;
> +=09=09color =3D <LED_COLOR_ID_GREEN>;
> +=09=09function =3D LED_FUNCTION_INDICATOR;
> +=09=09function-enumerator =3D <1>;
> +=09};
> +};
> +
>   /* QUAT I2S Uses 4 I2S SD Lines for audio on LT9611 HDMI Bridge */
>   &q6afedai {
>   =09qi2s@22 {
> --
> 2.35.1
>

--
Kind Regards,
Caleb