Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7d763251-c761-1260-b03a-cecf8f6f9738@gmail.com>
Date:   Fri, 1 Jul 2022 22:58:58 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon
Content-Language: en-US
To:     Martin Kaiser <lists@kaiser.cx>,
        Yang Li <yang.lee@linux.alibaba.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20220630090937.4983-1-yang.lee@linux.alibaba.com>
 <20220630115848.hkzavd67cwjubjq4@viti.kaiser.cx>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <20220630115848.hkzavd67cwjubjq4@viti.kaiser.cx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Martin,

Martin Kaiser <lists@kaiser.cx> says:
> Thus wrote Yang Li (yang.lee@linux.alibaba.com):
> 
>> Eliminate the following coccicheck warning:
>> ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
> 
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>>  drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>> diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> index b5f6d41464db..5b0f66573d94 100644
>> --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
>>  		break;
>>  	default:
>>  		return false;
>> -	};
>> +	}
> 
>>  	do {
>>  		pwrcfgcmd = pwrseqcmd[aryidx];
>> -- 
>> 2.20.1.7.g153144c
> 
> Thanks for spotting this.
> 
> Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")

^^^^^^^^^^^^^^^^^^^^^^^^^^

No need to backport code-style warning, so Fixes: is not needed here.


Thanks,
--Pavel Skripkin