Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Jul 2022 12:52:42 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Davidlohr Bueso <dave@stgolabs.net>
CC:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lukas Wunner <lukas@wunner.de>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V12 4/9] cxl/pci: Create PCI DOE mailbox's for memory
 devices
Message-ID: <Yr9Qiv/tV8f9z+Xx@iweiny-desk3>
References: <20220628041527.742333-1-ira.weiny@intel.com>
 <20220628041527.742333-5-ira.weiny@intel.com>
 <20220628153317.00002e36@Huawei.com>
 <Yr01iZhuG5YHThDg@iweiny-desk3>
 <20220630163240.00003596@Huawei.com>
 <20220630161406.yglzoxn2va3bhts4@offworld>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220630161406.yglzoxn2va3bhts4@offworld>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y7XUx/yHeUZGj1iJpWv5VzpUN1be1owZTmLnZOf/kvdryYkkN2jKzF1Vbk5A?=
 =?us-ascii?Q?UVXrFdNJfPu3003ritMaG6b+VYjgxoNO6p7YBT628uDQl06bVbwUn5PEcW0l?=
 =?us-ascii?Q?XCkb2/Vy9mJ7R5fUb+cn58t358vz32dhijh2omSA3OvFQJ14YDoNsskuX7If?=
 =?us-ascii?Q?dT4rtL/zlEO2k8lTYgeSTQ0Jt55SSTmdQKTBn5ESbq7bdtGy0XaHAgSpNzzS?=
 =?us-ascii?Q?ML6gG4H34m1KC32PftX2Vw2NTEVYoMw2cViPsqNjcB8SFYLkqXwdBJ9loiSH?=
 =?us-ascii?Q?WclnW07cCPVadgqdHSA8RhNFHWVV3G95Q14zU6+XiWU49o7xmnnpbjFDxJ5l?=
 =?us-ascii?Q?+JDzITtmjZ9v2q+XpSpnZ2VSGOVOdziCdRCcnT3QVnYUDi81SY6GG2LBi6nU?=
 =?us-ascii?Q?65mBG6HUMrqs8ApHIAIQJEGOxr7ac9CNSWMmS3smOPraBZRkA7cEFbi8yV8I?=
 =?us-ascii?Q?ZbQeMz+YDq6z/I5FRq2BYabSV8J5tDELBD8O36eTcPEk+7Qf/CG09bvfk2Py?=
 =?us-ascii?Q?+84CtyqXXs1d3CWOYz5zd84bWQmOZNzIMgNv0lKXxkrKe+hevjTU4QMYndaP?=
 =?us-ascii?Q?GaHYKCNFlp1o9LXbxqDs1ttQwGmEdf53294PQcD8RBlXNCyPY5BoVz9n9N20?=
 =?us-ascii?Q?Oq9bk4cwYSn3AQef5FRxZOkay9iD53goEnpQ9kQe7spTWl1UYQSJET2zUq24?=
 =?us-ascii?Q?/qkjtrekWm4DGoIFEIgnT9Z2Otj0YFWaY+o/Xr3FjKikKJUOCBuWcQzlp3eW?=
 =?us-ascii?Q?hBXEK6o36xfDCMBYuJd4VskDwFHl9UI3WvWWPzXCTFZGj2m5MapmJtAUc1LQ?=
 =?us-ascii?Q?/7xpIXxBkATSljraTeflQF9YO3BIZyGTsnCgSS1H2VKNMZspxiuZz7yC9BO2?=
 =?us-ascii?Q?VN1XvDw76u9zxsjh5bZETINdctE3sJ+V/ZvaJcEjZWAb0o7EZ2iRxAoeBw1o?=
 =?us-ascii?Q?E8KbEPT6+azdBmNpXu4NNldVaBNpzgVf/R554EFWsDifeeIBQ8auM5eUDNlv?=
 =?us-ascii?Q?UviMbN4CjXwJPKZnPHeIXcHbub49Gb0wMLOCzJZFlC6oCyiinXMye89UuYaO?=
 =?us-ascii?Q?ERNQjskq5fDSkhrFwm7Nc2ibGDU28lMT//wMuPS0ow7tnCUPuy6Q0mH2XiM8?=
 =?us-ascii?Q?wzaDN+AyAF26aCYuyiPji8LwyqyuS/rO3RBLOvy1o9ovclKlCKZlMJ2eviuq?=
 =?us-ascii?Q?jJc91UGa7AWEckf1NAO82lUvW3s/YQUYZD9D0qCTrpR4gskB5wBCgPAslOCU?=
 =?us-ascii?Q?68MLr8OWINR3sP+P8UB/v7eoeRl+k8N0Cu2H8gQqMFxZBHrxOeeDR9+zFSdW?=
 =?us-ascii?Q?kGAJo083tQrKJ9n54Ojg7X82RvnxnHIiVmYq/k08V9ejrfxPl6K/HpeQttla?=
 =?us-ascii?Q?IBT310h08mfijWRy7g8UjjoQreIfBNWoEAlvd6Ha7V9atcyTRxXt86wPj1t4?=
 =?us-ascii?Q?msTdHlAkChYgSEIhPkDiCUpV553Qu2iArix6T1N57BnUw1kZm4pYqk9QNWlf?=
 =?us-ascii?Q?81kPcB/0Srby6xgLMIYPwWjGkSjbFiwT2U3mppg2lVqP8bCvo41Ydq2Mq7gU?=
 =?us-ascii?Q?wXzasABkuGf/kBNcRGDQbAmwJLMxUHw2+CB/ZBpMf4OlXLQuUh0ldjABBbfY?=
 =?us-ascii?Q?l46OK02HDmhAG8U8hWI6tPbj2VCCAA9qHnoUntplny3s?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd269a68-b911-4c65-ad98-08da5b9b46ed
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 19:52:49.5479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WvnXq+c83HhWDhS1w2uprRq9ryVWerkteD6+RIMznHzTCKc1wRJZyEFjbp9ZKkhrEjJh94eeIcEQRRl8biE8BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4047
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 30, 2022 at 09:14:06AM -0700, Davidlohr Bueso wrote:
> On Thu, 30 Jun 2022, Jonathan Cameron wrote:
> 
> > On Wed, 29 Jun 2022 22:32:57 -0700 Ira Weiny <ira.weiny@intel.com> wrote:
> 
> > > I _thought_ that we did not care if some mailboxes failed or not.
> > 
> > I have a different view to Dan on this.  In my view if your hardware is
> > not working in any way at all scream like mad don't carry on... Dan
> > is keen to try to muddle onwards.
> 
> I am also of the idea of not carrying on upon any indication of failure.
> 
> > > 
> > > If CDAT is not supported on any of the mailboxes found then CDAT will not show
> > > up on sysfs (as per Dan's last comment).  If it was supported on a mailbox but
> > > no data is found the sysfs will show up but be 0 length.
> > > 
> > > At this layer I thought we agreed to skip over these errors.  If a protocol is
> > > needed at a higher layer and it is not found on any of the mailboxes the errors
> > > should show up in that layer.  In this series CDAT is not 100% necessary as
> > > devices can work without it.  So the errors were mostly paper'ed over in favor
> > > of just printing error messages and muddle on.
> > > 
> > > The xa_insert() deserves a pci_err() though.
> > 
> > That's probably the minimum we should do.  The xa_insert() failing is something
> > horrible going wrong in our software / host afterall.
> 
> Yes. And in addition, devm_cxl_pci_create_doe() should return any error status, and
> cxl_pci_probe() can choose to omit any errors, but it's still better to have it.

I don't think this adds anything.  If devm_cxl_pci_create_doe() already prints
error messages what is cxl_pci_probe() going to do with the error if it does
not fail the probe?

I want devm_cxl_pci_create_doe() to continue trying to create the mailbox
objects.  So for now I'm going to print the errors in devm_cxl_pci_create_doe()
and keep going without returning any error.

Ira

> 
> Thanks,
> Davidlohr