Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220701134415.4017794-1-vincent.knecht@mailoo.org> <20220701134415.4017794-5-vincent.knecht@mailoo.org>
In-Reply-To: <20220701134415.4017794-5-vincent.knecht@mailoo.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 1 Jul 2022 22:47:49 +0200
Message-ID: <CAHp75Vf1nMi6OAbksNMCEkq3snrtDQSwRcSnbkB=gPwS=WWz9A@mail.gmail.com>
Subject: Re: [PATCH v2 4/6] leds: is31fl319x: Use non-wildcard names for vars,
 structs and defines
To:     Vincent Knecht <vincent.knecht@mailoo.org>
Cc:     Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        "H. Nikolaus Schaller" <hns@goldelico.com>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 1, 2022 at 3:45 PM Vincent Knecht <vincent.knecht@mailoo.org> wrote:
>
> In order to add real support for is31fl3190, is31fl3191 and is31fl3193,
> rename variant-dependent elements to not use 319X where needed.
>
> 3190 suffix is used for is31fl3190, is31fl3191 and is31fl3193 circuits.
> 3196 suffix is used for is31fl3196 and is31fl3199.
>
> Those two groups have different register maps, current settings and even
> a different interpretation of the software shutdown bit:
> https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf
> https://lumissil.com/assets/pdf/core/IS31FL3191_DS.pdf
> https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf
> https://lumissil.com/assets/pdf/core/IS31FL3196_DS.pdf
> https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf
>
> Rename variables, stuctures and defines in preparation of the splitting.

structures

> No functional nor behaviour change.

...

> +#define IS31FL3196_CONFIG2_CS_MASK     0x7

GENMASK() ?

...

> +#define IS31FL3196_CURRENT_MIN         ((u32)5000)
> +#define IS31FL3196_CURRENT_MAX         ((u32)40000)
> +#define IS31FL3196_CURRENT_STEP                ((u32)5000)
> +#define IS31FL3196_CURRENT_DEFAULT     ((u32)20000)

> +#define IS31FL3196_AUDIO_GAIN_DB_MAX   ((u32)21)
> +#define IS31FL3196_AUDIO_GAIN_DB_STEP  ((u32)3)

Why do you need all these castings? Wouldn't u/U suffice if you really
want to have them unsigned?

-- 
With Best Regards,
Andy Shevchenko