Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Jul 2022 14:04:49 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Terry Bowman <terry.bowman@amd.com>,
        katie.morris@in-advantage.com
Subject: Re: [PATCH v12 net-next 9/9] mfd: ocelot: add support for the
 vsc7512 chip via spi
Message-ID: <20220701210449.GA3973665@euler>
References: <20220701192609.3970317-1-colin.foster@in-advantage.com>
 <20220701192609.3970317-10-colin.foster@in-advantage.com>
 <CAHp75VcfKS9Y+T5LPRk0SFHJCGarJ2wS2gwii=a+1it03S+_Og@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75VcfKS9Y+T5LPRk0SFHJCGarJ2wS2gwii=a+1it03S+_Og@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RHgoluMkhYbkE7n2qkUwl1LUmCWYd5VId7u5nQ4TIooBzyjUy+4WOJ90waDI?=
 =?us-ascii?Q?96qwCQC4jUc1eROHEWDeJ/pkCkx7q/jsKc8vO++gra1UvyWnck/9KELJaRkU?=
 =?us-ascii?Q?qaPg0sPf2DN2f6J4h4XGgAFwOldB2mYbhFb5t+PTyAWFjhEz9hzgZeoVVnXI?=
 =?us-ascii?Q?9tLTOy5AX1yNrjTyoQuTvQpLlZYRrpmpuBxxrX4ddlTYQKdz1WtN2+SwwqxA?=
 =?us-ascii?Q?uAZFxMhbGRug0gQqT+j68UGFuvJqfl2C+avmlLKk7XZHEsXuFAg5cD4SZsRo?=
 =?us-ascii?Q?G8a9MtQS6VLaGrj+2mCV4s7K/kcO40EZGqWYrPtTeM63n2k6TIJbelcDtZ4a?=
 =?us-ascii?Q?glTQdxz8XDrl1VtBDWnxrSJAoP4JGwnzTQg1+MYS45pmf2nqN2aXFE+EF9EP?=
 =?us-ascii?Q?htlgpZrXMXcPZZBn9twZfjz8ytq3ZrH+WZbRCyMP2cqwO9Z1s7NRed3BuHh8?=
 =?us-ascii?Q?JksAbAyMrbS2PS44SEPblYqiKM5Wiwc6aF3eFs903HSHVJj6ATmGlXjIP/DS?=
 =?us-ascii?Q?CPFKgy66Bf6GJGuZsdiULO/I5CZa4P6f7kwlgdK1aFLNfROGlNyBHn25rWCb?=
 =?us-ascii?Q?jGXxqoWZRle/+axx9AKlLA4GsFhKq93k0P7ido7wLmKqCycFMDoHoXkm8TbF?=
 =?us-ascii?Q?PgFOQmjwf3YZDB8fc2u6iZOTglyZlR5JVVzF0ylpXkCGoqrp7KkFUrgOQ7aj?=
 =?us-ascii?Q?3moCEwZfEXmGNZqoDjp5OcYm7tS885n61bxy0f3OUslOP94EJX8hjNQar8Z8?=
 =?us-ascii?Q?FcFkoeFxZ1hDPahAC351B2vxSPxWorMZuvVgl9WeTxmQBAFGsFqoKDSVdVT9?=
 =?us-ascii?Q?PNCaVEyqmiXAOp8zRiJOUFYoCpCGgyYaqeeYEEYNrVJarxoCH9BfpqOM2uVT?=
 =?us-ascii?Q?pDsGfKjO1+kslfz0eywjEKZFSxN/597RHkiEz41p+PjQBe03DITO5pyESGnx?=
 =?us-ascii?Q?5bkAYIyeVwZRtJClUmPl/NKLqfQ2rY8l95OWCD143B//r4D53y0sibFskPUu?=
 =?us-ascii?Q?J/k0KQzuicnve7lo9RELvHyOa0vGVBVxLGAE2USqe1+ij7+PC8aIcmKKaJ2K?=
 =?us-ascii?Q?GUr5sa2MOWJSlYsMQRN0CdtJEuSaiSWi1Z7IF9BLldYSwi3rcehXnWCGEAQI?=
 =?us-ascii?Q?YObs/hMajU3FmlcsBh8dvxAnTKthV8C6UzcBYW1JGg+OC22VfCEA5Ckvu7/j?=
 =?us-ascii?Q?WN8VkrjjTsmwq8ujPVQLwFIQLn9tNvZLclTziUrXSEd7mUNE4wgv+Bq+Hamh?=
 =?us-ascii?Q?epq+nYjEWqLgWZ1gCNaZY6TZHbq+lvI8bh1w7bwO1EYqBM7PFY9OtgxvaBF0?=
 =?us-ascii?Q?UH9524cHJTVm3i/ljmCDfUser4sUCL0QXzSQ0u2Qy6Qz5pHquACBQt1iTHJG?=
 =?us-ascii?Q?XZIILhMzlHLsP+tqmAIazTjX+gckeYR4uW7X1+Yo0d4cNHKz2dT0i+uPnv4h?=
 =?us-ascii?Q?CGtZJMtU5zW9DwTvMg2ippTJmGVT8iqEYHjs3O3Ppx6K6DTKt5KyslvDASYX?=
 =?us-ascii?Q?AoIE/6qXZo+pBcsJkYO03yhu5WuiRBFjaPe410TWUACXv6GudhMVpDv+HUrS?=
 =?us-ascii?Q?n4HL7zInZq48N2Ok/HCZM69/XvkUQXaNbG7XBj9nP/QEhWYzx9bDPIeRlJep?=
 =?us-ascii?Q?iaLmnSZ2zxc40q5Mi/d/hO8=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2b9eee5-74c8-462a-e24d-08da5ba55ca1
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 21:05:01.0534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sq3MftUaMSgW59RRIzDhXcWvgXC/RojVktzfQxGR1ub9ZZV4/GZMMwGdqpCAmgrYnDuUjmI1fJ2qL0MH/nwjyyFCHJimHh2mcqG5uSym4KI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4674
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 01, 2022 at 10:38:46PM +0200, Andy Shevchenko wrote:
> On Fri, Jul 1, 2022 at 9:26 PM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> >
> > The VSC7512 is a networking chip that contains several peripherals. Many of
> > these peripherals are currently supported by the VSC7513 and VSC7514 chips,
> > but those run on an internal CPU. The VSC7512 lacks this CPU, and must be
> > controlled externally.
> >
> > Utilize the existing drivers by referencing the chip as an MFD. Add support
> > for the two MDIO buses, the internal phys, pinctrl, and serial GPIO.
> 
> ...
> 
> > +       static const u8 dummy_buf[16] = {0};
> 
> On stack for DMA?! Hmm...

I'll respond to the rest of your comments as I go through them. But this
one in particular I'll apologize for. Ew. I'll fix that right up!