Received: by 2002:ac0:cd04:0:0:0:0:0 with SMTP id w4csp247379imn; Fri, 1 Jul 2022 14:17:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tWS4vdheeCy/Q1bQBA0ZK0RReyjI0DWd6bUQwpnKCYn2cStFK8bAUBF8KHfRpQJAFh3kFG X-Received: by 2002:a17:902:7c0d:b0:16b:7dd2:626c with SMTP id x13-20020a1709027c0d00b0016b7dd2626cmr22717163pll.152.1656710246842; Fri, 01 Jul 2022 14:17:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656710246; cv=none; d=google.com; s=arc-20160816; b=Rc+jRBcqBMadV/LAmGbcxXR6NP/vv8nEbW7rqr7ULWsWiT5Bj/VFniXtXBw149G2wR hni0zar5hbamrAHG5jwfvrmdTq/qeVoQZ+phEsXP3On4PExDV83y5Q7haqXScO/dJQGp WLiZdBZ6kJFGXcXbyvVYHGs0rDkK3qGJW14KUZQeOK8pG6eIFAbxgteCx2/X5EghDbFa BLOXXezpLRMRrMVZJGfgs87a/FJVcfuv2sXOGEk041MHJBivU0Mrw3m5ThFDdi1zXpQp bBx6EDnmryRbQZle3h+XhKzv9yJTjIF3lKAIRItcnahVeQX4Ht2vqBkixvXO7oq7/C7w 4LPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=L3xyYkVUb08ki16owDdwA0s6fxyBYTVKhzo/OZc4swY=; b=vZsXHFgGMoeVXZu9Pdq+7n5lOV1Zv6i5eg91+diS4AHs/i5yIcWgsYtgal4RWtZEGS He4rY+XD9kzj6+br7820ByCFwDm+PExrnGvQ9O8hVzpdgzHhds95Lo2ZT7QxP5rYXUpO 3S2PbnwH0/We08LnBSyn8PSj5EDQ6BgGJaTodx5LtbD1y7fENsSoF1zvzwhMf/npmkmX vvOgImpD4ZP21tpVa5guENr4OfK6O13ehDXH2GVVtMJxvo/MfioiCXGIXebqqceTlLCO /ZdJvW9/i15XaZDRLZv8BXFXHq9H+G7oRwSGWIjPqY3E374eSWwCrZtgnXH2OVZLBYwQ qddQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Q2bHi8xG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b187-20020a6367c4000000b0040cc5bb15d8si26729866pgc.611.2022.07.01.14.17.15; Fri, 01 Jul 2022 14:17:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Q2bHi8xG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbiGAUt7 (ORCPT + 99 others); Fri, 1 Jul 2022 16:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231237AbiGAUts (ORCPT ); Fri, 1 Jul 2022 16:49:48 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2F516051C; Fri, 1 Jul 2022 13:49:46 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id 194so987224ybc.4; Fri, 01 Jul 2022 13:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L3xyYkVUb08ki16owDdwA0s6fxyBYTVKhzo/OZc4swY=; b=Q2bHi8xGPVEu5bceVUNZYHpmzzugqU9zcEOTOg2MdUoxdlZMrh2dhUi/3V/yVyoP8T 7JZKoRSgqiX3kGpk6q8nfQN+YnjerSQKLRyC5wB9fCeMncQJ3qV6JNf2cjyYqUtH+8NM pdl9uOadAWBK3qlpdDJd7bhS4ek7Jt+2teWEvzgDro4DgmMj/6UqIUVyrft2OnpZsIjb valYyD/7fj2Fg3XZsjwz0WFbMBR4OJjKVoa+i9poO3QyMXjzjnCbuPxui6Unq14iapP6 HLgpXiF/htqOgwAORxZbk3vYkJwLJnrzVADBiTnCagwQpcjAD42LQfLIDiM/Jnv7p14Z c5ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L3xyYkVUb08ki16owDdwA0s6fxyBYTVKhzo/OZc4swY=; b=hoP3kRxZBoTr0SSee1gkWBKvlMMDQkwsoLbTU4sFhYYI/VF7RlnLQWs8AMcJd8bRyl nIHeZIxVn+asVm/e963cFPup21Gm+vqOHatPbnwmizFewNPdOQMz4rcpLeJZDsMaMBiB WQrj76oiDIzmM59BiYbt3yEfCoJcYn9vZo+gIXORLPXNyb6aG2q+LPJ1xU1lYbvzSCxW uImUaQJQTTAIwYnRrJuVmtlh/GYhyuGoI1zLA00+um0dSHl5FS35I5vQNj+xg7wbBf6S j1TrlK6IBWmaq9kONH/qBivIbEC0okFDNG6jOCY+gyG0pEycoeJ9IGuFxHYE05p8kEZ5 wPGQ== X-Gm-Message-State: AJIora9i/dBkJqzCeChptcyKzi0iYbykXMuN2X/00gH6e8fQCznK8nmn kMXHl7S0so6L//fMCYVohNwXyNX9gG/2INnmKV8= X-Received: by 2002:a05:6902:1142:b0:66d:999a:81a7 with SMTP id p2-20020a056902114200b0066d999a81a7mr13503264ybu.460.1656708586203; Fri, 01 Jul 2022 13:49:46 -0700 (PDT) MIME-Version: 1.0 References: <20220701134415.4017794-1-vincent.knecht@mailoo.org> <20220701134415.4017794-5-vincent.knecht@mailoo.org> In-Reply-To: From: Andy Shevchenko Date: Fri, 1 Jul 2022 22:49:08 +0200 Message-ID: Subject: Re: [PATCH v2 4/6] leds: is31fl319x: Use non-wildcard names for vars, structs and defines To: Vincent Knecht Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , "H. Nikolaus Schaller" , Linux LED Subsystem , devicetree , Linux Kernel Mailing List , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 1, 2022 at 10:47 PM Andy Shevchenko wrote: > On Fri, Jul 1, 2022 at 3:45 PM Vincent Knecht wrote: ... > > +#define IS31FL3196_CURRENT_MIN ((u32)5000) > > +#define IS31FL3196_CURRENT_MAX ((u32)40000) > > +#define IS31FL3196_CURRENT_STEP ((u32)5000) > > +#define IS31FL3196_CURRENT_DEFAULT ((u32)20000) Also why no units as below, for example, has? > > +#define IS31FL3196_AUDIO_GAIN_DB_MAX ((u32)21) > > +#define IS31FL3196_AUDIO_GAIN_DB_STEP ((u32)3) -- With Best Regards, Andy Shevchenko