Received: by 2002:ac0:cd04:0:0:0:0:0 with SMTP id w4csp447185imn; Fri, 1 Jul 2022 20:18:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uVl9hnHRyY/BeMK+mEk7VsnCeiz3gXYE8GbZ1ZjoY0LGfRCdXg2D6+O5hsIJaWYDcRO61V X-Received: by 2002:a62:82cb:0:b0:525:79d9:ddc4 with SMTP id w194-20020a6282cb000000b0052579d9ddc4mr23050115pfd.48.1656731904944; Fri, 01 Jul 2022 20:18:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656731904; cv=none; d=google.com; s=arc-20160816; b=SDXnHflQWhcc0MSawPr44zhJJ1LDlkZaT0thMHSixVdaePnSeEnp0LKFw0eLDw+gn/ XXgJ9BPS2H+w4GQ8KKwGOixtEa2dZsiqplnjoPpiGQvAZKIiGw/EgzjqsSm6Vj7DZfEq 7w2TZ0SBsl/5uVNUv9qROQlWOfYW9UQz38BTBKdo1EXzslzBYL7eqieO/9CwhBPbzJ1k kgTyH8VyHbN6B4L3nT4ZX+X1sh2LApeCsdglXVfyIU9bkwAonbUyi5nMIrj7XVHZbJjC ZB/N5h6kDFJO2XgYtXgDKLee+BWyyDjhI+T0iPLFqLJfgh2iMpO/4wW044wISBm2MdMe vM3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=UtMkqemIiwcBAdV1SVOL29qQ4SXO5o3beVizwBErOy8=; b=tggGAntpNXNvY/zEv7pjGQz8fNv7uYCnWjIh4gt+DEV9yQ/6uSwiQfOTAABvkmPW1P 8UlZKdsmdABuy6uercF0QvEE92m0PDIjp+9PbR0h4V58RCdcbmRwLKlLmPKJBysf8FS/ 3tYdBdFnhPUeG830ew6rRad90uv3AZAx7bx3VvxjTOZ9p8n8M3JEfu+MxiWwt8ITOxYO pz4HIyKxsTBoo9yehHLxFz+MiTqA1O2GKosFKsgCJ/oud6W/ukBXv5PoOLsLvLC2mqi7 U6RT1TDksH0LwQ1ulmgSTA+/ilt6txsLXQ1dIBeWFSQ0vJ9QlPuib7iJSIYYIsgeuZrM jCkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DSkhhUR7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id om8-20020a17090b3a8800b001ecc27c8cbesi15062643pjb.168.2022.07.01.20.18.12; Fri, 01 Jul 2022 20:18:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DSkhhUR7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231547AbiGBDCq (ORCPT + 99 others); Fri, 1 Jul 2022 23:02:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbiGBDCo (ORCPT ); Fri, 1 Jul 2022 23:02:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ECD2377D4; Fri, 1 Jul 2022 20:02:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F7CD61903; Sat, 2 Jul 2022 03:02:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 110AEC341C6; Sat, 2 Jul 2022 03:02:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656730962; bh=QZKkKnbfMMAAGcvlDsl6UzLYU+1c9zGZndPC4xxCHWk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DSkhhUR7voEI82iNnVEEhuYItFrUt78qLJuiMf77EQdhHeUpY7aWjwHpVdSQBzjGg z9t3J0Qs+iW4GRZm7XjU37JcyuOSiqrv6knxWaDBxo37MfnmHprJIwYAgwfFd8epJk tAITY9hH/vmgCHGCb8sboE479usE1f47pbf+XOVcfH2WuYp+F5/6x5nB7o3w5OUJ5J E4NrzEaOhXe2gVy39juqToD++AKquSrS86/Z7vJNdBRbA0yLRM96v9P0L3nuvClSp7 XsfAMYq5D5LbzfdkB7AHObfsNwRWVDXRaDRnRFZXrUuzMEiJy8mPT/otSlRoigA/u4 btew7iHktCeTw== Date: Fri, 1 Jul 2022 20:02:41 -0700 From: Jakub Kicinski To: Colin Foster Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Vladimir Oltean , Lee Jones , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Linus Walleij , Wolfram Sang , Terry Bowman , Andy Shevchenko , katie.morris@in-advantage.com Subject: Re: [PATCH v12 net-next 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Message-ID: <20220701200241.388e1fd5@kernel.org> In-Reply-To: <20220701192609.3970317-10-colin.foster@in-advantage.com> References: <20220701192609.3970317-1-colin.foster@in-advantage.com> <20220701192609.3970317-10-colin.foster@in-advantage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Jul 2022 12:26:09 -0700 Colin Foster wrote: > The VSC7512 is a networking chip that contains several peripherals. Many of > these peripherals are currently supported by the VSC7513 and VSC7514 chips, > but those run on an internal CPU. The VSC7512 lacks this CPU, and must be > controlled externally. > > Utilize the existing drivers by referencing the chip as an MFD. Add support > for the two MDIO buses, the internal phys, pinctrl, and serial GPIO. allmodconfig is not happy, I didn't spot that being mentioned as expected: ERROR: modpost: "ocelot_spi_init_regmap" [drivers/mfd/ocelot-core.ko] undefined! WARNING: modpost: module ocelot-spi uses symbol ocelot_chip_reset from namespace MFD_OCELOT, but does not import it. WARNING: modpost: module ocelot-spi uses symbol ocelot_core_init from namespace MFD_OCELOT, but does not import it. make[2]: *** [../scripts/Makefile.modpost:128: modules-only.symvers] Error 1 make[1]: *** [/home/nipa/net-next/Makefile:1757: modules] Error 2